[INFO] fetching crate os-detect 0.2.2... [INFO] checking os-detect-0.2.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate os-detect 0.2.2 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate os-detect 0.2.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate os-detect 0.2.2 [INFO] finished tweaking crates.io crate os-detect 0.2.2 [INFO] tweaked toml for crates.io crate os-detect 0.2.2 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 68 packages to latest compatible versions [INFO] [stderr] Adding bindgen v0.59.2 (latest: v0.70.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding err-derive v0.2.4 (latest: v0.3.1) [INFO] [stderr] Adding errno v0.2.8 (latest: v0.3.9) [INFO] [stderr] Adding partition-identity v0.2.8 (latest: v0.3.0) [INFO] [stderr] Adding peeking_take_while v0.1.2 (latest: v1.0.0) [INFO] [stderr] Adding rand v0.4.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding remove_dir_all v0.5.3 (latest: v0.8.3) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding smart-default v0.6.0 (latest: v0.7.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] [stderr] Adding sys-mount v1.5.1 (latest: v3.0.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c255bd6a2cb10641b80b44e86994389619e284916c5f684c2fa81b63d5e25778 [INFO] running `Command { std: "docker" "start" "-a" "c255bd6a2cb10641b80b44e86994389619e284916c5f684c2fa81b63d5e25778", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c255bd6a2cb10641b80b44e86994389619e284916c5f684c2fa81b63d5e25778", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c255bd6a2cb10641b80b44e86994389619e284916c5f684c2fa81b63d5e25778", kill_on_drop: false }` [INFO] [stdout] c255bd6a2cb10641b80b44e86994389619e284916c5f684c2fa81b63d5e25778 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 38a8391939857999f332a92b11b4a9d7158079e8452afb68fe352c9c420958e0 [INFO] running `Command { std: "docker" "start" "-a" "38a8391939857999f332a92b11b4a9d7158079e8452afb68fe352c9c420958e0", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling libloading v0.8.5 [INFO] [stderr] Compiling bindgen v0.59.2 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling clang-sys v1.8.1 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Compiling peeking_take_while v0.1.2 [INFO] [stderr] Compiling lazycell v1.3.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking errno v0.2.8 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Compiling err-derive v0.2.4 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking os-release v0.1.0 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling smart-default v0.6.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking partition-identity v0.2.8 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling loopdev v0.4.0 [INFO] [stderr] Checking sys-mount v1.5.1 [INFO] [stderr] Checking os-detect v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> src/lib.rs:18:1 [INFO] [stdout] | [INFO] [stdout] 18 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> src/lib.rs:18:1 [INFO] [stdout] | [INFO] [stdout] 18 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn detect_os_from_device<'a, F: Into>>(device: &Path, fs: F) -> Option { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | // Create a temporary directoy where we will mount the FS. [INFO] [stdout] 53 | TempDir::new("distinst").ok().and_then(|tempdir| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:53:44 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn detect_os_from_device<'a, F: Into>>(device: &Path, fs: F) -> Option { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | // Create a temporary directoy where we will mount the FS. [INFO] [stdout] 53 | TempDir::new("distinst").ok().and_then(|tempdir| { [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 54 | | // Mount the FS to the temporary directory [INFO] [stdout] 55 | | let base = tempdir.path(); [INFO] [stdout] 56 | | Mount::new(device, base, fs, MountFlags::empty(), None) [INFO] [stdout] ... | [INFO] [stdout] 59 | | .and_then(|_mount| detect_os_from_path(base)) [INFO] [stdout] 60 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn detect_os_from_device<'a, F: Into>>(device: &Path, fs: F) -> Option { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | // Create a temporary directoy where we will mount the FS. [INFO] [stdout] 53 | TempDir::new("distinst").ok().and_then(|tempdir| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | / Mount::new(device, base, fs, MountFlags::empty(), None) [INFO] [stdout] 57 | | .map(|m| m.into_unmount_drop(UnmountFlags::DETACH)) [INFO] [stdout] 58 | | .ok() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:90:25 [INFO] [stdout] | [INFO] [stdout] 89 | .and_then(|file| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | parse_plist(BufReader::new(file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:176:5 [INFO] [stdout] | [INFO] [stdout] 175 | fn open>(path: P) -> io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | File::open(&path).map_err(|why| io::Error::new( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `os-detect` (lib) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn detect_os_from_device<'a, F: Into>>(device: &Path, fs: F) -> Option { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | // Create a temporary directoy where we will mount the FS. [INFO] [stdout] 53 | TempDir::new("distinst").ok().and_then(|tempdir| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:53:44 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn detect_os_from_device<'a, F: Into>>(device: &Path, fs: F) -> Option { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | // Create a temporary directoy where we will mount the FS. [INFO] [stdout] 53 | TempDir::new("distinst").ok().and_then(|tempdir| { [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 54 | | // Mount the FS to the temporary directory [INFO] [stdout] 55 | | let base = tempdir.path(); [INFO] [stdout] 56 | | Mount::new(device, base, fs, MountFlags::empty(), None) [INFO] [stdout] ... | [INFO] [stdout] 59 | | .and_then(|_mount| detect_os_from_path(base)) [INFO] [stdout] 60 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn detect_os_from_device<'a, F: Into>>(device: &Path, fs: F) -> Option { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | // Create a temporary directoy where we will mount the FS. [INFO] [stdout] 53 | TempDir::new("distinst").ok().and_then(|tempdir| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | / Mount::new(device, base, fs, MountFlags::empty(), None) [INFO] [stdout] 57 | | .map(|m| m.into_unmount_drop(UnmountFlags::DETACH)) [INFO] [stdout] 58 | | .ok() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:90:25 [INFO] [stdout] | [INFO] [stdout] 89 | .and_then(|file| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | parse_plist(BufReader::new(file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:176:5 [INFO] [stdout] | [INFO] [stdout] 175 | fn open>(path: P) -> io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | File::open(&path).map_err(|why| io::Error::new( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `os-detect` (lib test) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "38a8391939857999f332a92b11b4a9d7158079e8452afb68fe352c9c420958e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "38a8391939857999f332a92b11b4a9d7158079e8452afb68fe352c9c420958e0", kill_on_drop: false }` [INFO] [stdout] 38a8391939857999f332a92b11b4a9d7158079e8452afb68fe352c9c420958e0