[INFO] fetching crate orq 0.1.1... [INFO] checking orq-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate orq 0.1.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate orq 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate orq 0.1.1 [INFO] finished tweaking crates.io crate orq 0.1.1 [INFO] tweaked toml for crates.io crate orq 0.1.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate orq 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dc615617cc9b953c9e0cb6f3df62227433d8426312848ea027a0ca406774e4ac [INFO] running `Command { std: "docker" "start" "-a" "dc615617cc9b953c9e0cb6f3df62227433d8426312848ea027a0ca406774e4ac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dc615617cc9b953c9e0cb6f3df62227433d8426312848ea027a0ca406774e4ac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dc615617cc9b953c9e0cb6f3df62227433d8426312848ea027a0ca406774e4ac", kill_on_drop: false }` [INFO] [stdout] dc615617cc9b953c9e0cb6f3df62227433d8426312848ea027a0ca406774e4ac [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 184e61624990a09fdf6a74eed7104a0b14335901e7f813b361b3fda9029b0177 [INFO] running `Command { std: "docker" "start" "-a" "184e61624990a09fdf6a74eed7104a0b14335901e7f813b361b3fda9029b0177", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.10 [INFO] [stderr] Compiling libc v0.2.69 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.17 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling cc v1.0.50 [INFO] [stderr] Checking futures-core v0.3.4 [INFO] [stderr] Compiling proc-macro-nested v0.1.4 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling proc-macro-hack v0.5.15 [INFO] [stderr] Checking futures-sink v0.3.4 [INFO] [stderr] Checking futures-task v0.3.4 [INFO] [stderr] Checking pin-utils v0.1.0-alpha.4 [INFO] [stderr] Compiling failure_derive v0.1.7 [INFO] [stderr] Checking futures-io v0.3.4 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Checking arc-swap v0.4.5 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking futures-channel v0.3.4 [INFO] [stderr] Checking pin-project-lite v0.1.4 [INFO] [stderr] Checking bytes v0.5.4 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking signal-hook-registry v1.2.0 [INFO] [stderr] Compiling quote v1.0.3 [INFO] [stderr] Compiling backtrace-sys v0.1.35 [INFO] [stderr] Checking mio v0.6.21 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking backtrace v0.3.46 [INFO] [stderr] Compiling synstructure v0.12.3 [INFO] [stderr] Compiling futures-macro v0.3.4 [INFO] [stderr] Compiling tokio-macros v0.2.5 [INFO] [stderr] Checking tokio v0.2.18 [INFO] [stderr] Checking failure v0.1.7 [INFO] [stderr] Checking futures-util v0.3.4 [INFO] [stderr] Checking futures-executor v0.3.4 [INFO] [stderr] Checking futures v0.3.4 [INFO] [stderr] Checking orq v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:131:8 [INFO] [stdout] | [INFO] [stdout] 100 | let stdout = handle [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | let stderr = handle [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | let stdout_lines = BufReader::new(stdout) [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | let stderr_lines = BufReader::new(stderr) [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | Ok(stdout_lines.merge(stderr_lines)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:148:14 [INFO] [stdout] | [INFO] [stdout] 146 | let child = spawn_child(&line).ok()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | index += 1; [INFO] [stdout] 148 | Some(ChildHandle { [INFO] [stdout] | ______________^ [INFO] [stdout] 149 | | child, [INFO] [stdout] 150 | | label: line, [INFO] [stdout] 151 | | color: color_by_index(index), [INFO] [stdout] 152 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input_parser.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn read_commands(source: impl AsyncRead) -> impl Stream { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | BufReader::new(source).lines().filter_map(|x| x.ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:131:8 [INFO] [stdout] | [INFO] [stdout] 100 | let stdout = handle [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | let stderr = handle [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | let stdout_lines = BufReader::new(stdout) [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | let stderr_lines = BufReader::new(stderr) [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | Ok(stdout_lines.merge(stderr_lines)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:148:14 [INFO] [stdout] | [INFO] [stdout] 146 | let child = spawn_child(&line).ok()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | index += 1; [INFO] [stdout] 148 | Some(ChildHandle { [INFO] [stdout] | ______________^ [INFO] [stdout] 149 | | child, [INFO] [stdout] 150 | | label: line, [INFO] [stdout] 151 | | color: color_by_index(index), [INFO] [stdout] 152 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input_parser.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn read_commands(source: impl AsyncRead) -> impl Stream { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | BufReader::new(source).lines().filter_map(|x| x.ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `orq` (bin "orq") due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `orq` (bin "orq" test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "184e61624990a09fdf6a74eed7104a0b14335901e7f813b361b3fda9029b0177", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "184e61624990a09fdf6a74eed7104a0b14335901e7f813b361b3fda9029b0177", kill_on_drop: false }` [INFO] [stdout] 184e61624990a09fdf6a74eed7104a0b14335901e7f813b361b3fda9029b0177