[INFO] fetching crate oro-pretty-json 0.3.34... [INFO] checking oro-pretty-json-0.3.34 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate oro-pretty-json 0.3.34 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate oro-pretty-json 0.3.34 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate oro-pretty-json 0.3.34 [INFO] finished tweaking crates.io crate oro-pretty-json 0.3.34 [INFO] tweaked toml for crates.io crate oro-pretty-json 0.3.34 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 14 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] de8aa519f277db41571eff87c7db2037c57615126d2090ecc6bb880cb4eca617 [INFO] running `Command { std: "docker" "start" "-a" "de8aa519f277db41571eff87c7db2037c57615126d2090ecc6bb880cb4eca617", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "de8aa519f277db41571eff87c7db2037c57615126d2090ecc6bb880cb4eca617", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "de8aa519f277db41571eff87c7db2037c57615126d2090ecc6bb880cb4eca617", kill_on_drop: false }` [INFO] [stdout] de8aa519f277db41571eff87c7db2037c57615126d2090ecc6bb880cb4eca617 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cea0783bae7802a3582f44deab58922ba7b260e67a898416ab5b3044f50b1c34 [INFO] running `Command { std: "docker" "start" "-a" "cea0783bae7802a3582f44deab58922ba7b260e67a898416ab5b3044f50b1c34", kill_on_drop: false }` [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking oro-pretty-json v0.3.34 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn from_str(json: impl AsRef) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let json = json.as_ref(); [INFO] [stdout] 17 | let value = serde_json::from_str(json)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | Ok(Formatted { [INFO] [stdout] | ________^ [INFO] [stdout] 21 | | value, [INFO] [stdout] 22 | | character, [INFO] [stdout] 23 | | count, [INFO] [stdout] 24 | | line_end, [INFO] [stdout] 25 | | trailing_line_end, [INFO] [stdout] 26 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `oro-pretty-json` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn from_str(json: impl AsRef) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let json = json.as_ref(); [INFO] [stdout] 17 | let value = serde_json::from_str(json)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | Ok(Formatted { [INFO] [stdout] | ________^ [INFO] [stdout] 21 | | value, [INFO] [stdout] 22 | | character, [INFO] [stdout] 23 | | count, [INFO] [stdout] 24 | | line_end, [INFO] [stdout] 25 | | trailing_line_end, [INFO] [stdout] 26 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `oro-pretty-json` (lib test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "cea0783bae7802a3582f44deab58922ba7b260e67a898416ab5b3044f50b1c34", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cea0783bae7802a3582f44deab58922ba7b260e67a898416ab5b3044f50b1c34", kill_on_drop: false }` [INFO] [stdout] cea0783bae7802a3582f44deab58922ba7b260e67a898416ab5b3044f50b1c34