[INFO] fetching crate oro-package-spec 0.3.34... [INFO] checking oro-package-spec-0.3.34 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate oro-package-spec 0.3.34 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate oro-package-spec 0.3.34 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate oro-package-spec 0.3.34 [INFO] finished tweaking crates.io crate oro-package-spec 0.3.34 [INFO] tweaked toml for crates.io crate oro-package-spec 0.3.34 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 26 packages to latest compatible versions [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding miette v5.10.0 (latest: v7.2.0) [INFO] [stderr] Adding miette-derive v5.10.0 (latest: v7.2.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d403be43ebc9c193aa3ce20a32083e001ded85fb310f3e2406e0403d7a0d4c2e [INFO] running `Command { std: "docker" "start" "-a" "d403be43ebc9c193aa3ce20a32083e001ded85fb310f3e2406e0403d7a0d4c2e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d403be43ebc9c193aa3ce20a32083e001ded85fb310f3e2406e0403d7a0d4c2e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d403be43ebc9c193aa3ce20a32083e001ded85fb310f3e2406e0403d7a0d4c2e", kill_on_drop: false }` [INFO] [stdout] d403be43ebc9c193aa3ce20a32083e001ded85fb310f3e2406e0403d7a0d4c2e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 995bc9fac863a164ab5f26d39e1a1bdcfc796acbf8160e0b2434d8eac9dcfbe0 [INFO] running `Command { std: "docker" "start" "-a" "995bc9fac863a164ab5f26d39e1a1bdcfc796acbf8160e0b2434d8eac9dcfbe0", kill_on_drop: false }` [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking bytecount v0.6.8 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling miette-derive v5.10.0 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking miette v5.10.0 [INFO] [stderr] Checking node-semver v2.1.0 [INFO] [stderr] Checking oro-package-spec v0.3.34 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:158:11 [INFO] [stdout] | [INFO] [stdout] 153 | fn parse_package_spec(input: I) -> Result [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | match all_consuming(package::package_spec)(input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:89:19 [INFO] [stdout] | [INFO] [stdout] 85 | fn from_error_kind(input: I, _kind: nom::error::ErrorKind) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | kind: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:139:19 [INFO] [stdout] | [INFO] [stdout] 135 | fn from_external_error(input: &'a str, _kind: ErrorKind, e: PackageSpecError) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | kind: Some(SpecErrorKind::GitHostParseError(Box::new(e))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gitinfo.rs:240:11 [INFO] [stdout] | [INFO] [stdout] 235 | fn parse_gitinfo(input: I) -> Result [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | match all_consuming(git::git_spec)(input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsers/alias.rs:32:27 [INFO] [stdout] | [INFO] [stdout] 23 | |(scope, name, _, arg)| { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | spec: Box::new(arg), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `oro-package-spec` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:158:11 [INFO] [stdout] | [INFO] [stdout] 153 | fn parse_package_spec(input: I) -> Result [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | match all_consuming(package::package_spec)(input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:89:19 [INFO] [stdout] | [INFO] [stdout] 85 | fn from_error_kind(input: I, _kind: nom::error::ErrorKind) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | kind: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:139:19 [INFO] [stdout] | [INFO] [stdout] 135 | fn from_external_error(input: &'a str, _kind: ErrorKind, e: PackageSpecError) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | kind: Some(SpecErrorKind::GitHostParseError(Box::new(e))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gitinfo.rs:240:11 [INFO] [stdout] | [INFO] [stdout] 235 | fn parse_gitinfo(input: I) -> Result [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | match all_consuming(git::git_spec)(input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsers/alias.rs:32:27 [INFO] [stdout] | [INFO] [stdout] 23 | |(scope, name, _, arg)| { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | spec: Box::new(arg), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `oro-package-spec` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "995bc9fac863a164ab5f26d39e1a1bdcfc796acbf8160e0b2434d8eac9dcfbe0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "995bc9fac863a164ab5f26d39e1a1bdcfc796acbf8160e0b2434d8eac9dcfbe0", kill_on_drop: false }` [INFO] [stdout] 995bc9fac863a164ab5f26d39e1a1bdcfc796acbf8160e0b2434d8eac9dcfbe0