[INFO] fetching crate ormlitex-attr 0.17.1... [INFO] checking ormlitex-attr-0.17.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ormlitex-attr 0.17.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate ormlitex-attr 0.17.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ormlitex-attr 0.17.1 [INFO] finished tweaking crates.io crate ormlitex-attr 0.17.1 [INFO] tweaked toml for crates.io crate ormlitex-attr 0.17.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 52 packages to latest compatible versions [INFO] [stderr] Adding darling v0.14.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_core v0.14.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_macro v0.14.4 (latest: v0.20.10) [INFO] [stderr] Adding derive_builder v0.12.0 (latest: v0.20.1) [INFO] [stderr] Adding derive_builder_core v0.12.0 (latest: v0.20.1) [INFO] [stderr] Adding derive_builder_macro v0.12.0 (latest: v0.20.1) [INFO] [stderr] Adding sqlmo v0.16.4 (latest: v0.17.2) [INFO] [stderr] Adding strsim v0.10.0 (latest: v0.11.1) [INFO] [stderr] Adding structmeta v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding structmeta-derive v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 40e15fa6b857009710e56ae30ba9ff9483dd0b4e2e478baec4605c9bf538a11f [INFO] running `Command { std: "docker" "start" "-a" "40e15fa6b857009710e56ae30ba9ff9483dd0b4e2e478baec4605c9bf538a11f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "40e15fa6b857009710e56ae30ba9ff9483dd0b4e2e478baec4605c9bf538a11f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "40e15fa6b857009710e56ae30ba9ff9483dd0b4e2e478baec4605c9bf538a11f", kill_on_drop: false }` [INFO] [stdout] 40e15fa6b857009710e56ae30ba9ff9483dd0b4e2e478baec4605c9bf538a11f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3a4892426671867144951e6f20154c25fde034bb2e2f37c4e467552cc125ed04 [INFO] running `Command { std: "docker" "start" "-a" "3a4892426671867144951e6f20154c25fde034bb2e2f37c4e467552cc125ed04", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking sqlmo v0.16.4 [INFO] [stderr] Checking convert_case v0.6.0 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking ignore v0.4.22 [INFO] [stderr] Compiling darling_core v0.14.4 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling structmeta-derive v0.2.0 [INFO] [stderr] Checking structmeta v0.2.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling darling_macro v0.14.4 [INFO] [stderr] Compiling darling v0.14.4 [INFO] [stderr] Compiling derive_builder_core v0.12.0 [INFO] [stderr] Compiling derive_builder_macro v0.12.0 [INFO] [stderr] Checking derive_builder v0.12.0 [INFO] [stderr] Checking ormlitex-attr v0.17.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: type `ormlitexSchema` should have an upper camel case name [INFO] [stdout] --> src/lib.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct ormlitexSchema { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to upper camel case (notice the capitalization): `OrmlitexSchema` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `ormlitexSchema` should have an upper camel case name [INFO] [stdout] --> src/lib.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct ormlitexSchema { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to upper camel case (notice the capitalization): `OrmlitexSchema` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:126:8 [INFO] [stdout] | [INFO] [stdout] 89 | let walk = paths.iter().flat_map(Walk::new); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | [INFO] [stdout] 91 | let walk = walk.filter_map(|e| e.ok()) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | let mut tables = vec![]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | Ok(ormlitexSchema { [INFO] [stdout] | ________^ [INFO] [stdout] 127 | | tables, [INFO] [stdout] 128 | | type_reprs: type_aliases, [INFO] [stdout] 129 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:266:19 [INFO] [stdout] | [INFO] [stdout] 263 | pub fn new(name: &str, columns: Vec) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 264 | let inner = TableMetadata::new(name, columns); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 265 | Self { [INFO] [stdout] 266 | pkey: inner.columns.iter() [INFO] [stdout] | ___________________^ [INFO] [stdout] 267 | | .find(|c| c.column_name == "id") [INFO] [stdout] 268 | | .unwrap() [INFO] [stdout] 269 | | .clone(), [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:321:12 [INFO] [stdout] | [INFO] [stdout] 307 | let meta = TableMetadata::from_derive(ast)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 312 | let pkey = meta.columns.iter().find(|&c| c.column_name == pkey).unwrap().clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 321 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 322 | | inner: meta, [INFO] [stdout] 323 | | insert_struct, [INFO] [stdout] 324 | | pkey, [INFO] [stdout] 325 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:376:12 [INFO] [stdout] | [INFO] [stdout] 360 | let mut columns = ast.fields() [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 376 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 377 | | table_name, [INFO] [stdout] 378 | | struct_name, [INFO] [stdout] 379 | | columns, [INFO] [stdout] 380 | | databases, [INFO] [stdout] 381 | | pkey, [INFO] [stdout] 382 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:577:9 [INFO] [stdout] | [INFO] [stdout] 511 | let mut builder = ColumnMetadata::builder(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 516 | let ty = TType::from(&ty.path); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 577 | builder.build().map_err(|e| SyndecodeError(e.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:126:8 [INFO] [stdout] | [INFO] [stdout] 89 | let walk = paths.iter().flat_map(Walk::new); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | [INFO] [stdout] 91 | let walk = walk.filter_map(|e| e.ok()) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | let mut tables = vec![]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | Ok(ormlitexSchema { [INFO] [stdout] | ________^ [INFO] [stdout] 127 | | tables, [INFO] [stdout] 128 | | type_reprs: type_aliases, [INFO] [stdout] 129 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:266:19 [INFO] [stdout] | [INFO] [stdout] 263 | pub fn new(name: &str, columns: Vec) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 264 | let inner = TableMetadata::new(name, columns); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 265 | Self { [INFO] [stdout] 266 | pkey: inner.columns.iter() [INFO] [stdout] | ___________________^ [INFO] [stdout] 267 | | .find(|c| c.column_name == "id") [INFO] [stdout] 268 | | .unwrap() [INFO] [stdout] 269 | | .clone(), [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:321:12 [INFO] [stdout] | [INFO] [stdout] 307 | let meta = TableMetadata::from_derive(ast)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 312 | let pkey = meta.columns.iter().find(|&c| c.column_name == pkey).unwrap().clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 321 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 322 | | inner: meta, [INFO] [stdout] 323 | | insert_struct, [INFO] [stdout] 324 | | pkey, [INFO] [stdout] 325 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:376:12 [INFO] [stdout] | [INFO] [stdout] 360 | let mut columns = ast.fields() [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 376 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 377 | | table_name, [INFO] [stdout] 378 | | struct_name, [INFO] [stdout] 379 | | columns, [INFO] [stdout] 380 | | databases, [INFO] [stdout] 381 | | pkey, [INFO] [stdout] 382 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:577:9 [INFO] [stdout] | [INFO] [stdout] 511 | let mut builder = ColumnMetadata::builder(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 516 | let ty = TType::from(&ty.path); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 577 | builder.build().map_err(|e| SyndecodeError(e.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ormlitex-attr` (lib) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ormlitex-attr` (lib test) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "3a4892426671867144951e6f20154c25fde034bb2e2f37c4e467552cc125ed04", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3a4892426671867144951e6f20154c25fde034bb2e2f37c4e467552cc125ed04", kill_on_drop: false }` [INFO] [stdout] 3a4892426671867144951e6f20154c25fde034bb2e2f37c4e467552cc125ed04