[INFO] fetching crate ormlite-attr 0.18.1... [INFO] checking ormlite-attr-0.18.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ormlite-attr 0.18.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate ormlite-attr 0.18.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ormlite-attr 0.18.1 [INFO] finished tweaking crates.io crate ormlite-attr 0.18.1 [INFO] tweaked toml for crates.io crate ormlite-attr 0.18.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 42 packages to latest compatible versions [INFO] [stderr] Adding sqlmo v0.16.4 (latest: v0.17.2) [INFO] [stderr] Adding structmeta v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding structmeta-derive v0.2.0 (latest: v0.3.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cac718218e37c53f98b5b9d6a8050315b8ed60a0ada157006bc4c120de0a5893 [INFO] running `Command { std: "docker" "start" "-a" "cac718218e37c53f98b5b9d6a8050315b8ed60a0ada157006bc4c120de0a5893", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cac718218e37c53f98b5b9d6a8050315b8ed60a0ada157006bc4c120de0a5893", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cac718218e37c53f98b5b9d6a8050315b8ed60a0ada157006bc4c120de0a5893", kill_on_drop: false }` [INFO] [stdout] cac718218e37c53f98b5b9d6a8050315b8ed60a0ada157006bc4c120de0a5893 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 50e9b671dc93a2c55e42483d206db7b6444f6b3aee5317a322247df319eee660 [INFO] running `Command { std: "docker" "start" "-a" "50e9b671dc93a2c55e42483d206db7b6444f6b3aee5317a322247df319eee660", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking sqlmo v0.16.4 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking convert_case v0.6.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking ignore v0.4.22 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling structmeta-derive v0.2.0 [INFO] [stderr] Checking structmeta v0.2.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking ormlite-attr v0.18.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:181:8 [INFO] [stdout] | [INFO] [stdout] 132 | let walk = paths.iter().flat_map(Walk::new); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | [INFO] [stdout] 134 | let walk = walk [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | let mut tables = vec![]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | Ok(OrmliteSchema { [INFO] [stdout] | ________^ [INFO] [stdout] 182 | | tables, [INFO] [stdout] 183 | | type_reprs: type_aliases, [INFO] [stdout] 184 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:118:21 [INFO] [stdout] | [INFO] [stdout] 118 | .filter(|p| fs::metadata(p).is_err()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cfg_attr.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 15 | let _condition: Meta = input.parse()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let _: Comma = input.parse()?; [INFO] [stdout] 17 | let attrs = input.parse_terminated(Meta::parse, Token![,])?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Ok(CfgAttr { attrs }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata/model.rs:19:19 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn new(name: &str, columns: Vec) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let inner = TableMetadata::new(name, columns); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Self { [INFO] [stdout] 19 | pkey: inner.columns.iter() [INFO] [stdout] | ___________________^ [INFO] [stdout] 20 | | .find(|c| c.column_name == "id") [INFO] [stdout] 21 | | .unwrap() [INFO] [stdout] 22 | | .clone(), [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata/model.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 60 | let inner = TableMetadata::from_derive(ast)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let pkey = inner.columns.iter().find(|&c| c.column_name == pkey).unwrap().clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | Ok(Self { inner, insert_struct, pkey }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata/table.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 47 | let mut columns = ast.fields() [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 64 | | table_name, [INFO] [stdout] 65 | | struct_name, [INFO] [stdout] 66 | | columns, [INFO] [stdout] 67 | | databases, [INFO] [stdout] 68 | | pkey, [INFO] [stdout] 69 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ormlite-attr` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:181:8 [INFO] [stdout] | [INFO] [stdout] 132 | let walk = paths.iter().flat_map(Walk::new); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | [INFO] [stdout] 134 | let walk = walk [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | let mut tables = vec![]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | Ok(OrmliteSchema { [INFO] [stdout] | ________^ [INFO] [stdout] 182 | | tables, [INFO] [stdout] 183 | | type_reprs: type_aliases, [INFO] [stdout] 184 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:118:21 [INFO] [stdout] | [INFO] [stdout] 118 | .filter(|p| fs::metadata(p).is_err()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cfg_attr.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 15 | let _condition: Meta = input.parse()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let _: Comma = input.parse()?; [INFO] [stdout] 17 | let attrs = input.parse_terminated(Meta::parse, Token![,])?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Ok(CfgAttr { attrs }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata/model.rs:19:19 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn new(name: &str, columns: Vec) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let inner = TableMetadata::new(name, columns); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Self { [INFO] [stdout] 19 | pkey: inner.columns.iter() [INFO] [stdout] | ___________________^ [INFO] [stdout] 20 | | .find(|c| c.column_name == "id") [INFO] [stdout] 21 | | .unwrap() [INFO] [stdout] 22 | | .clone(), [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata/model.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 60 | let inner = TableMetadata::from_derive(ast)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let pkey = inner.columns.iter().find(|&c| c.column_name == pkey).unwrap().clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | Ok(Self { inner, insert_struct, pkey }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata/table.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 47 | let mut columns = ast.fields() [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 64 | | table_name, [INFO] [stdout] 65 | | struct_name, [INFO] [stdout] 66 | | columns, [INFO] [stdout] 67 | | databases, [INFO] [stdout] 68 | | pkey, [INFO] [stdout] 69 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ormlite-attr` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "50e9b671dc93a2c55e42483d206db7b6444f6b3aee5317a322247df319eee660", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "50e9b671dc93a2c55e42483d206db7b6444f6b3aee5317a322247df319eee660", kill_on_drop: false }` [INFO] [stdout] 50e9b671dc93a2c55e42483d206db7b6444f6b3aee5317a322247df319eee660