[INFO] fetching crate orlok 0.3.0... [INFO] checking orlok-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate orlok 0.3.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate orlok 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate orlok 0.3.0 [INFO] finished tweaking crates.io crate orlok 0.3.0 [INFO] tweaked toml for crates.io crate orlok 0.3.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 202 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding ahash v0.7.8 (latest: v0.8.11) [INFO] [stderr] Adding atoi v1.0.0 (latest: v2.0.0) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding bytecheck v0.6.12 (latest: v0.7.0) [INFO] [stderr] Adding bytecheck_derive v0.6.12 (latest: v0.7.0) [INFO] [stderr] Adding dirs v4.0.0 (latest: v5.0.1) [INFO] [stderr] Adding dirs-sys v0.3.7 (latest: v0.4.1) [INFO] [stderr] Adding event-listener v2.5.3 (latest: v5.3.1) [INFO] [stderr] Adding futures-intrusive v0.4.2 (latest: v0.5.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding hashlink v0.8.4 (latest: v0.9.1) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding parking_lot v0.11.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.8.6 (latest: v0.9.10) [INFO] [stderr] Adding ptr_meta v0.1.4 (latest: v0.2.0) [INFO] [stderr] Adding ptr_meta_derive v0.1.4 (latest: v0.2.0) [INFO] [stderr] Adding radium v0.7.0 (latest: v1.1.0) [INFO] [stderr] Adding redox_syscall v0.2.16 (latest: v0.5.3) [INFO] [stderr] Adding redox_syscall v0.4.1 (latest: v0.5.3) [INFO] [stderr] Adding ring v0.16.20 (latest: v0.17.8) [INFO] [stderr] Adding rustls v0.20.9 (latest: v0.23.12) [INFO] [stderr] Adding rustls-pemfile v1.0.4 (latest: v2.1.3) [INFO] [stderr] Adding spin v0.5.2 (latest: v0.9.8) [INFO] [stderr] Adding sqlx v0.6.3 (latest: v0.8.1) [INFO] [stderr] Adding sqlx-core v0.6.3 (latest: v0.8.1) [INFO] [stderr] Adding sqlx-macros v0.6.3 (latest: v0.8.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding tokio-rustls v0.23.4 (latest: v0.26.0) [INFO] [stderr] Adding untrusted v0.7.1 (latest: v0.9.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding webpki-roots v0.22.6 (latest: v0.26.5) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding wyz v0.5.1 (latest: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 51088065d9d3ea374b401a5e45f6307fb3e5eae7822b7f7121dd2254b41becb2 [INFO] running `Command { std: "docker" "start" "-a" "51088065d9d3ea374b401a5e45f6307fb3e5eae7822b7f7121dd2254b41becb2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "51088065d9d3ea374b401a5e45f6307fb3e5eae7822b7f7121dd2254b41becb2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "51088065d9d3ea374b401a5e45f6307fb3e5eae7822b7f7121dd2254b41becb2", kill_on_drop: false }` [INFO] [stdout] 51088065d9d3ea374b401a5e45f6307fb3e5eae7822b7f7121dd2254b41becb2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d8bc8c79292b49307a0980c35e14bafe9d3fc786861f69ae7b8129d9f5c345b7 [INFO] running `Command { std: "docker" "start" "-a" "d8bc8c79292b49307a0980c35e14bafe9d3fc786861f69ae7b8129d9f5c345b7", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling rustls v0.20.9 [INFO] [stderr] Compiling spin v0.9.8 [INFO] [stderr] Compiling untrusted v0.9.0 [INFO] [stderr] Checking ring v0.17.8 [INFO] [stderr] Compiling digest v0.10.7 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Compiling rust_decimal v1.36.0 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Compiling spin v0.5.2 [INFO] [stderr] Compiling untrusted v0.7.1 [INFO] [stderr] Compiling tokio v1.40.0 [INFO] [stderr] Compiling instant v0.1.13 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Compiling arrayvec v0.7.6 [INFO] [stderr] Checking webpki v0.22.4 [INFO] [stderr] Compiling sct v0.7.1 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling num-integer v0.1.46 [INFO] [stderr] Compiling parking_lot v0.11.2 [INFO] [stderr] Compiling hmac v0.12.1 [INFO] [stderr] Compiling dirs-sys v0.3.7 [INFO] [stderr] Compiling iana-time-zone v0.1.60 [INFO] [stderr] Compiling base64 v0.21.7 [INFO] [stderr] Compiling hashbrown v0.12.3 [INFO] [stderr] Compiling futures-task v0.3.30 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling futures-util v0.3.30 [INFO] [stderr] Compiling rustls-pemfile v1.0.4 [INFO] [stderr] Compiling chrono v0.4.38 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling sqlformat v0.2.4 [INFO] [stderr] Compiling num-bigint v0.4.6 [INFO] [stderr] Compiling dirs v4.0.0 [INFO] [stderr] Compiling futures-intrusive v0.4.2 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling zerocopy v0.7.35 [INFO] [stderr] Compiling ppv-lite86 v0.2.20 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling tokio-rustls v0.23.4 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling sqlx-rt v0.6.3 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling hashlink v0.8.4 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling tokio-stream v0.1.15 [INFO] [stderr] Compiling hkdf v0.12.4 [INFO] [stderr] Compiling webpki-roots v0.22.6 [INFO] [stderr] Compiling sha2 v0.10.8 [INFO] [stderr] Compiling sha1 v0.10.6 [INFO] [stderr] Compiling atoi v1.0.0 [INFO] [stderr] Compiling md-5 v0.10.6 [INFO] [stderr] Compiling whoami v1.5.1 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling base64 v0.13.1 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling uuid v1.10.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking tokio-test v0.4.4 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Compiling rust_decimal_macros v1.36.0 [INFO] [stderr] Checking sqlx-core v0.6.3 [INFO] [stderr] Compiling sqlx-macros v0.6.3 [INFO] [stderr] Checking sqlx v0.6.3 [INFO] [stderr] Checking orlok v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json.rs:377:5 [INFO] [stdout] | [INFO] [stdout] 373 | async fn transaction(&self, action: A) -> Result [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 377 | / { [INFO] [stdout] 378 | | let initial_state = self.data.read().await.clone(); [INFO] [stdout] 379 | | [INFO] [stdout] 380 | | match action(&self).await { [INFO] [stdout] ... | [INFO] [stdout] 388 | | } [INFO] [stdout] 389 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pg.rs:700:5 [INFO] [stdout] | [INFO] [stdout] 696 | async fn transaction(&self, action: A) -> Result [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 700 | / { [INFO] [stdout] 701 | | let wrapped = RwLock::new(match self { [INFO] [stdout] 702 | | Self::Transaction(_) => todo!(), [INFO] [stdout] 703 | | Self::Pool(p) => p.begin().await?, [INFO] [stdout] ... | [INFO] [stdout] 721 | | } [INFO] [stdout] 722 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query.rs:480:19 [INFO] [stdout] | [INFO] [stdout] 479 | pub fn not(filter: F) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 480 | Self::Not(Box::new(filter)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query.rs:523:21 [INFO] [stdout] | [INFO] [stdout] 521 | pub fn filter(filter: F) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 522 | Self { [INFO] [stdout] 523 | filter: Some(filter), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `orlok` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json.rs:377:5 [INFO] [stdout] | [INFO] [stdout] 373 | async fn transaction(&self, action: A) -> Result [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 377 | / { [INFO] [stdout] 378 | | let initial_state = self.data.read().await.clone(); [INFO] [stdout] 379 | | [INFO] [stdout] 380 | | match action(&self).await { [INFO] [stdout] ... | [INFO] [stdout] 388 | | } [INFO] [stdout] 389 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pg.rs:700:5 [INFO] [stdout] | [INFO] [stdout] 696 | async fn transaction(&self, action: A) -> Result [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 700 | / { [INFO] [stdout] 701 | | let wrapped = RwLock::new(match self { [INFO] [stdout] 702 | | Self::Transaction(_) => todo!(), [INFO] [stdout] 703 | | Self::Pool(p) => p.begin().await?, [INFO] [stdout] ... | [INFO] [stdout] 721 | | } [INFO] [stdout] 722 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query.rs:480:19 [INFO] [stdout] | [INFO] [stdout] 479 | pub fn not(filter: F) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 480 | Self::Not(Box::new(filter)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query.rs:523:21 [INFO] [stdout] | [INFO] [stdout] 521 | pub fn filter(filter: F) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 522 | Self { [INFO] [stdout] 523 | filter: Some(filter), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `orlok` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "d8bc8c79292b49307a0980c35e14bafe9d3fc786861f69ae7b8129d9f5c345b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d8bc8c79292b49307a0980c35e14bafe9d3fc786861f69ae7b8129d9f5c345b7", kill_on_drop: false }` [INFO] [stdout] d8bc8c79292b49307a0980c35e14bafe9d3fc786861f69ae7b8129d9f5c345b7