[INFO] fetching crate organix 0.1.3... [INFO] checking organix-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate organix 0.1.3 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate organix 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate organix 0.1.3 [INFO] finished tweaking crates.io crate organix 0.1.3 [INFO] tweaked toml for crates.io crate organix 0.1.3 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate organix 0.1.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 05a069d2a48cd0ac83d60d2b2df9fb966e4170c5978b45937703e7458ace1cc5 [INFO] running `Command { std: "docker" "start" "-a" "05a069d2a48cd0ac83d60d2b2df9fb966e4170c5978b45937703e7458ace1cc5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "05a069d2a48cd0ac83d60d2b2df9fb966e4170c5978b45937703e7458ace1cc5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "05a069d2a48cd0ac83d60d2b2df9fb966e4170c5978b45937703e7458ace1cc5", kill_on_drop: false }` [INFO] [stdout] 05a069d2a48cd0ac83d60d2b2df9fb966e4170c5978b45937703e7458ace1cc5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cc97a32b2223cd488c440e4fafc299b16f29616fcf41d10fe5a072c5800b9b01 [INFO] running `Command { std: "docker" "start" "-a" "cc97a32b2223cd488c440e4fafc299b16f29616fcf41d10fe5a072c5800b9b01", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.12 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling libc v0.2.70 [INFO] [stderr] Compiling syn v1.0.21 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking futures v0.1.29 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling version_check v0.9.1 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking tracing-core v0.1.10 [INFO] [stderr] Checking smallvec v1.4.0 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Compiling serde v1.0.110 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling proc-macro-nested v0.1.4 [INFO] [stderr] Checking arc-swap v0.4.6 [INFO] [stderr] Compiling proc-macro-hack v0.5.15 [INFO] [stderr] Checking once_cell v1.4.0 [INFO] [stderr] Checking futures-core v0.3.5 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.2 [INFO] [stderr] Compiling proc-macro-error v1.0.2 [INFO] [stderr] Checking regex-syntax v0.6.17 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Checking smallvec v0.6.13 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Compiling ryu v1.0.4 [INFO] [stderr] Checking futures-task v0.3.5 [INFO] [stderr] Compiling parking_lot_core v0.6.2 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Checking bytes v0.5.4 [INFO] [stderr] Checking pin-project-lite v0.1.5 [INFO] [stderr] Checking futures-sink v0.3.5 [INFO] [stderr] Checking aho-corasick v0.7.10 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Checking tracing-log v0.1.1 [INFO] [stderr] Checking sharded-slab v0.0.9 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.34 [INFO] [stderr] Checking parking_lot_core v0.7.2 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Compiling quote v1.0.5 [INFO] [stderr] Checking parking_lot v0.10.2 [INFO] [stderr] Checking signal-hook-registry v1.2.0 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking mio v0.6.22 [INFO] [stderr] Checking tokio-sync v0.1.8 [INFO] [stderr] Checking tokio-executor v0.1.10 [INFO] [stderr] Checking tokio-timer v0.2.13 [INFO] [stderr] Checking tokio-current-thread v0.1.7 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Checking regex v1.3.7 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Checking tokio-io v0.1.13 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Checking chrono v0.4.11 [INFO] [stderr] Checking tokio-reactor v0.1.12 [INFO] [stderr] Checking matchers v0.0.1 [INFO] [stderr] Checking tracing-serde v0.1.1 [INFO] [stderr] Checking serde_json v1.0.53 [INFO] [stderr] Checking tracing-subscriber v0.2.5 [INFO] [stderr] Compiling syn-mid v0.5.0 [INFO] [stderr] Compiling pin-project-internal v0.4.16 [INFO] [stderr] Compiling tracing-attributes v0.1.7 [INFO] [stderr] Compiling tokio-macros v0.2.5 [INFO] [stderr] Compiling futures-macro v0.3.5 [INFO] [stderr] Compiling thiserror-impl v1.0.17 [INFO] [stderr] Compiling async-trait v0.1.31 [INFO] [stderr] Checking tokio v0.2.21 [INFO] [stderr] Compiling organix-derive v0.1.0 [INFO] [stderr] Checking tracing v0.1.13 [INFO] [stderr] Checking thiserror v1.0.17 [INFO] [stderr] Checking pin-project v0.4.16 [INFO] [stderr] Checking futures-util v0.3.5 [INFO] [stderr] Checking tracing-futures v0.2.4 [INFO] [stderr] Checking tokio-compat v0.1.6 [INFO] [stderr] Checking organix v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 27 | let watchdog = Runtime::build(RuntimeConfig::watchdog())?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let shared = Runtime::build(RuntimeConfig::shared())?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | [INFO] [stdout] 30 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 31 | | watchdog, [INFO] [stdout] 32 | | shared, [INFO] [stdout] 33 | | individuals: HashMap::new(), [INFO] [stdout] 34 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 68 | let mut builder = tokio::runtime::Builder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | / builder [INFO] [stdout] 93 | | .threaded_scheduler() [INFO] [stdout] 94 | | .build() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service/mod.rs:169:22 [INFO] [stdout] | [INFO] [stdout] 159 | let status = StatusReader::new(Status::shutdown()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | let controller = runtime.block_on(async { Controller::new().await }); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | let (intercom_sender, _, intercom_stats) = intercom::channel(); [INFO] [stdout] | --------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | runtime: runtime.handle().clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service/mod.rs:251:46 [INFO] [stdout] | [INFO] [stdout] 245 | let runner = T::prepare(service_state); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 248 | let span = tracing::info_span!("service", service_identifier); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 249 | let _enter = span.enter(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | [INFO] [stdout] 251 | runner.start().in_current_span().await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service/intercom.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 71 | let (sender, receiver) = mpsc::channel(10); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | [INFO] [stdout] 73 | let sent_counter = Arc::new(AtomicU64::new(0)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let received_counter = Arc::new(AtomicU64::new(0)); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | let stats = Arc::new(Mutex::new(Stats::new())); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | / IntercomSender { [INFO] [stdout] 79 | | sender, [INFO] [stdout] 80 | | sent_counter: Arc::clone(&sent_counter), [INFO] [stdout] 81 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service/intercom.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 71 | let (sender, receiver) = mpsc::channel(10); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | [INFO] [stdout] 73 | let sent_counter = Arc::new(AtomicU64::new(0)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let received_counter = Arc::new(AtomicU64::new(0)); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | let stats = Arc::new(Mutex::new(Stats::new())); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | / IntercomReceiver { [INFO] [stdout] 83 | | receiver, [INFO] [stdout] 84 | | received_counter: Arc::clone(&received_counter), [INFO] [stdout] 85 | | stats: Arc::clone(&stats), [INFO] [stdout] 86 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service/intercom.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 71 | let (sender, receiver) = mpsc::channel(10); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | [INFO] [stdout] 73 | let sent_counter = Arc::new(AtomicU64::new(0)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let received_counter = Arc::new(AtomicU64::new(0)); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | let stats = Arc::new(Mutex::new(Stats::new())); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | / IntercomStats { [INFO] [stdout] 88 | | sent_counter, [INFO] [stdout] 89 | | received_counter, [INFO] [stdout] 90 | | stats, [INFO] [stdout] 91 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service/intercom.rs:98:20 [INFO] [stdout] | [INFO] [stdout] 96 | pub(crate) fn new(watchdog_query: WatchdogQuery) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | Self { [INFO] [stdout] 98 | state: IntercomState::NotConnected, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service/intercom.rs:324:9 [INFO] [stdout] | [INFO] [stdout] 322 | fn try_send(&mut self, t: T) -> Result<(), TrySendError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 323 | self.sent_counter.fetch_add(1, Ordering::SeqCst); [INFO] [stdout] 324 | / self.sender [INFO] [stdout] 325 | | .try_send((Instant::now(), t)) [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watchdog/mod.rs:110:68 [INFO] [stdout] | [INFO] [stdout] 95 | let (sender, receiver) = mpsc::channel(10); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | let watchdog = Watchdog { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | let query = WatchdogQuery::new(watchdog_query_handle, sender.clone()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | .spawn(async move { watchdog.watchdog(receiver, query).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watchdog/monitor.rs:54:23 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn wait_finished(self) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let Self { [INFO] [stdout] 47 | mut runtimes, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | watchdog_finished, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | .block_on(async move { watchdog_finished.await.unwrap() }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watchdog/monitor.rs:54:54 [INFO] [stdout] | [INFO] [stdout] 48 | watchdog_finished, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | .block_on(async move { watchdog_finished.await.unwrap() }) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `organix` (lib) due to 13 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 27 | let watchdog = Runtime::build(RuntimeConfig::watchdog())?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let shared = Runtime::build(RuntimeConfig::shared())?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | [INFO] [stdout] 30 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 31 | | watchdog, [INFO] [stdout] 32 | | shared, [INFO] [stdout] 33 | | individuals: HashMap::new(), [INFO] [stdout] 34 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 68 | let mut builder = tokio::runtime::Builder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | / builder [INFO] [stdout] 93 | | .threaded_scheduler() [INFO] [stdout] 94 | | .build() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service/mod.rs:169:22 [INFO] [stdout] | [INFO] [stdout] 159 | let status = StatusReader::new(Status::shutdown()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | let controller = runtime.block_on(async { Controller::new().await }); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | let (intercom_sender, _, intercom_stats) = intercom::channel(); [INFO] [stdout] | --------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | runtime: runtime.handle().clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service/mod.rs:251:46 [INFO] [stdout] | [INFO] [stdout] 245 | let runner = T::prepare(service_state); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 248 | let span = tracing::info_span!("service", service_identifier); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 249 | let _enter = span.enter(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | [INFO] [stdout] 251 | runner.start().in_current_span().await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service/intercom.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 71 | let (sender, receiver) = mpsc::channel(10); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | [INFO] [stdout] 73 | let sent_counter = Arc::new(AtomicU64::new(0)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let received_counter = Arc::new(AtomicU64::new(0)); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | let stats = Arc::new(Mutex::new(Stats::new())); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | / IntercomSender { [INFO] [stdout] 79 | | sender, [INFO] [stdout] 80 | | sent_counter: Arc::clone(&sent_counter), [INFO] [stdout] 81 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service/intercom.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 71 | let (sender, receiver) = mpsc::channel(10); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | [INFO] [stdout] 73 | let sent_counter = Arc::new(AtomicU64::new(0)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let received_counter = Arc::new(AtomicU64::new(0)); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | let stats = Arc::new(Mutex::new(Stats::new())); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | / IntercomReceiver { [INFO] [stdout] 83 | | receiver, [INFO] [stdout] 84 | | received_counter: Arc::clone(&received_counter), [INFO] [stdout] 85 | | stats: Arc::clone(&stats), [INFO] [stdout] 86 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service/intercom.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 71 | let (sender, receiver) = mpsc::channel(10); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | [INFO] [stdout] 73 | let sent_counter = Arc::new(AtomicU64::new(0)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let received_counter = Arc::new(AtomicU64::new(0)); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | let stats = Arc::new(Mutex::new(Stats::new())); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | / IntercomStats { [INFO] [stdout] 88 | | sent_counter, [INFO] [stdout] 89 | | received_counter, [INFO] [stdout] 90 | | stats, [INFO] [stdout] 91 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service/intercom.rs:98:20 [INFO] [stdout] | [INFO] [stdout] 96 | pub(crate) fn new(watchdog_query: WatchdogQuery) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | Self { [INFO] [stdout] 98 | state: IntercomState::NotConnected, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service/intercom.rs:324:9 [INFO] [stdout] | [INFO] [stdout] 322 | fn try_send(&mut self, t: T) -> Result<(), TrySendError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 323 | self.sent_counter.fetch_add(1, Ordering::SeqCst); [INFO] [stdout] 324 | / self.sender [INFO] [stdout] 325 | | .try_send((Instant::now(), t)) [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watchdog/mod.rs:110:68 [INFO] [stdout] | [INFO] [stdout] 95 | let (sender, receiver) = mpsc::channel(10); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | let watchdog = Watchdog { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | let query = WatchdogQuery::new(watchdog_query_handle, sender.clone()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | .spawn(async move { watchdog.watchdog(receiver, query).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watchdog/monitor.rs:54:23 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn wait_finished(self) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let Self { [INFO] [stdout] 47 | mut runtimes, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | watchdog_finished, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | .block_on(async move { watchdog_finished.await.unwrap() }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watchdog/monitor.rs:54:54 [INFO] [stdout] | [INFO] [stdout] 48 | watchdog_finished, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | .block_on(async move { watchdog_finished.await.unwrap() }) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `organix` (lib test) due to 13 previous errors [INFO] running `Command { std: "docker" "inspect" "cc97a32b2223cd488c440e4fafc299b16f29616fcf41d10fe5a072c5800b9b01", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cc97a32b2223cd488c440e4fafc299b16f29616fcf41d10fe5a072c5800b9b01", kill_on_drop: false }` [INFO] [stdout] cc97a32b2223cd488c440e4fafc299b16f29616fcf41d10fe5a072c5800b9b01