[INFO] fetching crate orestaty 1.0.0... [INFO] checking orestaty-1.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate orestaty 1.0.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate orestaty 1.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate orestaty 1.0.0 [INFO] finished tweaking crates.io crate orestaty 1.0.0 [INFO] tweaked toml for crates.io crate orestaty 1.0.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate orestaty 1.0.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3f3adab3c88aa649ba59e844e6b914c8813a5488c6bbbc529d4a81f605a081f6 [INFO] running `Command { std: "docker" "start" "-a" "3f3adab3c88aa649ba59e844e6b914c8813a5488c6bbbc529d4a81f605a081f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3f3adab3c88aa649ba59e844e6b914c8813a5488c6bbbc529d4a81f605a081f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3f3adab3c88aa649ba59e844e6b914c8813a5488c6bbbc529d4a81f605a081f6", kill_on_drop: false }` [INFO] [stdout] 3f3adab3c88aa649ba59e844e6b914c8813a5488c6bbbc529d4a81f605a081f6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 044a2e20be5c0b8cf4f519eab0b1542f0fb2784e27ee015131bf87bdd318f8cb [INFO] running `Command { std: "docker" "start" "-a" "044a2e20be5c0b8cf4f519eab0b1542f0fb2784e27ee015131bf87bdd318f8cb", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Compiling syn v2.0.76 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Compiling onig_sys v69.8.1 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling smartstring v1.0.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Checking quick-xml v0.32.0 [INFO] [stderr] Compiling serde_yml v0.0.12 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking codemap v0.1.3 [INFO] [stderr] Compiling pulldown-cmark v0.11.2 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking libyml v0.0.5 [INFO] [stderr] Checking pulldown-cmark-escape v0.11.0 [INFO] [stderr] Checking unindent v0.2.3 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling phf_macros v0.11.2 [INFO] [stderr] Compiling rhai_codegen v2.2.0 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling pest v2.7.11 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking onig v6.4.0 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking indexmap v2.4.0 [INFO] [stderr] Checking lasso v0.7.3 [INFO] [stderr] Compiling pest_meta v2.7.11 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking grass_compiler v0.13.4 [INFO] [stderr] Compiling pest_generator v2.7.11 [INFO] [stderr] Compiling pest_derive v2.7.11 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking thin-vec v0.2.13 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking plist v1.7.0 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking rhai v1.19.0 [INFO] [stderr] Checking syntect v5.2.0 [INFO] [stderr] Checking grass v0.13.4 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking handlebars v5.1.2 [INFO] [stderr] Checking orestaty v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:98:34 [INFO] [stdout] | [INFO] [stdout] 92 | let mut handlebars = handlebars::Handlebars::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | syntax_highlighting: ArcMutex::new( [INFO] [stdout] | __________________________________^ [INFO] [stdout] 99 | | plugins::syntax_highlighting::SyntaxHighlighting::new( [INFO] [stdout] 100 | | &config.code_highlight_theme, [INFO] [stdout] 101 | | root_path, [INFO] [stdout] ... | [INFO] [stdout] 104 | | .into(), [INFO] [stdout] 105 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/page/mod.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 19 | params: T, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | let page = Page { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | let page = PageWithContent { page, content }; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | self.unwrap_or_error( [INFO] [stdout] 45 | self.handlebars.render(template, &page), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugins/syntax_highlighting/mod.rs:64:14 [INFO] [stdout] | [INFO] [stdout] 36 | let theme = if theme == "css-classed" { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | Some(Self { [INFO] [stdout] | ______________^ [INFO] [stdout] 65 | | syntax_set: syntect::parsing::SyntaxSet::load_defaults_newlines(), [INFO] [stdout] 66 | | theme, [INFO] [stdout] 67 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugins/syntax_highlighting/mod.rs:48:29 [INFO] [stdout] | [INFO] [stdout] 47 | .and_then(|theme_file| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | / syntect::highlighting::ThemeSet::load_from_reader( [INFO] [stdout] 49 | | &mut std::io::BufReader::new(theme_file), [INFO] [stdout] 50 | | ) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugins/syntax_highlighting/mod.rs:206:9 [INFO] [stdout] | [INFO] [stdout] 196 | events: impl IntoIterator> + 'a, [INFO] [stdout] | ---------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | events.into_iter().filter_map(move |event| match event { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `orestaty` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:98:34 [INFO] [stdout] | [INFO] [stdout] 92 | let mut handlebars = handlebars::Handlebars::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | syntax_highlighting: ArcMutex::new( [INFO] [stdout] | __________________________________^ [INFO] [stdout] 99 | | plugins::syntax_highlighting::SyntaxHighlighting::new( [INFO] [stdout] 100 | | &config.code_highlight_theme, [INFO] [stdout] 101 | | root_path, [INFO] [stdout] ... | [INFO] [stdout] 104 | | .into(), [INFO] [stdout] 105 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/page/mod.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 19 | params: T, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | let page = Page { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | let page = PageWithContent { page, content }; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | self.unwrap_or_error( [INFO] [stdout] 45 | self.handlebars.render(template, &page), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugins/syntax_highlighting/mod.rs:64:14 [INFO] [stdout] | [INFO] [stdout] 36 | let theme = if theme == "css-classed" { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | Some(Self { [INFO] [stdout] | ______________^ [INFO] [stdout] 65 | | syntax_set: syntect::parsing::SyntaxSet::load_defaults_newlines(), [INFO] [stdout] 66 | | theme, [INFO] [stdout] 67 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugins/syntax_highlighting/mod.rs:48:29 [INFO] [stdout] | [INFO] [stdout] 47 | .and_then(|theme_file| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | / syntect::highlighting::ThemeSet::load_from_reader( [INFO] [stdout] 49 | | &mut std::io::BufReader::new(theme_file), [INFO] [stdout] 50 | | ) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugins/syntax_highlighting/mod.rs:206:9 [INFO] [stdout] | [INFO] [stdout] 196 | events: impl IntoIterator> + 'a, [INFO] [stdout] | ---------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | events.into_iter().filter_map(move |event| match event { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `orestaty` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "044a2e20be5c0b8cf4f519eab0b1542f0fb2784e27ee015131bf87bdd318f8cb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "044a2e20be5c0b8cf4f519eab0b1542f0fb2784e27ee015131bf87bdd318f8cb", kill_on_drop: false }` [INFO] [stdout] 044a2e20be5c0b8cf4f519eab0b1542f0fb2784e27ee015131bf87bdd318f8cb