[INFO] fetching crate ordered-channel 1.1.0... [INFO] checking ordered-channel-1.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ordered-channel 1.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate ordered-channel 1.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ordered-channel 1.1.0 [INFO] finished tweaking crates.io crate ordered-channel 1.1.0 [INFO] tweaked toml for crates.io crate ordered-channel 1.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 3 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e1100820326658e81b37b90056991fae14126583b3d80a11cd75eb5f7c00fcb6 [INFO] running `Command { std: "docker" "start" "-a" "e1100820326658e81b37b90056991fae14126583b3d80a11cd75eb5f7c00fcb6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e1100820326658e81b37b90056991fae14126583b3d80a11cd75eb5f7c00fcb6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e1100820326658e81b37b90056991fae14126583b3d80a11cd75eb5f7c00fcb6", kill_on_drop: false }` [INFO] [stdout] e1100820326658e81b37b90056991fae14126583b3d80a11cd75eb5f7c00fcb6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3e4e883a7ab6b6325d1111db0f5a2207a75d8c77ab70ba5576e21869c9ace4b3 [INFO] running `Command { std: "docker" "start" "-a" "3e4e883a7ab6b6325d1111db0f5a2207a75d8c77ab70ba5576e21869c9ace4b3", kill_on_drop: false }` [INFO] [stderr] Checking ordered-channel v1.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:131:10 [INFO] [stdout] | [INFO] [stdout] 130 | let (tx, rx) = plain_bounded(depth); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | make(SenderKind::Bounded(tx), rx) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:140:10 [INFO] [stdout] | [INFO] [stdout] 139 | let (tx, rx) = plain_unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | make(SenderKind::Unbounded(tx), rx) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:144:6 [INFO] [stdout] | [INFO] [stdout] 143 | fn make(sender: SenderKind>, receiver: PlainReceiver>) -> (Sender, Receiver) { [INFO] [stdout] | --------------------------------- -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | (Sender { [INFO] [stdout] | ______^ [INFO] [stdout] 145 | | sender, [INFO] [stdout] 146 | | }, Receiver { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:146:8 [INFO] [stdout] | [INFO] [stdout] 143 | fn make(sender: SenderKind>, receiver: PlainReceiver>) -> (Sender, Receiver) { [INFO] [stdout] | --------------------------------- -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | }, Receiver { [INFO] [stdout] | ________^ [INFO] [stdout] 147 | | receiver, [INFO] [stdout] 148 | | next_index: 0, [INFO] [stdout] 149 | | receive_buffer: BinaryHeap::new() [INFO] [stdout] 150 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:162:9 [INFO] [stdout] | [INFO] [stdout] 160 | pub fn send(&self, index: usize, item: T) -> Result<(), SendError> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | let pair = OrderByKey(index, item); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | / match &self.sender { [INFO] [stdout] 163 | | SenderKind::Bounded(s) => s.send(pair), [INFO] [stdout] 164 | | SenderKind::Unbounded(s) => s.send(pair), [INFO] [stdout] 165 | | }.map_err(|e| SendError(e.0.1)) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ordered-channel` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:131:10 [INFO] [stdout] | [INFO] [stdout] 130 | let (tx, rx) = plain_bounded(depth); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | make(SenderKind::Bounded(tx), rx) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:140:10 [INFO] [stdout] | [INFO] [stdout] 139 | let (tx, rx) = plain_unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | make(SenderKind::Unbounded(tx), rx) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:144:6 [INFO] [stdout] | [INFO] [stdout] 143 | fn make(sender: SenderKind>, receiver: PlainReceiver>) -> (Sender, Receiver) { [INFO] [stdout] | --------------------------------- -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | (Sender { [INFO] [stdout] | ______^ [INFO] [stdout] 145 | | sender, [INFO] [stdout] 146 | | }, Receiver { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:146:8 [INFO] [stdout] | [INFO] [stdout] 143 | fn make(sender: SenderKind>, receiver: PlainReceiver>) -> (Sender, Receiver) { [INFO] [stdout] | --------------------------------- -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | }, Receiver { [INFO] [stdout] | ________^ [INFO] [stdout] 147 | | receiver, [INFO] [stdout] 148 | | next_index: 0, [INFO] [stdout] 149 | | receive_buffer: BinaryHeap::new() [INFO] [stdout] 150 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:162:9 [INFO] [stdout] | [INFO] [stdout] 160 | pub fn send(&self, index: usize, item: T) -> Result<(), SendError> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | let pair = OrderByKey(index, item); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | / match &self.sender { [INFO] [stdout] 163 | | SenderKind::Bounded(s) => s.send(pair), [INFO] [stdout] 164 | | SenderKind::Unbounded(s) => s.send(pair), [INFO] [stdout] 165 | | }.map_err(|e| SendError(e.0.1)) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ordered-channel` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "3e4e883a7ab6b6325d1111db0f5a2207a75d8c77ab70ba5576e21869c9ace4b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3e4e883a7ab6b6325d1111db0f5a2207a75d8c77ab70ba5576e21869c9ace4b3", kill_on_drop: false }` [INFO] [stdout] 3e4e883a7ab6b6325d1111db0f5a2207a75d8c77ab70ba5576e21869c9ace4b3