[INFO] fetching crate orbit-server 0.1.0... [INFO] checking orbit-server-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate orbit-server 0.1.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate orbit-server 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate orbit-server 0.1.0 [INFO] finished tweaking crates.io crate orbit-server 0.1.0 [INFO] tweaked toml for crates.io crate orbit-server 0.1.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate orbit-server 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fec2581e759598da11a54df625d4536fa81524ccd816f77fe83133685c61c56c [INFO] running `Command { std: "docker" "start" "-a" "fec2581e759598da11a54df625d4536fa81524ccd816f77fe83133685c61c56c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fec2581e759598da11a54df625d4536fa81524ccd816f77fe83133685c61c56c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fec2581e759598da11a54df625d4536fa81524ccd816f77fe83133685c61c56c", kill_on_drop: false }` [INFO] [stdout] fec2581e759598da11a54df625d4536fa81524ccd816f77fe83133685c61c56c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0e8a29f36acae8f5f3f598f35c56fe5e876ce32f985f4ab063db8fdbb845d7b7 [INFO] running `Command { std: "docker" "start" "-a" "0e8a29f36acae8f5f3f598f35c56fe5e876ce32f985f4ab063db8fdbb845d7b7", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Checking bytes v1.6.1 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling syn v2.0.71 [INFO] [stderr] Compiling tokio v1.29.1 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling cc v1.1.6 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling axum-core v0.4.3 [INFO] [stderr] Compiling openssl v0.10.65 [INFO] [stderr] Compiling axum v0.7.5 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking headers-core v0.3.0 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Checking matchit v0.7.3 [INFO] [stderr] Compiling schemars v0.8.21 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking headers v0.4.0 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Compiling iana-time-zone v0.1.60 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking dyn-clone v1.0.17 [INFO] [stderr] Checking fraction v0.13.1 [INFO] [stderr] Compiling chrono v0.4.38 [INFO] [stderr] Checking iso8601 v0.6.1 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking fancy-regex v0.11.0 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Compiling serde_derive_internals v0.29.1 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Checking num-cmp v0.1.0 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking winnow v0.6.14 [INFO] [stderr] Checking bytecount v0.6.8 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking xattr v1.3.1 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking deunicode v1.6.0 [INFO] [stderr] Checking slug v0.1.5 [INFO] [stderr] Checking tar v0.4.41 [INFO] [stderr] Checking dotenvy v0.15.7 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Compiling orbit-server v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking symlink v0.1.0 [INFO] [stderr] Checking shlex v1.3.0 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling schemars_derive v0.8.21 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking async-fn-stream v0.2.2 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_path_to_error v0.1.16 [INFO] [stderr] Checking serde_spanned v0.6.6 [INFO] [stderr] Checking toml_datetime v0.6.6 [INFO] [stderr] Checking orbit-types v0.1.0 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Checking toml_edit v0.22.16 [INFO] [stderr] Checking jsonschema v0.17.1 [INFO] [stderr] Checking toml v0.8.15 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking hyper-util v0.1.6 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.5 [INFO] [stderr] Checking axum-extra v0.9.3 [INFO] [stderr] Checking aide v0.13.4 [INFO] [stderr] Checking axum-jsonschema v0.8.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:31:24 [INFO] [stdout] | [INFO] [stdout] 31 | server::start(config).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deploy.rs:94:17 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn stream(self) -> impl Stream> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | try_fn_stream(|stream| async move { [INFO] [stdout] | _______________________^ [INFO] [stdout] 95 | | stream.emit(Stage::Starting.into()).await; [INFO] [stdout] 96 | | [INFO] [stdout] 97 | | self.bootstrap_site()?; [INFO] [stdout] ... | [INFO] [stdout] 145 | | Ok(()) [INFO] [stdout] 146 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deploy.rs:244:3 [INFO] [stdout] | [INFO] [stdout] 232 | let mut streams = vec![]; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 244 | / futures_util::stream::iter(streams) [INFO] [stdout] 245 | | .flatten() [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deploy.rs:291:5 [INFO] [stdout] | [INFO] [stdout] 290 | .map(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 291 | / entry [INFO] [stdout] 292 | | .and_then(|e| { [INFO] [stdout] 293 | | let metadata = e.metadata()?; [INFO] [stdout] 294 | | Ok((e.path(), metadata.modified()?)) [INFO] [stdout] 295 | | }) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/misc.rs:40:8 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(stream: S) -> Self [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | Self(axum::response::sse::Sse::new(stream)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/misc.rs:122:16 [INFO] [stdout] | [INFO] [stdout] 119 | let process = cmd.stdout(Stdio::piped()).stderr(Stdio::piped()).spawn(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | try_fn_stream(|stream| async move { [INFO] [stdout] | ___________________^ [INFO] [stdout] 123 | | if let Some(pretty_cmd) = pretty_cmd { [INFO] [stdout] 124 | | stream.emit(Log::Info(pretty_cmd)).await; [INFO] [stdout] 125 | | } [INFO] [stdout] ... | [INFO] [stdout] 159 | | Ok(()) [INFO] [stdout] 160 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `orbit-server` (bin "orbit-server" test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:31:24 [INFO] [stdout] | [INFO] [stdout] 31 | server::start(config).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deploy.rs:94:17 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn stream(self) -> impl Stream> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | try_fn_stream(|stream| async move { [INFO] [stdout] | _______________________^ [INFO] [stdout] 95 | | stream.emit(Stage::Starting.into()).await; [INFO] [stdout] 96 | | [INFO] [stdout] 97 | | self.bootstrap_site()?; [INFO] [stdout] ... | [INFO] [stdout] 145 | | Ok(()) [INFO] [stdout] 146 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deploy.rs:244:3 [INFO] [stdout] | [INFO] [stdout] 232 | let mut streams = vec![]; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 244 | / futures_util::stream::iter(streams) [INFO] [stdout] 245 | | .flatten() [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deploy.rs:291:5 [INFO] [stdout] | [INFO] [stdout] 290 | .map(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 291 | / entry [INFO] [stdout] 292 | | .and_then(|e| { [INFO] [stdout] 293 | | let metadata = e.metadata()?; [INFO] [stdout] 294 | | Ok((e.path(), metadata.modified()?)) [INFO] [stdout] 295 | | }) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/misc.rs:40:8 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(stream: S) -> Self [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | Self(axum::response::sse::Sse::new(stream)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/misc.rs:122:16 [INFO] [stdout] | [INFO] [stdout] 119 | let process = cmd.stdout(Stdio::piped()).stderr(Stdio::piped()).spawn(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | try_fn_stream(|stream| async move { [INFO] [stdout] | ___________________^ [INFO] [stdout] 123 | | if let Some(pretty_cmd) = pretty_cmd { [INFO] [stdout] 124 | | stream.emit(Log::Info(pretty_cmd)).await; [INFO] [stdout] 125 | | } [INFO] [stdout] ... | [INFO] [stdout] 159 | | Ok(()) [INFO] [stdout] 160 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `orbit-server` (bin "orbit-server") due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "0e8a29f36acae8f5f3f598f35c56fe5e876ce32f985f4ab063db8fdbb845d7b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0e8a29f36acae8f5f3f598f35c56fe5e876ce32f985f4ab063db8fdbb845d7b7", kill_on_drop: false }` [INFO] [stdout] 0e8a29f36acae8f5f3f598f35c56fe5e876ce32f985f4ab063db8fdbb845d7b7