[INFO] fetching crate oracle_sql_tools 0.2.0... [INFO] checking oracle_sql_tools-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate oracle_sql_tools 0.2.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate oracle_sql_tools 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate oracle_sql_tools 0.2.0 [INFO] finished tweaking crates.io crate oracle_sql_tools 0.2.0 [INFO] tweaked toml for crates.io crate oracle_sql_tools 0.2.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate oracle_sql_tools 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bb8e1e75844db3044103d69c2233c9f8a0ea33b471016fada651c1a3c9279f5a [INFO] running `Command { std: "docker" "start" "-a" "bb8e1e75844db3044103d69c2233c9f8a0ea33b471016fada651c1a3c9279f5a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bb8e1e75844db3044103d69c2233c9f8a0ea33b471016fada651c1a3c9279f5a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bb8e1e75844db3044103d69c2233c9f8a0ea33b471016fada651c1a3c9279f5a", kill_on_drop: false }` [INFO] [stdout] bb8e1e75844db3044103d69c2233c9f8a0ea33b471016fada651c1a3c9279f5a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c6ee03142a19c7bb5705c057d368ba61a10810d8528f39d2c267cb9575b69d20 [INFO] running `Command { std: "docker" "start" "-a" "c6ee03142a19c7bb5705c057d368ba61a10810d8528f39d2c267cb9575b69d20", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.55 [INFO] [stderr] Compiling oracle v0.5.7 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking chrono v0.4.35 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling darling_core v0.13.4 [INFO] [stderr] Compiling darling_macro v0.13.4 [INFO] [stderr] Compiling darling v0.13.4 [INFO] [stderr] Compiling oracle_procmacro v0.1.2 [INFO] [stderr] Checking oracle_sql_tools v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/statements/insert_utils.rs:47:17 [INFO] [stdout] | [INFO] [stdout] 29 | let conn = Arc::clone(&conn); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let insert = Arc::clone(&insert_stmt); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | let datatype_indexes = Arc::clone(&datatype_indexes); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let progress_bar = Arc::clone(&progress_bar); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let arc_data: Arc>>; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | let mut batch: Batch<'_> = conn [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | / GridProperties { [INFO] [stdout] 48 | | data: arc_data, [INFO] [stdout] 49 | | num: (num.ceil() as usize - 1) * n, [INFO] [stdout] 50 | | datatype_indexes, [INFO] [stdout] 51 | | }.get_cell_props(&mut batch, progress_bar) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/statements/insert_utils.rs:180:11 [INFO] [stdout] | [INFO] [stdout] 177 | fn batch_set (cell_props: CellProperties, batch: &mut Batch<'_>, value: T) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | match batch.set(cell_props.x_ind + 1, &value) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/statements/insert.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn insert(self, table_name: &str) -> Result, OracleSqlToolsError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | stage_insert_data(self, table_name)?.split_batch_by_threads() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/statements/insert.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn insert_single_thread(self, table_name: &str) -> Result, OracleSqlToolsError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | stage_insert_data(self, table_name)?.single_thread_batch() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/statements/insert.rs:71:8 [INFO] [stdout] | [INFO] [stdout] 49 | fn stage_insert_data(mut grid_data: PreppedGridData, table_name: &str) -> Result { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | Ok(BatchPrep { [INFO] [stdout] | ________^ [INFO] [stdout] 72 | | data: data_body, [INFO] [stdout] 73 | | conn: grid_data.conn, [INFO] [stdout] 74 | | insert_stmt: data_header.insert_stmt(table_name), [INFO] [stdout] 75 | | data_indexes: grid_data.data_indexes, [INFO] [stdout] 76 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/statements/insert_utils.rs:47:17 [INFO] [stdout] | [INFO] [stdout] 29 | let conn = Arc::clone(&conn); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let insert = Arc::clone(&insert_stmt); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | let datatype_indexes = Arc::clone(&datatype_indexes); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let progress_bar = Arc::clone(&progress_bar); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let arc_data: Arc>>; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | let mut batch: Batch<'_> = conn [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | / GridProperties { [INFO] [stdout] 48 | | data: arc_data, [INFO] [stdout] 49 | | num: (num.ceil() as usize - 1) * n, [INFO] [stdout] 50 | | datatype_indexes, [INFO] [stdout] 51 | | }.get_cell_props(&mut batch, progress_bar) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/statements/insert_utils.rs:180:11 [INFO] [stdout] | [INFO] [stdout] 177 | fn batch_set (cell_props: CellProperties, batch: &mut Batch<'_>, value: T) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | match batch.set(cell_props.x_ind + 1, &value) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/statements/insert.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn insert(self, table_name: &str) -> Result, OracleSqlToolsError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | stage_insert_data(self, table_name)?.split_batch_by_threads() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/statements/insert.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn insert_single_thread(self, table_name: &str) -> Result, OracleSqlToolsError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | stage_insert_data(self, table_name)?.single_thread_batch() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `oracle_sql_tools` (lib) due to 6 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/statements/insert.rs:71:8 [INFO] [stdout] | [INFO] [stdout] 49 | fn stage_insert_data(mut grid_data: PreppedGridData, table_name: &str) -> Result { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | Ok(BatchPrep { [INFO] [stdout] | ________^ [INFO] [stdout] 72 | | data: data_body, [INFO] [stdout] 73 | | conn: grid_data.conn, [INFO] [stdout] 74 | | insert_stmt: data_header.insert_stmt(table_name), [INFO] [stdout] 75 | | data_indexes: grid_data.data_indexes, [INFO] [stdout] 76 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `oracle_sql_tools` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "c6ee03142a19c7bb5705c057d368ba61a10810d8528f39d2c267cb9575b69d20", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c6ee03142a19c7bb5705c057d368ba61a10810d8528f39d2c267cb9575b69d20", kill_on_drop: false }` [INFO] [stdout] c6ee03142a19c7bb5705c057d368ba61a10810d8528f39d2c267cb9575b69d20