[INFO] fetching crate ora-test 0.4.0... [INFO] checking ora-test-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ora-test 0.4.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate ora-test 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ora-test 0.4.0 [INFO] finished tweaking crates.io crate ora-test 0.4.0 [INFO] tweaked toml for crates.io crate ora-test 0.4.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 100 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 95d65fb773317cba80974780db36798a23c933f4befd3722281c61ad37e66b2f [INFO] running `Command { std: "docker" "start" "-a" "95d65fb773317cba80974780db36798a23c933f4befd3722281c61ad37e66b2f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "95d65fb773317cba80974780db36798a23c933f4befd3722281c61ad37e66b2f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "95d65fb773317cba80974780db36798a23c933f4befd3722281c61ad37e66b2f", kill_on_drop: false }` [INFO] [stdout] 95d65fb773317cba80974780db36798a23c933f4befd3722281c61ad37e66b2f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6cf55bd46f6283c3753db2fdc47e90cb31415d12e21236d6b263b4d5d8922cb8 [INFO] running `Command { std: "docker" "start" "-a" "6cf55bd46f6283c3753db2fdc47e90cb31415d12e21236d6b263b4d5d8922cb8", kill_on_drop: false }` [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Checking cron v0.12.1 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking ora-common v0.1.2 [INFO] [stderr] Checking ora-worker v0.4.2 [INFO] [stderr] Checking ora-client v0.3.0 [INFO] [stderr] Checking ora-api v0.4.0 [INFO] [stderr] Checking ora-test v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:115:14 [INFO] [stdout] | [INFO] [stdout] 72 | let worker = self.workers.get(&task.worker_selector)?.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | let cancellation = CancellationToken::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | let ctx = ora_worker::_private::new_context(task_id, cancellation.clone()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | [INFO] [stdout] 78 | let inner = Arc::new(Mutex::new(TestTaskInner { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | let task_inner = inner.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | Some(TaskHandle::new_raw(Arc::new(TestTaskOperations { inner }))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ora-test` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:115:14 [INFO] [stdout] | [INFO] [stdout] 72 | let worker = self.workers.get(&task.worker_selector)?.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | let cancellation = CancellationToken::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | let ctx = ora_worker::_private::new_context(task_id, cancellation.clone()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | [INFO] [stdout] 78 | let inner = Arc::new(Mutex::new(TestTaskInner { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | let task_inner = inner.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | Some(TaskHandle::new_raw(Arc::new(TestTaskOperations { inner }))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:289:55 [INFO] [stdout] | [INFO] [stdout] 287 | ctx: TaskContext, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 288 | _task: TestTask, [INFO] [stdout] 289 | ) -> eyre::Result<::Output> { [INFO] [stdout] | _______________________________________________________^ [INFO] [stdout] 290 | | Ok(ctx.task_id()) [INFO] [stdout] 291 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:300:61 [INFO] [stdout] | [INFO] [stdout] 298 | ctx: TaskContext, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 299 | _task: CancelOnlyTask, [INFO] [stdout] 300 | ) -> eyre::Result<::Output> { [INFO] [stdout] | _____________________________________________________________^ [INFO] [stdout] 301 | | ctx.cancelled().await; [INFO] [stdout] 302 | | Ok(()) [INFO] [stdout] 303 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ora-test` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "6cf55bd46f6283c3753db2fdc47e90cb31415d12e21236d6b263b4d5d8922cb8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6cf55bd46f6283c3753db2fdc47e90cb31415d12e21236d6b263b4d5d8922cb8", kill_on_drop: false }` [INFO] [stdout] 6cf55bd46f6283c3753db2fdc47e90cb31415d12e21236d6b263b4d5d8922cb8