[INFO] fetching crate oq3_syntax 0.6.0... [INFO] checking oq3_syntax-0.6.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate oq3_syntax 0.6.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate oq3_syntax 0.6.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate oq3_syntax 0.6.0 [INFO] finished tweaking crates.io crate oq3_syntax 0.6.0 [INFO] tweaked toml for crates.io crate oq3_syntax 0.6.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate oq3_syntax 0.6.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5f9eb2e88a522f3e89b97472bab146f639645b09b8c557c65f4ec3e95b231618 [INFO] running `Command { std: "docker" "start" "-a" "5f9eb2e88a522f3e89b97472bab146f639645b09b8c557c65f4ec3e95b231618", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5f9eb2e88a522f3e89b97472bab146f639645b09b8c557c65f4ec3e95b231618", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5f9eb2e88a522f3e89b97472bab146f639645b09b8c557c65f4ec3e95b231618", kill_on_drop: false }` [INFO] [stdout] 5f9eb2e88a522f3e89b97472bab146f639645b09b8c557c65f4ec3e95b231618 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6facc6dfac341010f5e57a341218bea0430fb51217740f7f48c424d05993e739 [INFO] running `Command { std: "docker" "start" "-a" "6facc6dfac341010f5e57a341218bea0430fb51217740f7f48c424d05993e739", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Checking unicode-xid v0.2.4 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Checking unicode-properties v0.1.1 [INFO] [stderr] Compiling rustversion v1.0.15 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking ra_ap_limit v0.0.188 [INFO] [stderr] Checking jod-thread v0.1.2 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking countme v3.0.1 [INFO] [stderr] Compiling xshell-macros v0.2.6 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking oq3_lexer v0.6.0 [INFO] [stderr] Checking always-assert v0.1.3 [INFO] [stderr] Checking drop_bomb v0.1.5 [INFO] [stderr] Checking text-size v1.1.1 [INFO] [stderr] Checking dissimilar v1.0.8 [INFO] [stderr] Checking smol_str v0.2.1 [INFO] [stderr] Checking cov-mark v2.0.0-pre.1 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking triomphe v0.1.11 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking ungrammar v1.16.1 [INFO] [stderr] Checking oq3_parser v0.6.0 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Checking expect-test v1.5.0 [INFO] [stderr] Checking xshell v0.2.6 [INFO] [stderr] Checking clap_builder v4.4.18 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-channel v0.5.12 [INFO] [stderr] Checking quote v1.0.36 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking rowan v0.15.15 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking ra_ap_stdx v0.0.188 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking oq3_syntax v0.6.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:107:21 [INFO] [stdout] | [INFO] [stdout] 104 | fn new(green: GreenNode, errors: Vec) -> Parse { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | errors: Arc::new(errors), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:223:21 [INFO] [stdout] | [INFO] [stdout] 217 | let (green, mut errors) = parsing::parse_text(text); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | let root = SyntaxNode::new_root(green.clone()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 223 | errors: Arc::new(errors), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:241:21 [INFO] [stdout] | [INFO] [stdout] 233 | let (green_maybe, mut errors) = parsing::parse_text_check_lex(text); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | errors: Arc::new(errors), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing.rs:27:6 [INFO] [stdout] | [INFO] [stdout] 26 | let (node, errors, _eof) = build_tree(lexed, parser_output); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | (Some(node), errors) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ptr.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 74 | let syntax_node = self.raw.to_node(root); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | N::cast(syntax_node).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/token_text.rs:24:19 [INFO] [stdout] | [INFO] [stdout] 23 | pub(crate) fn owned(green: GreenToken) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | TokenText(Repr::Owned(green)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validation.rs:137:11 [INFO] [stdout] | [INFO] [stdout] 117 | fn validate_literal(literal: ast::Literal, acc: &mut Vec) { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | let token = literal.token(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | match literal.kind() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/edit.rs:119:22 [INFO] [stdout] | [INFO] [stdout] 118 | fn prev_tokens(token: SyntaxToken) -> impl Iterator { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | iter::successors(Some(token), |token| token.prev_token()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/expr_ext.rs:207:18 [INFO] [stdout] | [INFO] [stdout] 168 | self.syntax().children_with_tokens().filter_map(|it| it.into_token()).find_map(|c| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | Some((c, bin_op)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/expr_ext.rs:417:42 [INFO] [stdout] | [INFO] [stdout] 417 | .map_or(true, |it| it == *self.syntax()), [INFO] [stdout] | -- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/generated/nodes.rs:2799:21 [INFO] [stdout] | [INFO] [stdout] 2797 | pub fn new(node: T) -> AnyHasArgList { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2798 | AnyHasArgList { [INFO] [stdout] 2799 | syntax: node.syntax().clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/generated/nodes.rs:2808:49 [INFO] [stdout] | [INFO] [stdout] 2807 | fn cast(syntax: SyntaxNode) -> Option { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2808 | Self::can_cast(syntax.kind()).then_some(AnyHasArgList { syntax }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/generated/nodes.rs:2818:21 [INFO] [stdout] | [INFO] [stdout] 2816 | pub fn new(node: T) -> AnyHasName { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2817 | AnyHasName { [INFO] [stdout] 2818 | syntax: node.syntax().clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/generated/nodes.rs:2844:49 [INFO] [stdout] | [INFO] [stdout] 2843 | fn cast(syntax: SyntaxNode) -> Option { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2844 | Self::can_cast(syntax.kind()).then_some(AnyHasName { syntax }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/make.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 115 | let sf = SourceFile::parse(text).ok().unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | / sf.syntax() [INFO] [stdout] 117 | | .clone_for_update() [INFO] [stdout] 118 | | .first_child_or_token() [INFO] [stdout] 119 | | .unwrap() [INFO] [stdout] 120 | | .into_token() [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/make.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 126 | let sf = SourceFile::parse(text).ok().unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | / sf.syntax() [INFO] [stdout] 128 | | .first_child_or_token() [INFO] [stdout] 129 | | .unwrap() [INFO] [stdout] 130 | | .into_token() [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/make.rs:137:9 [INFO] [stdout] | [INFO] [stdout] 136 | let lit: ast::Literal = super::ast_from_text(&format!("fn f() {{ let _ = {text}; }}")); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | / lit.syntax() [INFO] [stdout] 138 | | .first_child_or_token() [INFO] [stdout] 139 | | .unwrap() [INFO] [stdout] 140 | | .into_token() [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 17 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `oq3_syntax` (lib) due to 18 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "6facc6dfac341010f5e57a341218bea0430fb51217740f7f48c424d05993e739", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6facc6dfac341010f5e57a341218bea0430fb51217740f7f48c424d05993e739", kill_on_drop: false }` [INFO] [stdout] 6facc6dfac341010f5e57a341218bea0430fb51217740f7f48c424d05993e739