[INFO] fetching crate ophelia-bls-amcl 0.3.1... [INFO] checking ophelia-bls-amcl-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ophelia-bls-amcl 0.3.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate ophelia-bls-amcl 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ophelia-bls-amcl 0.3.1 [INFO] finished tweaking crates.io crate ophelia-bls-amcl 0.3.1 [INFO] tweaked toml for crates.io crate ophelia-bls-amcl 0.3.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 79 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding amcl_wrapper v0.3.5 (latest: v0.4.0) [INFO] [stderr] Adding block-buffer v0.7.3 (latest: v0.10.4) [INFO] [stderr] Adding block-padding v0.1.5 (latest: v0.3.3) [INFO] [stderr] Adding digest v0.8.1 (latest: v0.10.7) [INFO] [stderr] Adding env_logger v0.8.4 (latest: v0.11.5) [INFO] [stderr] Adding generic-array v0.12.4 (latest: v1.1.0) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding opaque-debug v0.2.3 (latest: v0.3.1) [INFO] [stderr] Adding rand v0.7.3 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (latest: v0.3.2) [INFO] [stderr] Adding sha3 v0.8.2 (latest: v0.10.8) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] be9ad64244159fff6039785e12f43894dce96c22d4da50639b02e21bf407a451 [INFO] running `Command { std: "docker" "start" "-a" "be9ad64244159fff6039785e12f43894dce96c22d4da50639b02e21bf407a451", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "be9ad64244159fff6039785e12f43894dce96c22d4da50639b02e21bf407a451", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "be9ad64244159fff6039785e12f43894dce96c22d4da50639b02e21bf407a451", kill_on_drop: false }` [INFO] [stdout] be9ad64244159fff6039785e12f43894dce96c22d4da50639b02e21bf407a451 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6229e7ce0be931ac4dff2974015ed7dd876763de5d3397d4c7d4fa6e840673e0 [INFO] running `Command { std: "docker" "start" "-a" "6229e7ce0be931ac4dff2974015ed7dd876763de5d3397d4c7d4fa6e840673e0", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking byte-tools v0.3.1 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Compiling unicode-xid v0.2.5 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking keccak v0.1.5 [INFO] [stderr] Checking block-padding v0.1.5 [INFO] [stderr] Checking opaque-debug v0.2.3 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking subtle-encoding v0.5.1 [INFO] [stderr] Checking miracl_amcl v3.2.5 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking generic-array v0.12.4 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking block-buffer v0.7.3 [INFO] [stderr] Checking digest v0.8.1 [INFO] [stderr] Checking sha3 v0.8.2 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ophelia-hasher v0.2.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking env_logger v0.8.4 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking quickcheck v1.0.3 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Compiling ophelia-derive v0.3.0 [INFO] [stderr] Compiling quickcheck_macros v1.0.0 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking ophelia v0.3.4 [INFO] [stderr] Checking amcl_wrapper v0.3.5 [INFO] [stderr] Checking secret_sharing v0.2.0 [INFO] [stderr] Checking bls_amcl_hotfix v0.7.2 [INFO] [stderr] Checking ophelia-bls-amcl v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 42 | let key = SigKey::from_bytes(bytes).map_err(|_| Deserialize)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | Ok(BlsPrivateKey(key)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:82:22 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn aggregate(keys: Vec) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | BlsPublicKey(AggregatedVerKey::from_verkeys(keys)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 92 | let key = VerKey::from_bytes(bytes).map_err(|_| Deserialize)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | Ok(BlsPublicKey(key)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:129:22 [INFO] [stdout] | [INFO] [stdout] 123 | pub fn combine(sigs_pubkeys: Vec<(BlsSignature, BlsPublicKey)>) -> Self { [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | BlsSignature(MultiSignature::from_sigs(sigs)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:140:12 [INFO] [stdout] | [INFO] [stdout] 139 | let sig = simple::Signature::from_bytes(bytes).map_err(|_| Deserialize)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | Ok(BlsSignature(sig)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ophelia-bls-amcl` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 42 | let key = SigKey::from_bytes(bytes).map_err(|_| Deserialize)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | Ok(BlsPrivateKey(key)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:82:22 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn aggregate(keys: Vec) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | BlsPublicKey(AggregatedVerKey::from_verkeys(keys)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 92 | let key = VerKey::from_bytes(bytes).map_err(|_| Deserialize)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | Ok(BlsPublicKey(key)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:129:22 [INFO] [stdout] | [INFO] [stdout] 123 | pub fn combine(sigs_pubkeys: Vec<(BlsSignature, BlsPublicKey)>) -> Self { [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | BlsSignature(MultiSignature::from_sigs(sigs)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:140:12 [INFO] [stdout] | [INFO] [stdout] 139 | let sig = simple::Signature::from_bytes(bytes).map_err(|_| Deserialize)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | Ok(BlsSignature(sig)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:202:15 [INFO] [stdout] | [INFO] [stdout] 201 | fn prop_private_key_bytes_serialization(priv_key: BlsPrivateKey) -> bool { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | match BlsPrivateKey::try_from(priv_key.to_bytes().as_ref()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ophelia-bls-amcl` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "6229e7ce0be931ac4dff2974015ed7dd876763de5d3397d4c7d4fa6e840673e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6229e7ce0be931ac4dff2974015ed7dd876763de5d3397d4c7d4fa6e840673e0", kill_on_drop: false }` [INFO] [stdout] 6229e7ce0be931ac4dff2974015ed7dd876763de5d3397d4c7d4fa6e840673e0