[INFO] fetching crate opentelemetry-zpages 0.9.0... [INFO] checking opentelemetry-zpages-0.9.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate opentelemetry-zpages 0.9.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate opentelemetry-zpages 0.9.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate opentelemetry-zpages 0.9.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate opentelemetry-zpages 0.9.0 [INFO] tweaked toml for crates.io crate opentelemetry-zpages 0.9.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate opentelemetry-zpages 0.9.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 02e3c6c3e2db4b52c2a6c1b7657f731019a07529ff0a49ea1628c66e36d0f6a6 [INFO] running `Command { std: "docker" "start" "-a" "02e3c6c3e2db4b52c2a6c1b7657f731019a07529ff0a49ea1628c66e36d0f6a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "02e3c6c3e2db4b52c2a6c1b7657f731019a07529ff0a49ea1628c66e36d0f6a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "02e3c6c3e2db4b52c2a6c1b7657f731019a07529ff0a49ea1628c66e36d0f6a6", kill_on_drop: false }` [INFO] [stdout] 02e3c6c3e2db4b52c2a6c1b7657f731019a07529ff0a49ea1628c66e36d0f6a6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2e6fc2afea0a7f565bfe3dae03d87a19f173f44b3b963a90ed4a360a8a284deb [INFO] running `Command { std: "docker" "start" "-a" "2e6fc2afea0a7f565bfe3dae03d87a19f173f44b3b963a90ed4a360a8a284deb", kill_on_drop: false }` [INFO] [stderr] Compiling futures-core v0.3.29 [INFO] [stderr] Compiling libc v0.2.150 [INFO] [stderr] Checking futures-sink v0.3.29 [INFO] [stderr] Compiling futures-task v0.3.29 [INFO] [stderr] Compiling futures-util v0.3.29 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking futures-io v0.3.29 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Compiling rustix v0.38.25 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking linux-raw-sys v0.4.11 [INFO] [stderr] Compiling syn v2.0.68 [INFO] [stderr] Checking concurrent-queue v2.3.0 [INFO] [stderr] Compiling futures-channel v0.3.29 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking value-bag v1.4.2 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Checking try-lock v0.2.4 [INFO] [stderr] Compiling rustix v0.37.27 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking event-listener v4.0.0 [INFO] [stderr] Compiling async-trait v0.1.74 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking async-task v4.5.0 [INFO] [stderr] Checking futures-lite v2.0.1 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking waker-fn v1.1.1 [INFO] [stderr] Checking async-lock v2.8.0 [INFO] [stderr] Checking event-listener-strategy v0.4.0 [INFO] [stderr] Checking piper v0.2.1 [INFO] [stderr] Compiling axum-core v0.4.3 [INFO] [stderr] Checking indexmap v2.1.0 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Compiling thiserror v1.0.50 [INFO] [stderr] Checking async-lock v3.1.2 [INFO] [stderr] Checking async-channel v2.1.1 [INFO] [stderr] Compiling either v1.9.0 [INFO] [stderr] Checking event-listener v3.1.0 [INFO] [stderr] Compiling axum v0.7.5 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking http v0.2.11 [INFO] [stderr] Compiling itertools v0.12.1 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.9 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking async-executor v1.8.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling futures-macro v0.3.29 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling pin-project-internal v1.1.3 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Compiling prost-derive v0.13.1 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking pin-project v1.1.3 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking opentelemetry v0.24.0 [INFO] [stderr] Checking polling v3.3.1 [INFO] [stderr] Checking blocking v1.5.1 [INFO] [stderr] Checking async-io v2.2.1 [INFO] [stderr] Checking prost v0.13.1 [INFO] [stderr] Checking async-signal v0.2.5 [INFO] [stderr] Checking async-global-executor v2.4.0 [INFO] [stderr] Checking async-process v1.8.1 [INFO] [stderr] Checking async-std v1.12.0 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures-executor v0.3.29 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking tokio-stream v0.1.14 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking serde_json v1.0.117 [INFO] [stderr] Checking opentelemetry_sdk v0.24.0 [INFO] [stderr] Checking hyper v0.14.27 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking hyper-util v0.1.5 [INFO] [stderr] Checking hyper-timeout v0.5.1 [INFO] [stderr] Checking tonic v0.12.0 [INFO] [stderr] Checking opentelemetry-proto v0.7.0 [INFO] [stderr] Checking opentelemetry-zpages v0.9.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trace/mod.rs:52:22 [INFO] [stdout] | [INFO] [stdout] 44 | runtime: R, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | ) -> (span_processor::ZPagesSpanProcessor, TracezQuerier) { [INFO] [stdout] 46 | let (tx, rx) = async_channel::unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let span_processor = span_processor::ZPagesSpanProcessor::new(tx.clone()); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let mut aggregator = aggregator::SpanAggregator::new(rx, sample_size); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | (span_processor, TracezQuerier(Arc::new(tx))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trace/mod.rs:52:22 [INFO] [stdout] | [INFO] [stdout] 44 | runtime: R, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | ) -> (span_processor::ZPagesSpanProcessor, TracezQuerier) { [INFO] [stdout] 46 | let (tx, rx) = async_channel::unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let span_processor = span_processor::ZPagesSpanProcessor::new(tx.clone()); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let mut aggregator = aggregator::SpanAggregator::new(rx, sample_size); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | (span_processor, TracezQuerier(Arc::new(tx))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trace/aggregator.rs:42:24 [INFO] [stdout] | [INFO] [stdout] 39 | pub(crate) fn new(receiver: Receiver, sample_size: usize) -> SpanAggregator { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | summaries: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trace/aggregator.rs:135:62 [INFO] [stdout] | [INFO] [stdout] 135 | .map(|queue| TracezResponse::Latency(queue.clone().into())) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trace/aggregator.rs:143:54 [INFO] [stdout] | [INFO] [stdout] 143 | .map(|summary| TracezResponse::Error(summary.error.clone().into())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trace/aggregator.rs:150:56 [INFO] [stdout] | [INFO] [stdout] 150 | .map(|summary| TracezResponse::Running(summary.running.clone().into())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trace/aggregator.rs:189:9 [INFO] [stdout] | [INFO] [stdout] 188 | fn from(span_queue: SpanQueue) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | span_queue.spans().into_iter().map(Into::into).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trace/span_queue.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 99 | pub(crate) fn spans(self) -> Vec { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | self.queue.into_iter().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trace/aggregator.rs:42:24 [INFO] [stdout] | [INFO] [stdout] 39 | pub(crate) fn new(receiver: Receiver, sample_size: usize) -> SpanAggregator { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | summaries: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trace/aggregator.rs:135:62 [INFO] [stdout] | [INFO] [stdout] 135 | .map(|queue| TracezResponse::Latency(queue.clone().into())) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trace/aggregator.rs:143:54 [INFO] [stdout] | [INFO] [stdout] 143 | .map(|summary| TracezResponse::Error(summary.error.clone().into())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trace/aggregator.rs:150:56 [INFO] [stdout] | [INFO] [stdout] 150 | .map(|summary| TracezResponse::Running(summary.running.clone().into())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trace/aggregator.rs:189:9 [INFO] [stdout] | [INFO] [stdout] 188 | fn from(span_queue: SpanQueue) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | span_queue.spans().into_iter().map(Into::into).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trace/span_queue.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 99 | pub(crate) fn spans(self) -> Vec { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | self.queue.into_iter().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `opentelemetry-zpages` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `opentelemetry-zpages` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "2e6fc2afea0a7f565bfe3dae03d87a19f173f44b3b963a90ed4a360a8a284deb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2e6fc2afea0a7f565bfe3dae03d87a19f173f44b3b963a90ed4a360a8a284deb", kill_on_drop: false }` [INFO] [stdout] 2e6fc2afea0a7f565bfe3dae03d87a19f173f44b3b963a90ed4a360a8a284deb