[INFO] fetching crate opentalk-client-shared-impl 0.9.0... [INFO] checking opentalk-client-shared-impl-0.9.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate opentalk-client-shared-impl 0.9.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate opentalk-client-shared-impl 0.9.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate opentalk-client-shared-impl 0.9.0 [INFO] finished tweaking crates.io crate opentalk-client-shared-impl 0.9.0 [INFO] tweaked toml for crates.io crate opentalk-client-shared-impl 0.9.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 20 packages to latest compatible versions [INFO] [stderr] Adding http v0.2.12 (latest: v1.1.0) [INFO] [stderr] Adding opentalk-proc-macro-fields-helper v0.9.0 (latest: v0.14.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9b35b888464b90707f96b3e120cc4b4cb307b02c1d9c18172395151f473f8560 [INFO] running `Command { std: "docker" "start" "-a" "9b35b888464b90707f96b3e120cc4b4cb307b02c1d9c18172395151f473f8560", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9b35b888464b90707f96b3e120cc4b4cb307b02c1d9c18172395151f473f8560", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9b35b888464b90707f96b3e120cc4b4cb307b02c1d9c18172395151f473f8560", kill_on_drop: false }` [INFO] [stdout] 9b35b888464b90707f96b3e120cc4b4cb307b02c1d9c18172395151f473f8560 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7c11678e3738681f846015cf70c9e62732e51ca48608a431505d27375a5b6701 [INFO] running `Command { std: "docker" "start" "-a" "7c11678e3738681f846015cf70c9e62732e51ca48608a431505d27375a5b6701", kill_on_drop: false }` [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking proc-macro2 v1.0.86 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking opentalk-proc-macro-fields-helper v0.9.0 [INFO] [stderr] Checking proc-macro-crate v3.2.0 [INFO] [stderr] Checking opentalk-client-shared-impl v0.9.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query_field.rs:69:8 [INFO] [stdout] | [INFO] [stdout] 35 | fields: Iter, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | ) -> Result, syn::Error> { [INFO] [stdout] 37 | let query_fields = fields [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | Ok(query_fields.into_iter().next()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request.rs:38:11 [INFO] [stdout] | [INFO] [stdout] 35 | pub(crate) fn request(input: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let ast = syn::parse_macro_input!(input as syn::DeriveInput); [INFO] [stdout] | --- -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | [INFO] [stdout] 38 | match try_to_request(ast) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request.rs:207:8 [INFO] [stdout] | [INFO] [stdout] 52 | / RequestParameters { [INFO] [stdout] 53 | | method, [INFO] [stdout] 54 | | response, [INFO] [stdout] 55 | | path, [INFO] [stdout] 56 | | }: RequestParameters, [INFO] [stdout] | |________________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let path = match &input.data { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | syn::Data::Struct(syn::DataStruct { fields, .. }) => { [INFO] [stdout] 63 | let fields = get_fields(fields); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | let opentalk_client_shared_crate = match found_crate { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | FoundCrate::Itself => quote!(crate), [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | FoundCrate::Name(name) => { [INFO] [stdout] 83 | let ident = Ident::new(&name, Span::call_site()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | quote!( #ident ) [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | let query = match &input.data { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | let body = match &input.data { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | let header = match &input.data { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | let (query_fn, query_type) = match query { [INFO] [stdout] | -------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | Some(AttributedField { name, ty }) => ( [INFO] [stdout] | ---- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | / quote! { [INFO] [stdout] 115 | | fn query(&self) -> Option<&Self::Query> { [INFO] [stdout] 116 | | Some(&self.#name) [INFO] [stdout] 117 | | } [INFO] [stdout] 118 | | }, [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | | quote! { #ty }, [INFO] [stdout] | | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 122 | / quote! { [INFO] [stdout] 123 | | fn query(&self) -> Option<&Self::Query> { [INFO] [stdout] 124 | | None [INFO] [stdout] 125 | | } [INFO] [stdout] 126 | | }, [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | | quote! { () }, [INFO] [stdout] | | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 131 | | let (body_fn, body_type) = match body { [INFO] [stdout] | | ------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | | Some(AttributedField { name, ty }) => ( [INFO] [stdout] | | ---- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | / quote! { [INFO] [stdout] 134 | | fn body(&self) -> Option<&Self::Body> { [INFO] [stdout] 135 | | Some(&self.#name) [INFO] [stdout] 136 | | } [INFO] [stdout] 137 | | }, [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | | quote! { #ty }, [INFO] [stdout] | | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 141 | / quote! { [INFO] [stdout] 142 | | fn body(&self) -> Option<&Self::Body> { [INFO] [stdout] 143 | | None [INFO] [stdout] 144 | | } [INFO] [stdout] 145 | | }, [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | | quote! { () }, [INFO] [stdout] | | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 150 | | let header_fn = match header { [INFO] [stdout] | | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | | Some(AttributedField { name, ty }) => { [INFO] [stdout] | | ---- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 168 | / quote! { [INFO] [stdout] 169 | | fn apply_headers(&self, headers: &mut http::HeaderMap) { [INFO] [stdout] 170 | | headers.extend(self.#name); [INFO] [stdout] ... | [INFO] [stdout] 175 | | } [INFO] [stdout] 176 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | } [INFO] [stdout] 178 | None => quote! { [INFO] [stdout] | _________________- [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________| [INFO] [stdout] 179 | | fn apply_headers(&self, headers: &mut http::HeaderMap) { [INFO] [stdout] 180 | | let _ = headers [INFO] [stdout] 181 | | .entry(http::header::CONTENT_TYPE) [INFO] [stdout] 182 | | .or_insert_with(|| http::HeaderValue::from_static("application/json")); [INFO] [stdout] 183 | | } [INFO] [stdout] 184 | | }, [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | let expanded = quote! { [INFO] [stdout] | _________--------___- [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | | impl #generics #opentalk_client_shared_crate::Request for #ident #generics { [INFO] [stdout] 189 | | type Response = #response; [INFO] [stdout] 190 | | type Query = #query_type; [INFO] [stdout] ... | [INFO] [stdout] 204 | | } [INFO] [stdout] 205 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | [INFO] [stdout] 207 | | Ok(TokenStream::from(expanded)) [INFO] [stdout] | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `opentalk-client-shared-impl` (lib) due to 4 previous errors [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "7c11678e3738681f846015cf70c9e62732e51ca48608a431505d27375a5b6701", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7c11678e3738681f846015cf70c9e62732e51ca48608a431505d27375a5b6701", kill_on_drop: false }` [INFO] [stdout] 7c11678e3738681f846015cf70c9e62732e51ca48608a431505d27375a5b6701