[INFO] fetching crate opening-hours 0.6.18... [INFO] checking opening-hours-0.6.18 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate opening-hours 0.6.18 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate opening-hours 0.6.18 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate opening-hours 0.6.18 [INFO] finished tweaking crates.io crate opening-hours 0.6.18 [INFO] tweaked toml for crates.io crate opening-hours 0.6.18 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate opening-hours 0.6.18 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0198f514f51c25af602bfc985038cd48547a1abfda7acdc6a6b6251f7626f1eb [INFO] running `Command { std: "docker" "start" "-a" "0198f514f51c25af602bfc985038cd48547a1abfda7acdc6a6b6251f7626f1eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0198f514f51c25af602bfc985038cd48547a1abfda7acdc6a6b6251f7626f1eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0198f514f51c25af602bfc985038cd48547a1abfda7acdc6a6b6251f7626f1eb", kill_on_drop: false }` [INFO] [stdout] 0198f514f51c25af602bfc985038cd48547a1abfda7acdc6a6b6251f7626f1eb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4c786f2acecf6cfb40ebb41620fd48b236276f596484b59e4871c380d45c81a7 [INFO] running `Command { std: "docker" "start" "-a" "4c786f2acecf6cfb40ebb41620fd48b236276f596484b59e4871c380d45c81a7", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling proc-macro2 v1.0.70 [INFO] [stderr] Compiling thiserror v1.0.50 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling memchr v2.6.4 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling iana-time-zone v0.1.58 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling serde v1.0.193 [INFO] [stderr] Compiling adler v1.0.2 [INFO] [stderr] Compiling once_cell v1.18.0 [INFO] [stderr] Compiling serde_json v1.0.108 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Compiling miniz_oxide v0.7.1 [INFO] [stderr] Compiling rustix v0.38.25 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking linux-raw-sys v0.4.11 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking ciborium-io v0.2.1 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking clap_builder v4.4.8 [INFO] [stderr] Checking ciborium-ll v0.2.1 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Compiling syn v2.0.39 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Compiling chrono v0.4.31 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking clap v4.4.8 [INFO] [stderr] Compiling compact-calendar v0.6.18 [INFO] [stderr] Compiling opening-hours v0.6.18 (/opt/rustwide/workdir) [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Compiling serde_derive v1.0.193 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking pest v2.7.5 [INFO] [stderr] Compiling pest_meta v2.7.5 [INFO] [stderr] Compiling pest_generator v2.7.5 [INFO] [stderr] Compiling pest_derive v2.7.5 [INFO] [stderr] Checking opening-hours-syntax v0.6.18 [INFO] [stderr] Checking ciborium v0.2.1 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/schedule.rs:59:20 [INFO] [stdout] | [INFO] [stdout] 54 | ranges: impl IntoIterator>, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | inner: ranges [INFO] [stdout] | ____________________^ [INFO] [stdout] 60 | | .into_iter() [INFO] [stdout] 61 | | .inspect(|range| assert!(range.start < range.end)) [INFO] [stdout] 62 | | .map(|range| TimeRange::new(range, kind, comments.clone())) [INFO] [stdout] | |___________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/range.rs:100:24 [INFO] [stdout] | [INFO] [stdout] 89 | ranges: impl IntoIterator>, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let mut ranges: Vec<_> = ranges.into_iter().collect(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let mut ranges = ranges.into_iter(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | let mut current_opt = ranges.next(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | [INFO] [stdout] 100 | std::iter::from_fn(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 101 | | if let Some(ref mut current) = current_opt { [INFO] [stdout] 102 | | #[allow(clippy::while_let_on_iterator)] [INFO] [stdout] 103 | | while let Some(item) = ranges.next() { [INFO] [stdout] ... | [INFO] [stdout] 117 | | } [INFO] [stdout] 118 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `opening-hours` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/schedule.rs:59:20 [INFO] [stdout] | [INFO] [stdout] 54 | ranges: impl IntoIterator>, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | inner: ranges [INFO] [stdout] | ____________________^ [INFO] [stdout] 60 | | .into_iter() [INFO] [stdout] 61 | | .inspect(|range| assert!(range.start < range.end)) [INFO] [stdout] 62 | | .map(|range| TimeRange::new(range, kind, comments.clone())) [INFO] [stdout] | |___________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/range.rs:100:24 [INFO] [stdout] | [INFO] [stdout] 89 | ranges: impl IntoIterator>, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let mut ranges: Vec<_> = ranges.into_iter().collect(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let mut ranges = ranges.into_iter(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | let mut current_opt = ranges.next(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | [INFO] [stdout] 100 | std::iter::from_fn(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 101 | | if let Some(ref mut current) = current_opt { [INFO] [stdout] 102 | | #[allow(clippy::while_let_on_iterator)] [INFO] [stdout] 103 | | while let Some(item) = ranges.next() { [INFO] [stdout] ... | [INFO] [stdout] 117 | | } [INFO] [stdout] 118 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `opening-hours` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "4c786f2acecf6cfb40ebb41620fd48b236276f596484b59e4871c380d45c81a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4c786f2acecf6cfb40ebb41620fd48b236276f596484b59e4871c380d45c81a7", kill_on_drop: false }` [INFO] [stdout] 4c786f2acecf6cfb40ebb41620fd48b236276f596484b59e4871c380d45c81a7