[INFO] fetching crate onvif-rs 0.0.4... [INFO] checking onvif-rs-0.0.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate onvif-rs 0.0.4 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate onvif-rs 0.0.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate onvif-rs 0.0.4 [INFO] finished tweaking crates.io crate onvif-rs 0.0.4 [INFO] tweaked toml for crates.io crate onvif-rs 0.0.4 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 36 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding ansi_term v0.11.0 (latest: v0.12.1) [INFO] [stderr] Adding derive_builder v0.5.1 (latest: v0.20.1) [INFO] [stderr] Adding derive_builder_core v0.2.0 (latest: v0.20.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding pretty_assertions v0.5.1 (latest: v1.4.0) [INFO] [stderr] Adding quick-xml v0.12.4 (latest: v0.36.1) [INFO] [stderr] Adding quote v0.3.15 (latest: v1.0.37) [INFO] [stderr] Adding syn v0.11.11 (latest: v2.0.77) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] [stderr] Adding unicode-xid v0.0.4 (latest: v0.2.5) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0a4ef5756c3ed5b3670252916d570c5552a5ff33a979c05a8eb0b9cba856c14b [INFO] running `Command { std: "docker" "start" "-a" "0a4ef5756c3ed5b3670252916d570c5552a5ff33a979c05a8eb0b9cba856c14b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0a4ef5756c3ed5b3670252916d570c5552a5ff33a979c05a8eb0b9cba856c14b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0a4ef5756c3ed5b3670252916d570c5552a5ff33a979c05a8eb0b9cba856c14b", kill_on_drop: false }` [INFO] [stdout] 0a4ef5756c3ed5b3670252916d570c5552a5ff33a979c05a8eb0b9cba856c14b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9a7f4c9d94aa2eb8a522a000cc121464072fbabcd596ffa1f3abc5f0be7cdc3f [INFO] running `Command { std: "docker" "start" "-a" "9a7f4c9d94aa2eb8a522a000cc121464072fbabcd596ffa1f3abc5f0be7cdc3f", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Compiling derive_builder v0.5.1 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking pretty_assertions v0.5.1 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Compiling derive_builder_core v0.2.0 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking quick-xml v0.12.4 [INFO] [stderr] Checking onvif-rs v0.0.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `password` is never read [INFO] [stdout] --> src/device.rs:6:3 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct OnvifDevice { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 6 | password: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/discovery.rs:218:6 [INFO] [stdout] | [INFO] [stdout] 174 | let socket = UdpSocket::bind(&all_interfaces).expect("Could not bind to udp socket"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | let read_socket = socket.try_clone().unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | let (thread_stop_tx, thread_stop_rx) = mpsc::channel(); [INFO] [stdout] | -------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | let (devices_tx, devices_rx) = mpsc::channel(); [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | let _read_thread_handle = thread::spawn(move || { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | let _broadcast_thread = thread::spawn(move || { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | let mut found_devices = HashSet::new(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | Ok(found_devices.into_iter().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/discovery.rs:167:30 [INFO] [stdout] | [INFO] [stdout] 167 | let s: &str = soap_tmpl.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `onvif-rs` (lib) due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `password` is never read [INFO] [stdout] --> src/device.rs:6:3 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct OnvifDevice { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 6 | password: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/discovery.rs:218:6 [INFO] [stdout] | [INFO] [stdout] 174 | let socket = UdpSocket::bind(&all_interfaces).expect("Could not bind to udp socket"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | let read_socket = socket.try_clone().unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | let (thread_stop_tx, thread_stop_rx) = mpsc::channel(); [INFO] [stdout] | -------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | let (devices_tx, devices_rx) = mpsc::channel(); [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | let _read_thread_handle = thread::spawn(move || { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | let _broadcast_thread = thread::spawn(move || { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | let mut found_devices = HashSet::new(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | Ok(found_devices.into_iter().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/discovery.rs:167:30 [INFO] [stdout] | [INFO] [stdout] 167 | let s: &str = soap_tmpl.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `onvif-rs` (lib test) due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9a7f4c9d94aa2eb8a522a000cc121464072fbabcd596ffa1f3abc5f0be7cdc3f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9a7f4c9d94aa2eb8a522a000cc121464072fbabcd596ffa1f3abc5f0be7cdc3f", kill_on_drop: false }` [INFO] [stdout] 9a7f4c9d94aa2eb8a522a000cc121464072fbabcd596ffa1f3abc5f0be7cdc3f