[INFO] fetching crate onto 0.1.0... [INFO] checking onto-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate onto 0.1.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate onto 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate onto 0.1.0 [INFO] finished tweaking crates.io crate onto 0.1.0 [INFO] tweaked toml for crates.io crate onto 0.1.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate onto 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3e46f41b351f6c027a03487706b7afb450102d3e398267365f0608123662d7f2 [INFO] running `Command { std: "docker" "start" "-a" "3e46f41b351f6c027a03487706b7afb450102d3e398267365f0608123662d7f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3e46f41b351f6c027a03487706b7afb450102d3e398267365f0608123662d7f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3e46f41b351f6c027a03487706b7afb450102d3e398267365f0608123662d7f2", kill_on_drop: false }` [INFO] [stdout] 3e46f41b351f6c027a03487706b7afb450102d3e398267365f0608123662d7f2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0c410873c99f2325cf22d29ec1603e3c7ce51649527996ae2d17b8103e278dec [INFO] running `Command { std: "docker" "start" "-a" "0c410873c99f2325cf22d29ec1603e3c7ce51649527996ae2d17b8103e278dec", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Compiling anyhow v1.0.81 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Compiling assert_cmd v2.0.14 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.55 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling jobserver v0.1.28 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Compiling libz-sys v1.1.16 [INFO] [stderr] Compiling openssl-sys v0.9.101 [INFO] [stderr] Compiling libssh2-sys v0.3.0 [INFO] [stderr] Compiling libgit2-sys v0.16.2+1.7.2 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Checking predicates v3.1.0 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking git2 v0.18.3 [INFO] [stderr] Checking onto v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/repro.rs:142:5 [INFO] [stdout] | [INFO] [stdout] 137 | let Ok(head) = repo.head() else { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | let obj = head.resolve()?.peel(ObjectType::Commit)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | / obj.into_commit() [INFO] [stdout] 143 | | .map(Some) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/repro.rs:188:8 [INFO] [stdout] | [INFO] [stdout] 168 | let mut index = repo.index()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 173 | let signature = repo.signature()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | let maybe_parent = find_last_commit(repo)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | let tree = repo.find_tree(oid)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | Ok(repo.find_commit(res)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/repro.rs:367:46 [INFO] [stdout] | [INFO] [stdout] 367 | let expected = maybe_expected.or_else(|| find_last_commit(&repo).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `onto` (test "repro") due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "0c410873c99f2325cf22d29ec1603e3c7ce51649527996ae2d17b8103e278dec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0c410873c99f2325cf22d29ec1603e3c7ce51649527996ae2d17b8103e278dec", kill_on_drop: false }` [INFO] [stdout] 0c410873c99f2325cf22d29ec1603e3c7ce51649527996ae2d17b8103e278dec