[INFO] fetching crate onetun 0.3.7... [INFO] checking onetun-0.3.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate onetun 0.3.7 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate onetun 0.3.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate onetun 0.3.7 [INFO] finished tweaking crates.io crate onetun 0.3.7 [INFO] tweaked toml for crates.io crate onetun 0.3.7 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate onetun 0.3.7 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1b4c27ee074e98cfcd7bd19df137dd5789122d7ece9904595e2480fa894ddebd [INFO] running `Command { std: "docker" "start" "-a" "1b4c27ee074e98cfcd7bd19df137dd5789122d7ece9904595e2480fa894ddebd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1b4c27ee074e98cfcd7bd19df137dd5789122d7ece9904595e2480fa894ddebd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1b4c27ee074e98cfcd7bd19df137dd5789122d7ece9904595e2480fa894ddebd", kill_on_drop: false }` [INFO] [stdout] 1b4c27ee074e98cfcd7bd19df137dd5789122d7ece9904595e2480fa894ddebd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fb8460b2ae696af27c7887584e43ae1e6f1606be74fa1dd6260fa24fd452e8be [INFO] running `Command { std: "docker" "start" "-a" "fb8460b2ae696af27c7887584e43ae1e6f1606be74fa1dd6260fa24fd452e8be", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling proc-macro2 v1.0.70 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling semver v1.0.20 [INFO] [stderr] Compiling futures-core v0.3.29 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling rustix v0.38.28 [INFO] [stderr] Compiling futures-channel v0.3.29 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling futures-task v0.3.29 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking futures-sink v0.3.29 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling futures-util v0.3.29 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Compiling heapless v0.7.17 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.41 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Checking futures-io v0.3.29 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking hash32 v0.2.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling priority-queue v1.3.2 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Compiling smoltcp v0.10.0 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking termcolor v1.4.0 [INFO] [stderr] Compiling async-trait v0.1.74 [INFO] [stderr] Checking ip_network v0.4.1 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking ip_network_table-deps-treebitmap v0.5.0 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking clap_builder v4.4.11 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking ip_network_table v0.2.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking managed v0.8.0 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking clap v4.4.11 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Compiling futures-macro v0.3.29 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling async-recursion v1.0.5 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Checking tokio v1.35.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking boringtun v0.4.0 [INFO] [stderr] Checking futures-executor v0.3.29 [INFO] [stderr] Checking futures v0.3.29 [INFO] [stderr] Checking onetun v0.3.7 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:39:65 [INFO] [stdout] | [INFO] [stdout] 38 | let bus = bus.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | tokio::spawn(async move { pcap::capture(pcap_file, bus).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:50:53 [INFO] [stdout] | [INFO] [stdout] 49 | let wg = wg.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | tokio::spawn(async move { wg.routine_task().await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:56:62 [INFO] [stdout] | [INFO] [stdout] 55 | let wg = wg.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | tokio::spawn(Box::pin(async move { wg.consume_task().await })); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:62:53 [INFO] [stdout] | [INFO] [stdout] 61 | let wg = wg.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | tokio::spawn(async move { wg.produce_task().await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:78:59 [INFO] [stdout] | [INFO] [stdout] 72 | let device = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | let iface = TcpVirtualInterface::new(port_forwards, bus, config.source_peer_ip); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | tokio::spawn(async move { iface.poll_loop(device).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:94:59 [INFO] [stdout] | [INFO] [stdout] 88 | let device = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let iface = UdpVirtualInterface::new(port_forwards, bus, config.source_peer_ip); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | tokio::spawn(async move { iface.poll_loop(device).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:114:21 [INFO] [stdout] | [INFO] [stdout] 112 | .for_each(move |(pf, wg, tcp_port_pool, udp_port_pool, bus)| { [INFO] [stdout] | -- ------------- ------------- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | tokio::spawn(async move { [INFO] [stdout] 114 | / tunnel::port_forward(pf, source_peer_ip, tcp_port_pool, udp_port_pool, wg, bus) [INFO] [stdout] 115 | | .await [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:265:12 [INFO] [stdout] | [INFO] [stdout] 38 | let matches = Command::new("onetun") [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | let mut port_forward_strings = HashSet::new(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | let port_forwards: anyhow::Result>> = port_forward_strings [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | let mut port_forward_strings = HashSet::new(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | let remote_port_forwards: anyhow::Result>> = [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 252 | return Err(anyhow::anyhow!( [INFO] [stdout] | ____________________________- [INFO] [stdout] 253 | | "Endpoint and bind addresses must be the same IP version" [INFO] [stdout] 254 | | )); [INFO] [stdout] | |_________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 265 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] 266 | | port_forwards, [INFO] [stdout] 267 | | remote_port_forwards, [INFO] [stdout] 268 | | private_key: Arc::new( [INFO] [stdout] ... | [INFO] [stdout] 288 | | warnings, [INFO] [stdout] 289 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:441:17 [INFO] [stdout] | [INFO] [stdout] 439 | let with_ip = separated_pair(map(ip_or_fqdn, Some), char(':'), port); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 440 | let without_ip = tuple((no_ip, port)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 441 | alt((with_ip, without_ip))(s) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/events.rs:155:15 [INFO] [stdout] | [INFO] [stdout] 153 | pub fn send(&self, event: Event) { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | trace!("#{} -> {}", self.id, event); [INFO] [stdout] 155 | match self.tx.send((self.id, event)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tunnel/udp.rs:155:20 [INFO] [stdout] | [INFO] [stdout] 148 | let mut inner = UdpPortPoolInner::default(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | inner: Arc::new(tokio::sync::RwLock::new(inner)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/virtual_iface/tcp.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 74 | let mut addresses = HashSet::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | / addresses [INFO] [stdout] 80 | | .into_iter() [INFO] [stdout] 81 | | .map(|addr| IpCidr::new(addr, addr_length(&addr))) [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/virtual_iface/tcp.rs:88:85 [INFO] [stdout] | [INFO] [stdout] 88 | async fn poll_loop(mut self, mut device: VirtualIpDevice) -> anyhow::Result<()> { [INFO] [stdout] | ____________________________----______-----------------------________________________^ [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | | // Create CIDR block for source peer IP + each port forward IP [INFO] [stdout] 90 | | let addresses = self.addresses(); [INFO] [stdout] 91 | | let config = Config::new(HardwareAddress::Ip); [INFO] [stdout] ... | [INFO] [stdout] 245 | | } [INFO] [stdout] 246 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/virtual_iface/tcp.rs:173:78 [INFO] [stdout] | [INFO] [stdout] 173 | ... match client_socket.recv(|buffer| (buffer.len(), Bytes::from(buffer.to_vec()))) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/virtual_iface/udp.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 86 | let mut addresses = HashSet::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | / addresses [INFO] [stdout] 92 | | .into_iter() [INFO] [stdout] 93 | | .map(|addr| IpCidr::new(addr, addr_length(&addr))) [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/virtual_iface/udp.rs:100:85 [INFO] [stdout] | [INFO] [stdout] 100 | async fn poll_loop(mut self, mut device: VirtualIpDevice) -> anyhow::Result<()> { [INFO] [stdout] | ____________________________----______-----------------------________________________^ [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | | // Create CIDR block for source peer IP + each port forward IP [INFO] [stdout] 102 | | let addresses = self.addresses(); [INFO] [stdout] 103 | | let config = Config::new(HardwareAddress::Ip); [INFO] [stdout] ... | [INFO] [stdout] 215 | | } [INFO] [stdout] 216 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `onetun` (lib) due to 17 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:39:65 [INFO] [stdout] | [INFO] [stdout] 38 | let bus = bus.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | tokio::spawn(async move { pcap::capture(pcap_file, bus).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:50:53 [INFO] [stdout] | [INFO] [stdout] 49 | let wg = wg.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | tokio::spawn(async move { wg.routine_task().await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:56:62 [INFO] [stdout] | [INFO] [stdout] 55 | let wg = wg.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | tokio::spawn(Box::pin(async move { wg.consume_task().await })); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:62:53 [INFO] [stdout] | [INFO] [stdout] 61 | let wg = wg.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | tokio::spawn(async move { wg.produce_task().await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:78:59 [INFO] [stdout] | [INFO] [stdout] 72 | let device = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | let iface = TcpVirtualInterface::new(port_forwards, bus, config.source_peer_ip); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | tokio::spawn(async move { iface.poll_loop(device).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:94:59 [INFO] [stdout] | [INFO] [stdout] 88 | let device = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let iface = UdpVirtualInterface::new(port_forwards, bus, config.source_peer_ip); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | tokio::spawn(async move { iface.poll_loop(device).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:114:21 [INFO] [stdout] | [INFO] [stdout] 112 | .for_each(move |(pf, wg, tcp_port_pool, udp_port_pool, bus)| { [INFO] [stdout] | -- ------------- ------------- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | tokio::spawn(async move { [INFO] [stdout] 114 | / tunnel::port_forward(pf, source_peer_ip, tcp_port_pool, udp_port_pool, wg, bus) [INFO] [stdout] 115 | | .await [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:265:12 [INFO] [stdout] | [INFO] [stdout] 38 | let matches = Command::new("onetun") [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | let mut port_forward_strings = HashSet::new(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | let port_forwards: anyhow::Result>> = port_forward_strings [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | let mut port_forward_strings = HashSet::new(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | let remote_port_forwards: anyhow::Result>> = [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 252 | return Err(anyhow::anyhow!( [INFO] [stdout] | ____________________________- [INFO] [stdout] 253 | | "Endpoint and bind addresses must be the same IP version" [INFO] [stdout] 254 | | )); [INFO] [stdout] | |_________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 265 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] 266 | | port_forwards, [INFO] [stdout] 267 | | remote_port_forwards, [INFO] [stdout] 268 | | private_key: Arc::new( [INFO] [stdout] ... | [INFO] [stdout] 288 | | warnings, [INFO] [stdout] 289 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:441:17 [INFO] [stdout] | [INFO] [stdout] 439 | let with_ip = separated_pair(map(ip_or_fqdn, Some), char(':'), port); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 440 | let without_ip = tuple((no_ip, port)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 441 | alt((with_ip, without_ip))(s) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/events.rs:155:15 [INFO] [stdout] | [INFO] [stdout] 153 | pub fn send(&self, event: Event) { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | trace!("#{} -> {}", self.id, event); [INFO] [stdout] 155 | match self.tx.send((self.id, event)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tunnel/udp.rs:155:20 [INFO] [stdout] | [INFO] [stdout] 148 | let mut inner = UdpPortPoolInner::default(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | inner: Arc::new(tokio::sync::RwLock::new(inner)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/virtual_iface/tcp.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 74 | let mut addresses = HashSet::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | / addresses [INFO] [stdout] 80 | | .into_iter() [INFO] [stdout] 81 | | .map(|addr| IpCidr::new(addr, addr_length(&addr))) [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/virtual_iface/tcp.rs:88:85 [INFO] [stdout] | [INFO] [stdout] 88 | async fn poll_loop(mut self, mut device: VirtualIpDevice) -> anyhow::Result<()> { [INFO] [stdout] | ____________________________----______-----------------------________________________^ [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | | // Create CIDR block for source peer IP + each port forward IP [INFO] [stdout] 90 | | let addresses = self.addresses(); [INFO] [stdout] 91 | | let config = Config::new(HardwareAddress::Ip); [INFO] [stdout] ... | [INFO] [stdout] 245 | | } [INFO] [stdout] 246 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/virtual_iface/tcp.rs:173:78 [INFO] [stdout] | [INFO] [stdout] 173 | ... match client_socket.recv(|buffer| (buffer.len(), Bytes::from(buffer.to_vec()))) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/virtual_iface/udp.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 86 | let mut addresses = HashSet::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | / addresses [INFO] [stdout] 92 | | .into_iter() [INFO] [stdout] 93 | | .map(|addr| IpCidr::new(addr, addr_length(&addr))) [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/virtual_iface/udp.rs:100:85 [INFO] [stdout] | [INFO] [stdout] 100 | async fn poll_loop(mut self, mut device: VirtualIpDevice) -> anyhow::Result<()> { [INFO] [stdout] | ____________________________----______-----------------------________________________^ [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | | // Create CIDR block for source peer IP + each port forward IP [INFO] [stdout] 102 | | let addresses = self.addresses(); [INFO] [stdout] 103 | | let config = Config::new(HardwareAddress::Ip); [INFO] [stdout] ... | [INFO] [stdout] 215 | | } [INFO] [stdout] 216 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `onetun` (lib test) due to 17 previous errors [INFO] running `Command { std: "docker" "inspect" "fb8460b2ae696af27c7887584e43ae1e6f1606be74fa1dd6260fa24fd452e8be", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fb8460b2ae696af27c7887584e43ae1e6f1606be74fa1dd6260fa24fd452e8be", kill_on_drop: false }` [INFO] [stdout] fb8460b2ae696af27c7887584e43ae1e6f1606be74fa1dd6260fa24fd452e8be