[INFO] fetching crate ommui_file_loading 0.7.1... [INFO] checking ommui_file_loading-0.7.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ommui_file_loading 0.7.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate ommui_file_loading 0.7.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ommui_file_loading 0.7.1 [INFO] finished tweaking crates.io crate ommui_file_loading 0.7.1 [INFO] tweaked toml for crates.io crate ommui_file_loading 0.7.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 53 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding proc-macro2 v0.4.30 (latest: v1.0.86) [INFO] [stderr] Adding quote v0.6.13 (latest: v1.0.37) [INFO] [stderr] Adding snafu v0.5.0 (latest: v0.8.4) [INFO] [stderr] Adding snafu-derive v0.5.0 (latest: v0.8.4) [INFO] [stderr] Adding syn v0.15.44 (latest: v2.0.77) [INFO] [stderr] Adding unicode-xid v0.1.0 (latest: v0.2.5) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9da0f566b4ac1bd77acdcdebe2a94511434e7347f3cc45ff1d0cb0d4d7d69cbb [INFO] running `Command { std: "docker" "start" "-a" "9da0f566b4ac1bd77acdcdebe2a94511434e7347f3cc45ff1d0cb0d4d7d69cbb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9da0f566b4ac1bd77acdcdebe2a94511434e7347f3cc45ff1d0cb0d4d7d69cbb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9da0f566b4ac1bd77acdcdebe2a94511434e7347f3cc45ff1d0cb0d4d7d69cbb", kill_on_drop: false }` [INFO] [stdout] 9da0f566b4ac1bd77acdcdebe2a94511434e7347f3cc45ff1d0cb0d4d7d69cbb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2adbda8a68bc4c6b9a5847bb0a069c0b26f3cc99f1ea6087ba1917d3ae794fdf [INFO] running `Command { std: "docker" "start" "-a" "2adbda8a68bc4c6b9a5847bb0a069c0b26f3cc99f1ea6087ba1917d3ae794fdf", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking rustix v0.38.35 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking backtrace v0.3.73 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling snafu-derive v0.5.0 [INFO] [stderr] Checking snafu v0.5.0 [INFO] [stderr] Checking ommui_file_loading v0.7.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:38:8 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn load_json>(path: P) -> Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | Ok(serde_json::from_reader(File::open(path).context(FileOpen { [INFO] [stdout] | ________^ [INFO] [stdout] 39 | | path: path.to_path_buf(), [INFO] [stdout] 40 | | })?) [INFO] [stdout] 41 | | .context(JsonLoading { [INFO] [stdout] 42 | | path: path.to_path_buf(), [INFO] [stdout] 43 | | })?) [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn load_json_buffered>(path: P) -> Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | Ok(serde_json::from_str(&s).context(JsonLoading { [INFO] [stdout] | ________^ [INFO] [stdout] 55 | | path: path.to_path_buf(), [INFO] [stdout] 56 | | })?) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:83:25 [INFO] [stdout] | [INFO] [stdout] 83 | .filter_map(|s| T::from_str(&s).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ommui_file_loading` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:38:8 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn load_json>(path: P) -> Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | Ok(serde_json::from_reader(File::open(path).context(FileOpen { [INFO] [stdout] | ________^ [INFO] [stdout] 39 | | path: path.to_path_buf(), [INFO] [stdout] 40 | | })?) [INFO] [stdout] 41 | | .context(JsonLoading { [INFO] [stdout] 42 | | path: path.to_path_buf(), [INFO] [stdout] 43 | | })?) [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn load_json_buffered>(path: P) -> Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | Ok(serde_json::from_str(&s).context(JsonLoading { [INFO] [stdout] | ________^ [INFO] [stdout] 55 | | path: path.to_path_buf(), [INFO] [stdout] 56 | | })?) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:83:25 [INFO] [stdout] | [INFO] [stdout] 83 | .filter_map(|s| T::from_str(&s).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&[T; N] as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to `<[T; N] as IntoIterator>::into_iter` in Rust 2021 [INFO] [stdout] --> src/lib.rs:234:14 [INFO] [stdout] | [INFO] [stdout] 234 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(array_into_iter)]` on by default [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 234 | .iter() [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or use `IntoIterator::into_iter(..)` instead of `.into_iter()` to explicitly iterate by value [INFO] [stdout] | [INFO] [stdout] 233 | let expected = IntoIterator::into_iter(["world", "neighbour"]) [INFO] [stdout] | ++++++++++++++++++++++++ ~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ommui_file_loading` (lib test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "2adbda8a68bc4c6b9a5847bb0a069c0b26f3cc99f1ea6087ba1917d3ae794fdf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2adbda8a68bc4c6b9a5847bb0a069c0b26f3cc99f1ea6087ba1917d3ae794fdf", kill_on_drop: false }` [INFO] [stdout] 2adbda8a68bc4c6b9a5847bb0a069c0b26f3cc99f1ea6087ba1917d3ae794fdf