[INFO] fetching crate oml 0.0.5... [INFO] checking oml-0.0.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate oml 0.0.5 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate oml 0.0.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate oml 0.0.5 [INFO] finished tweaking crates.io crate oml 0.0.5 [INFO] tweaked toml for crates.io crate oml 0.0.5 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 69 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3816131f98e64eb143c67473a2a81264f7ef2e5e5e5d929d860472a334af648d [INFO] running `Command { std: "docker" "start" "-a" "3816131f98e64eb143c67473a2a81264f7ef2e5e5e5d929d860472a334af648d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3816131f98e64eb143c67473a2a81264f7ef2e5e5e5d929d860472a334af648d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3816131f98e64eb143c67473a2a81264f7ef2e5e5e5d929d860472a334af648d", kill_on_drop: false }` [INFO] [stdout] 3816131f98e64eb143c67473a2a81264f7ef2e5e5e5d929d860472a334af648d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d7b42f1302bc1f6cffc5daec7e4d56cecfa845bc0a7571fcdbbc183b868d8172 [INFO] running `Command { std: "docker" "start" "-a" "d7b42f1302bc1f6cffc5daec7e4d56cecfa845bc0a7571fcdbbc183b868d8172", kill_on_drop: false }` [INFO] [stderr] Compiling utf8parse v0.2.2 [INFO] [stderr] Compiling anstyle-query v1.1.1 [INFO] [stderr] Compiling colorchoice v1.0.2 [INFO] [stderr] Compiling anstyle v1.0.8 [INFO] [stderr] Compiling is_terminal_polyfill v1.70.1 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling clap_lex v0.7.2 [INFO] [stderr] Compiling winnow v0.6.18 [INFO] [stderr] Compiling strsim v0.11.1 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling itoa v1.0.11 [INFO] [stderr] Compiling ryu v1.0.18 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling cbindgen v0.27.0 [INFO] [stderr] Checking ucd-trie v0.1.6 [INFO] [stderr] Compiling anstyle-parse v0.2.5 [INFO] [stderr] Compiling anstream v0.6.15 [INFO] [stderr] Compiling clap_builder v4.5.15 [INFO] [stderr] Compiling tempfile v3.12.0 [INFO] [stderr] Compiling clap v4.5.16 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling pest v2.7.11 [INFO] [stderr] Compiling pest_meta v2.7.11 [INFO] [stderr] Compiling pest_generator v2.7.11 [INFO] [stderr] Compiling pest_derive v2.7.11 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Compiling serde_spanned v0.6.7 [INFO] [stderr] Compiling toml_edit v0.22.20 [INFO] [stderr] Compiling toml v0.8.19 [INFO] [stderr] Compiling oml v0.0.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ast/oml_expr.rs:98:31 [INFO] [stdout] | [INFO] [stdout] 98 | for (key, mut val) in map2.into_iter() { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ast/oml_expr.rs:98:31 [INFO] [stdout] | [INFO] [stdout] 98 | for (key, mut val) in map2.into_iter() { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ast/oml_value.rs:322:19 [INFO] [stdout] | [INFO] [stdout] 322 | for (key, mut val) in val.into_iter() { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ast/oml_value.rs:322:19 [INFO] [stdout] | [INFO] [stdout] 322 | for (key, mut val) in val.into_iter() { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get` is never used [INFO] [stdout] --> src/ast/oml_value.rs:303:8 [INFO] [stdout] | [INFO] [stdout] 302 | pub trait OmlValueGetExt { [INFO] [stdout] | -------------- method in this trait [INFO] [stdout] 303 | fn get(&self, index: &str) -> Option<&OmlValue>; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/oml_expr.rs:75:22 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn make_if_anno(if_anno: OmlExpr, value: OmlExpr) -> Self { [INFO] [stdout] | ---------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | Self::IfAnno(OmlExprIfAnno { [INFO] [stdout] | ______________________^ [INFO] [stdout] 76 | | exprs: vec![(if_anno, value)], [INFO] [stdout] 77 | | default: None, [INFO] [stdout] 78 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/oml_expr.rs:385:22 [INFO] [stdout] | [INFO] [stdout] 375 | let mut exprs = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 382 | let expr1 = Box::new(exprs.remove(0)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 383 | let expr2 = Box::new(exprs.remove(0)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 384 | let expr3 = Box::new(exprs.remove(0)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 385 | OmlExpr::Op3((expr1, expr2, expr3)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/oml_expr.rs:417:31 [INFO] [stdout] | [INFO] [stdout] 404 | let mut exprs = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 417 | OmlExpr::FormatString((strs, exprs)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get` is never used [INFO] [stdout] --> src/ast/oml_value.rs:303:8 [INFO] [stdout] | [INFO] [stdout] 302 | pub trait OmlValueGetExt { [INFO] [stdout] | -------------- method in this trait [INFO] [stdout] 303 | fn get(&self, index: &str) -> Option<&OmlValue>; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/oml_expr.rs:75:22 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn make_if_anno(if_anno: OmlExpr, value: OmlExpr) -> Self { [INFO] [stdout] | ---------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | Self::IfAnno(OmlExprIfAnno { [INFO] [stdout] | ______________________^ [INFO] [stdout] 76 | | exprs: vec![(if_anno, value)], [INFO] [stdout] 77 | | default: None, [INFO] [stdout] 78 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/oml_expr.rs:385:22 [INFO] [stdout] | [INFO] [stdout] 375 | let mut exprs = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 382 | let expr1 = Box::new(exprs.remove(0)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 383 | let expr2 = Box::new(exprs.remove(0)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 384 | let expr3 = Box::new(exprs.remove(0)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 385 | OmlExpr::Op3((expr1, expr2, expr3)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/oml_expr.rs:417:31 [INFO] [stdout] | [INFO] [stdout] 404 | let mut exprs = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 417 | OmlExpr::FormatString((strs, exprs)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `oml` (lib) due to 4 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `oml` (lib test) due to 4 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d7b42f1302bc1f6cffc5daec7e4d56cecfa845bc0a7571fcdbbc183b868d8172", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d7b42f1302bc1f6cffc5daec7e4d56cecfa845bc0a7571fcdbbc183b868d8172", kill_on_drop: false }` [INFO] [stdout] d7b42f1302bc1f6cffc5daec7e4d56cecfa845bc0a7571fcdbbc183b868d8172