[INFO] fetching crate omicron-zone-package 0.11.0... [INFO] checking omicron-zone-package-0.11.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate omicron-zone-package 0.11.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate omicron-zone-package 0.11.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate omicron-zone-package 0.11.0 [INFO] finished tweaking crates.io crate omicron-zone-package 0.11.0 [INFO] tweaked toml for crates.io crate omicron-zone-package 0.11.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate omicron-zone-package 0.11.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] aee04d515b0a5f54a72f6e2e918db55ac4e7d48ee5d446335af2646a560bce79 [INFO] running `Command { std: "docker" "start" "-a" "aee04d515b0a5f54a72f6e2e918db55ac4e7d48ee5d446335af2646a560bce79", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "aee04d515b0a5f54a72f6e2e918db55ac4e7d48ee5d446335af2646a560bce79", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aee04d515b0a5f54a72f6e2e918db55ac4e7d48ee5d446335af2646a560bce79", kill_on_drop: false }` [INFO] [stdout] aee04d515b0a5f54a72f6e2e918db55ac4e7d48ee5d446335af2646a560bce79 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 716f60ba4c38211ddeeb8c70696f358794da459079fcb26e75b2a4cd240126f9 [INFO] running `Command { std: "docker" "start" "-a" "716f60ba4c38211ddeeb8c70696f358794da459079fcb26e75b2a4cd240126f9", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Compiling serde v1.0.196 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Compiling rustix v0.38.30 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Compiling rustls v0.21.10 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Compiling camino v1.1.6 [INFO] [stderr] Compiling anyhow v1.0.79 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking winnow v0.5.35 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Compiling slog v2.7.0 [INFO] [stderr] Compiling serde_json v1.0.112 [INFO] [stderr] Compiling async-trait v0.1.77 [INFO] [stderr] Compiling semver v1.0.21 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking indexmap v2.1.0 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Checking arrayref v0.3.7 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking iana-time-zone v0.1.59 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking memmap2 v0.7.1 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking webpki-roots v0.25.3 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking constant_time_eq v0.3.0 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking topological-sort v0.2.2 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking chrono v0.4.33 [INFO] [stderr] Checking rayon v1.8.1 [INFO] [stderr] Compiling ring v0.17.7 [INFO] [stderr] Compiling blake3 v1.5.0 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking tempfile v3.9.0 [INFO] [stderr] Checking xattr v1.3.1 [INFO] [stderr] Checking tar v0.4.40 [INFO] [stderr] Compiling serde_derive v1.0.196 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Checking tokio v1.35.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking thiserror v1.0.56 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking serde_spanned v0.6.5 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking toml_edit v0.19.15 [INFO] [stderr] Checking camino-tempfile v1.1.1 [INFO] [stderr] Checking h2 v0.3.24 [INFO] [stderr] Checking toml v0.7.8 [INFO] [stderr] Checking hyper v0.14.28 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking reqwest v0.11.23 [INFO] [stderr] Checking omicron-zone-package v0.11.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 38 | async fn append_file_async

(&mut self, path: P, file: &mut File) -> std::io::Result<()> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | / { [INFO] [stdout] 42 | | tokio::task::block_in_place(move || self.append_file(path.as_ref(), file)) [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 45 | async fn append_path_with_name_async(&mut self, path: P, name: N) -> std::io::Result<()> [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | / { [INFO] [stdout] 50 | | tokio::task::block_in_place(move || { [INFO] [stdout] 51 | | self.append_path_with_name(path.as_ref(), name.as_ref()) [INFO] [stdout] 52 | | }) [INFO] [stdout] 53 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 55 | async fn append_dir_all_async(&mut self, path: P, src_path: Q) -> std::io::Result<()> [INFO] [stdout] | ------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | / { [INFO] [stdout] 60 | | tokio::task::block_in_place(move || self.append_dir_all(path.as_ref(), src_path.as_ref())) [INFO] [stdout] 61 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn create_tarfile + std::fmt::Debug>(tarfile: P) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | / OpenOptions::new() [INFO] [stdout] 67 | | .write(true) [INFO] [stdout] 68 | | .read(true) [INFO] [stdout] 69 | | .truncate(true) [INFO] [stdout] 70 | | .create(true) [INFO] [stdout] 71 | | .open(tarfile.as_ref()) [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn open_tarfile + std::fmt::Debug>(tarfile: P) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | / OpenOptions::new() [INFO] [stdout] 78 | | .read(true) [INFO] [stdout] 79 | | .open(tarfile.as_ref()) [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 95 | pub fn into_inner(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | self.builder.into_inner().context("Finalizing archive") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `omicron-zone-package` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 38 | async fn append_file_async

(&mut self, path: P, file: &mut File) -> std::io::Result<()> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | / { [INFO] [stdout] 42 | | tokio::task::block_in_place(move || self.append_file(path.as_ref(), file)) [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 45 | async fn append_path_with_name_async(&mut self, path: P, name: N) -> std::io::Result<()> [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | / { [INFO] [stdout] 50 | | tokio::task::block_in_place(move || { [INFO] [stdout] 51 | | self.append_path_with_name(path.as_ref(), name.as_ref()) [INFO] [stdout] 52 | | }) [INFO] [stdout] 53 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 55 | async fn append_dir_all_async(&mut self, path: P, src_path: Q) -> std::io::Result<()> [INFO] [stdout] | ------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | / { [INFO] [stdout] 60 | | tokio::task::block_in_place(move || self.append_dir_all(path.as_ref(), src_path.as_ref())) [INFO] [stdout] 61 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn create_tarfile + std::fmt::Debug>(tarfile: P) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | / OpenOptions::new() [INFO] [stdout] 67 | | .write(true) [INFO] [stdout] 68 | | .read(true) [INFO] [stdout] 69 | | .truncate(true) [INFO] [stdout] 70 | | .create(true) [INFO] [stdout] 71 | | .open(tarfile.as_ref()) [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn open_tarfile + std::fmt::Debug>(tarfile: P) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | / OpenOptions::new() [INFO] [stdout] 78 | | .read(true) [INFO] [stdout] 79 | | .open(tarfile.as_ref()) [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 95 | pub fn into_inner(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | self.builder.into_inner().context("Finalizing archive") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `omicron-zone-package` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "716f60ba4c38211ddeeb8c70696f358794da459079fcb26e75b2a4cd240126f9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "716f60ba4c38211ddeeb8c70696f358794da459079fcb26e75b2a4cd240126f9", kill_on_drop: false }` [INFO] [stdout] 716f60ba4c38211ddeeb8c70696f358794da459079fcb26e75b2a4cd240126f9