[INFO] fetching crate omaha_client 0.2.1... [INFO] checking omaha_client-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate omaha_client 0.2.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate omaha_client 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate omaha_client 0.2.1 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate omaha_client 0.2.1 [INFO] tweaked toml for crates.io crate omaha_client 0.2.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate omaha_client 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 901827ae5eba7dbc3534971af908f07cad59276298e077e7670db41caf61aa71 [INFO] running `Command { std: "docker" "start" "-a" "901827ae5eba7dbc3534971af908f07cad59276298e077e7670db41caf61aa71", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "901827ae5eba7dbc3534971af908f07cad59276298e077e7670db41caf61aa71", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "901827ae5eba7dbc3534971af908f07cad59276298e077e7670db41caf61aa71", kill_on_drop: false }` [INFO] [stdout] 901827ae5eba7dbc3534971af908f07cad59276298e077e7670db41caf61aa71 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fc1d6c067a05788cb9e06f7e961a37afc83e54c66ad634c665b9363288542227 [INFO] running `Command { std: "docker" "start" "-a" "fc1d6c067a05788cb9e06f7e961a37afc83e54c66ad634c665b9363288542227", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking pem-rfc7468 v0.6.0 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking base16ct v0.1.1 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking futures-sink-preview v0.3.0-alpha.19 [INFO] [stderr] Checking futures-core-preview v0.3.0-alpha.19 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking der v0.6.1 [INFO] [stderr] Checking futures-io-preview v0.3.0-alpha.19 [INFO] [stderr] Compiling rustls v0.22.4 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking futures-channel-preview v0.3.0-alpha.19 [INFO] [stderr] Compiling anyhow v1.0.81 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking futures-util-preview v0.3.0-alpha.19 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling syn v2.0.53 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Checking hex v0.3.2 [INFO] [stderr] Checking rustls-native-certs v0.7.0 [INFO] [stderr] Checking assert_matches v1.5.0 [INFO] [stderr] Checking spki v0.6.0 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking pkcs8 v0.9.0 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking ff v0.12.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking group v0.12.1 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking parking_lot v0.12.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking chrono v0.4.35 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-bigint v0.4.9 [INFO] [stderr] Checking sec1 v0.3.0 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking signature v1.6.4 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking elliptic-curve v0.12.3 [INFO] [stderr] Checking rfc6979 v0.3.1 [INFO] [stderr] Checking ecdsa v0.14.8 [INFO] [stderr] Checking futures-executor-preview v0.3.0-alpha.19 [INFO] [stderr] Checking futures-preview v0.3.0-alpha.19 [INFO] [stderr] Checking futures-timer v0.3.0 [INFO] [stderr] Checking p256 v0.11.1 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling serde_repr v0.1.18 [INFO] [stderr] Checking rustls-webpki v0.102.4 [INFO] [stderr] Compiling typed-builder v0.10.0 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tokio-rustls v0.25.0 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Compiling argh_shared v0.1.12 [INFO] [stderr] Compiling argh_derive v0.1.12 [INFO] [stderr] Checking uuid v1.7.0 [INFO] [stderr] Checking argh v0.1.12 [INFO] [stderr] Checking hyper v0.14.28 [INFO] [stderr] Checking hyper-rustls v0.25.0 [INFO] [stderr] Checking omaha_client v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_generator.rs:41:15 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn generate<'a, I, R, C, F>(cb: C) -> Generator [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let (send, recv) = mpsc::channel(0); [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Generator { [INFO] [stdout] 41 | task: cb(Yield(send)).fuse(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_generator.rs:43:14 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn generate<'a, I, R, C, F>(cb: C) -> Generator [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let (send, recv) = mpsc::channel(0); [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | res: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_generator.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn yield_(&mut self, item: I) -> impl Future + '_ { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | // Ignore errors as Generator never drops the stream before the task. [INFO] [stdout] 57 | self.0.send(item).map(|_| ()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_generator.rs:120:27 [INFO] [stdout] | [INFO] [stdout] 119 | self.filter_map(|state| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | future::ready(match state { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 121 | | GeneratorState::Yielded(i) => Some(Ok(i)), [INFO] [stdout] 122 | | GeneratorState::Complete(Ok(())) => None, [INFO] [stdout] 123 | | GeneratorState::Complete(Err(e)) => Some(Err(e)), [INFO] [stdout] 124 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_generator.rs:135:55 [INFO] [stdout] | [INFO] [stdout] 135 | let s = self.filter_map(|state| future::ready(state.into_complete())); [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_generator.rs:151:47 [INFO] [stdout] | [INFO] [stdout] 151 | self.filter_map(|state| future::ready(state.into_yielded())) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cup_ecdsa.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 56 | fn from_pem<'de, D>(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | s.parse().map_err(de::Error::custom) [INFO] [stdout] | ^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http_request.rs:84:21 [INFO] [stdout] | [INFO] [stdout] 76 | fn from(error: hyper::Error) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | source: error.into(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http_request.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 111 | fn request(&mut self, _req: Request) -> BoxFuture<'_, Result>, Error>> { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | future::ok(Response::default()).boxed() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http_request/mock.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 29 | fn request(&mut self, req: Request) -> BoxFuture<'_, Result>, Error>> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | / future::ready(if let Some(resp) = self.responses.pop_front() { [INFO] [stdout] 33 | | resp [INFO] [stdout] 34 | | } else { [INFO] [stdout] 35 | | // No response to return, generate a 500 internal server error [INFO] [stdout] ... | [INFO] [stdout] 39 | | .unwrap()) [INFO] [stdout] 40 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http_request/mock.rs:48:24 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn new(res: Response>) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | Self { [INFO] [stdout] 48 | responses: vec![Ok(res)].into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http_request/mock.rs:49:15 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn new(res: Response>) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http_request/mock.rs:60:15 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn from_request_cell(request: Rc>>>) -> Self { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http_uri_ext.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 28 | fn extend_dir_with_path(self, path: &str) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | let mut base_parts = self.into_parts(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | Ok(Uri::from_parts(base_parts)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http_uri_ext.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 52 | fn append_query_parameter(self, key: &str, value: &str) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | let mut base_parts = self.into_parts(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | Ok(Uri::from_parts(base_parts)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/response.rs:141:34 [INFO] [stdout] | [INFO] [stdout] 139 | pub fn ok(urls: impl IntoIterator>) -> Self { [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | UpdateCheck { [INFO] [stdout] 141 | urls: Some(URLs::new(urls.into_iter().map(Into::into).collect())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request_builder.rs:265:12 [INFO] [stdout] | [INFO] [stdout] 265 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 266 | | Into::>>::into(intermediate)?, [INFO] [stdout] 267 | | request_metadata, [INFO] [stdout] 268 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/time/timers.rs:307:14 [INFO] [stdout] | [INFO] [stdout] 306 | let (send, recv) = mpsc::channel(0); [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 307 | (Self { chan: send }, recv) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/time/timers.rs:313:13 [INFO] [stdout] | [INFO] [stdout] 311 | let mut chan = self.chan.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 312 | [INFO] [stdout] 313 | / async move { [INFO] [stdout] 314 | | let (send, recv) = oneshot::channel(); [INFO] [stdout] 315 | | chan.send(BlockedTimer { [INFO] [stdout] 316 | | wait, [INFO] [stdout] ... | [INFO] [stdout] 322 | | recv.await.unwrap(); [INFO] [stdout] 323 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/time/time_source.rs:76:19 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn new(t: impl Into) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | MockTimeSource { [INFO] [stdout] 76 | time: Arc::new(RwLock::new(t.into())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 20 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `omaha_client` (lib) due to 21 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_generator.rs:41:15 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn generate<'a, I, R, C, F>(cb: C) -> Generator [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let (send, recv) = mpsc::channel(0); [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Generator { [INFO] [stdout] 41 | task: cb(Yield(send)).fuse(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_generator.rs:43:14 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn generate<'a, I, R, C, F>(cb: C) -> Generator [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let (send, recv) = mpsc::channel(0); [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | res: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_generator.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn yield_(&mut self, item: I) -> impl Future + '_ { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | // Ignore errors as Generator never drops the stream before the task. [INFO] [stdout] 57 | self.0.send(item).map(|_| ()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_generator.rs:120:27 [INFO] [stdout] | [INFO] [stdout] 119 | self.filter_map(|state| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | future::ready(match state { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 121 | | GeneratorState::Yielded(i) => Some(Ok(i)), [INFO] [stdout] 122 | | GeneratorState::Complete(Ok(())) => None, [INFO] [stdout] 123 | | GeneratorState::Complete(Err(e)) => Some(Err(e)), [INFO] [stdout] 124 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_generator.rs:135:55 [INFO] [stdout] | [INFO] [stdout] 135 | let s = self.filter_map(|state| future::ready(state.into_complete())); [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_generator.rs:151:47 [INFO] [stdout] | [INFO] [stdout] 151 | self.filter_map(|state| future::ready(state.into_yielded())) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/clock.rs:27:32 [INFO] [stdout] | [INFO] [stdout] 27 | MOCK_TIME.with(|time| *time.borrow()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cup_ecdsa.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 56 | fn from_pem<'de, D>(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | s.parse().map_err(de::Error::custom) [INFO] [stdout] | ^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cup_ecdsa.rs:786:12 [INFO] [stdout] | [INFO] [stdout] 763 | private_key: SigningKey, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 782 | let response: Response> = hyper::Response::builder() [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 786 | Ok((request_metadata, response)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http_request.rs:84:21 [INFO] [stdout] | [INFO] [stdout] 76 | fn from(error: hyper::Error) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | source: error.into(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http_request.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 111 | fn request(&mut self, _req: Request) -> BoxFuture<'_, Result>, Error>> { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | future::ok(Response::default()).boxed() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http_request/mock.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 29 | fn request(&mut self, req: Request) -> BoxFuture<'_, Result>, Error>> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | / future::ready(if let Some(resp) = self.responses.pop_front() { [INFO] [stdout] 33 | | resp [INFO] [stdout] 34 | | } else { [INFO] [stdout] 35 | | // No response to return, generate a 500 internal server error [INFO] [stdout] ... | [INFO] [stdout] 39 | | .unwrap()) [INFO] [stdout] 40 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http_request/mock.rs:48:24 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn new(res: Response>) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | Self { [INFO] [stdout] 48 | responses: vec![Ok(res)].into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http_request/mock.rs:49:15 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn new(res: Response>) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http_request/mock.rs:60:15 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn from_request_cell(request: Rc>>>) -> Self { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http_uri_ext.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 28 | fn extend_dir_with_path(self, path: &str) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | let mut base_parts = self.into_parts(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | Ok(Uri::from_parts(base_parts)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http_uri_ext.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 52 | fn append_query_parameter(self, key: &str, value: &str) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | let mut base_parts = self.into_parts(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | Ok(Uri::from_parts(base_parts)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http_uri_ext.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 82 | let mut parts = uri::Parts::default(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | parts.path_and_query = path_and_query.map(|p| p.parse().unwrap()); [INFO] [stdout] 84 | Uri::from_parts(parts).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http_uri_ext.rs:83:55 [INFO] [stdout] | [INFO] [stdout] 83 | parts.path_and_query = path_and_query.map(|p| p.parse().unwrap()); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/response.rs:141:34 [INFO] [stdout] | [INFO] [stdout] 139 | pub fn ok(urls: impl IntoIterator>) -> Self { [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | UpdateCheck { [INFO] [stdout] 141 | urls: Some(URLs::new(urls.into_iter().map(Into::into).collect())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request_builder.rs:265:12 [INFO] [stdout] | [INFO] [stdout] 265 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 266 | | Into::>>::into(intermediate)?, [INFO] [stdout] 267 | | request_metadata, [INFO] [stdout] 268 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_machine.rs:1554:18 [INFO] [stdout] | [INFO] [stdout] 1552 | async_generator::generate(move |mut co| async move { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1553 | self.perform_update_check(request_params, apps, &mut co) [INFO] [stdout] 1554 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_machine/builder.rs:379:13 [INFO] [stdout] | [INFO] [stdout] 376 | let mock_time = MockTimeSource::new_from_now(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 379 | StubPolicyEngine::new(mock_time), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_machine/builder.rs:384:13 [INFO] [stdout] | [INFO] [stdout] 376 | let mock_time = MockTimeSource::new_from_now(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 384 | Rc::new(Mutex::new(StubStorage)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_machine/builder.rs:386:13 [INFO] [stdout] | [INFO] [stdout] 376 | let mock_time = MockTimeSource::new_from_now(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 386 | Rc::new(Mutex::new(app_set)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_machine.rs:3999:13 [INFO] [stdout] | [INFO] [stdout] 3996 | let (send, recv) = oneshot::channel(); [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 3997 | let send_fut = self.on_install.send(send); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 3998 | [INFO] [stdout] 3999 | / async move { [INFO] [stdout] 4000 | | send_fut.await.unwrap(); [INFO] [stdout] 4001 | | ((), recv.await.unwrap()) [INFO] [stdout] 4002 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_machine.rs:4001:27 [INFO] [stdout] | [INFO] [stdout] 3996 | let (send, recv) = oneshot::channel(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 3997 | let send_fut = self.on_install.send(send); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 4001 | ((), recv.await.unwrap()) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_machine.rs:4014:25 [INFO] [stdout] | [INFO] [stdout] 4009 | let (send, recv) = oneshot::channel(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 4010 | let send_fut = on_reboot.send(send); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 4014 | recv.await.unwrap() [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_machine.rs:4394:24 [INFO] [stdout] | [INFO] [stdout] 4309 | let mut pool = LocalPool::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 4310 | let spawner = pool.spawner(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 4333 | let http = MockHttpRequest::new(HttpResponse::new(response)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 4334 | let mut mock_time = MockTimeSource::new_from_now(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 4335 | mock_time.truncate_submicrosecond_walltime(); [INFO] [stdout] 4336 | let storage = Rc::new(Mutex::new(MemStorage::new())); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 4366 | let (_ctl, state_machine) = pool.run_until( [INFO] [stdout] | ---- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 4394 | pool.run_until(async { [INFO] [stdout] | ________________________^ [INFO] [stdout] 4395 | | let storage = storage.lock().await; [INFO] [stdout] 4396 | | assert_eq!(storage.get_time(UPDATE_FINISH_TIME).await, None); [INFO] [stdout] 4397 | | assert_eq!(storage.get_string(TARGET_VERSION).await, None); [INFO] [stdout] 4398 | | assert!(storage.committed()); [INFO] [stdout] 4399 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_machine.rs:4435:49 [INFO] [stdout] | [INFO] [stdout] 4435 | .set_verification_error(|| Some(CupVerificationError::EtagHeaderMissing)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/time/timers.rs:307:14 [INFO] [stdout] | [INFO] [stdout] 306 | let (send, recv) = mpsc::channel(0); [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 307 | (Self { chan: send }, recv) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/time/timers.rs:313:13 [INFO] [stdout] | [INFO] [stdout] 311 | let mut chan = self.chan.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 312 | [INFO] [stdout] 313 | / async move { [INFO] [stdout] 314 | | let (send, recv) = oneshot::channel(); [INFO] [stdout] 315 | | chan.send(BlockedTimer { [INFO] [stdout] 316 | | wait, [INFO] [stdout] ... | [INFO] [stdout] 322 | | recv.await.unwrap(); [INFO] [stdout] 323 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/time/time_source.rs:76:19 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn new(t: impl Into) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | MockTimeSource { [INFO] [stdout] 76 | time: Arc::new(RwLock::new(t.into())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 33 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `omaha_client` (lib test) due to 34 previous errors [INFO] running `Command { std: "docker" "inspect" "fc1d6c067a05788cb9e06f7e961a37afc83e54c66ad634c665b9363288542227", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fc1d6c067a05788cb9e06f7e961a37afc83e54c66ad634c665b9363288542227", kill_on_drop: false }` [INFO] [stdout] fc1d6c067a05788cb9e06f7e961a37afc83e54c66ad634c665b9363288542227