[INFO] fetching crate olympia_cli 0.3.0... [INFO] checking olympia_cli-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate olympia_cli 0.3.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate olympia_cli 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate olympia_cli 0.3.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate olympia_cli 0.3.0 [INFO] tweaked toml for crates.io crate olympia_cli 0.3.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate olympia_cli 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a2eba33f0350f1372c93603c6079b764f9b0c6720f97720bfca9dc6c521ff495 [INFO] running `Command { std: "docker" "start" "-a" "a2eba33f0350f1372c93603c6079b764f9b0c6720f97720bfca9dc6c521ff495", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a2eba33f0350f1372c93603c6079b764f9b0c6720f97720bfca9dc6c521ff495", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a2eba33f0350f1372c93603c6079b764f9b0c6720f97720bfca9dc6c521ff495", kill_on_drop: false }` [INFO] [stdout] a2eba33f0350f1372c93603c6079b764f9b0c6720f97720bfca9dc6c521ff495 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 810230d028ae3da55d080669da80412dae6a881a07c0d385e6db98a5679df197 [INFO] running `Command { std: "docker" "start" "-a" "810230d028ae3da55d080669da80412dae6a881a07c0d385e6db98a5679df197", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.12 [INFO] [stderr] Compiling syn v1.0.19 [INFO] [stderr] Compiling version_check v0.9.1 [INFO] [stderr] Compiling libc v0.2.69 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Checking ahash v0.3.4 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.2 [INFO] [stderr] Compiling proc-macro-error v1.0.2 [INFO] [stderr] Compiling hashbrown v0.7.2 [INFO] [stderr] Compiling quote v1.0.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Compiling syn-mid v0.5.0 [INFO] [stderr] Compiling derive_more v0.99.5 [INFO] [stderr] Compiling structopt-derive v0.4.7 [INFO] [stderr] Checking structopt v0.3.14 [INFO] [stderr] Compiling olympia_core v0.3.0 [INFO] [stderr] Compiling olympia_derive v0.3.0 [INFO] [stderr] Checking olympia_engine v0.3.0 [INFO] [stderr] Checking olympia_cli v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/debugger.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 20 | let mut child = process::Command::new(utils::get_cli_bin()) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | child.wait_with_output().map(|result| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `olympia_cli` (test "integration") due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disassemble.rs:20:22 [INFO] [stdout] | [INFO] [stdout] 14 | fn new(verbose: bool, source_iterator: T) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | decoder: RuntimeDecoder::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `olympia_cli` (bin "olympia_cli") due to 2 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/debugger.rs:513:12 [INFO] [stdout] | [INFO] [stdout] 504 | fn run_debug_script(gb: gameboy::GameBoy, input: &[&str]) -> io::Result { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 509 | let mut debugger = CliDebugger::new(gb, inb, &mut captured_output, &mut captured_error); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 513 | Ok(TestResult { [INFO] [stdout] | ____________^ [INFO] [stdout] 514 | | gb: debugger.gb, [INFO] [stdout] 515 | | output: String::from_utf8_lossy(&captured_output) [INFO] [stdout] 516 | | .lines() [INFO] [stdout] ... | [INFO] [stdout] 522 | | .collect(), [INFO] [stdout] 523 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disassemble.rs:20:22 [INFO] [stdout] | [INFO] [stdout] 14 | fn new(verbose: bool, source_iterator: T) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | decoder: RuntimeDecoder::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `olympia_cli` (bin "olympia_cli" test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "810230d028ae3da55d080669da80412dae6a881a07c0d385e6db98a5679df197", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "810230d028ae3da55d080669da80412dae6a881a07c0d385e6db98a5679df197", kill_on_drop: false }` [INFO] [stdout] 810230d028ae3da55d080669da80412dae6a881a07c0d385e6db98a5679df197