[INFO] fetching crate okane 0.11.0... [INFO] checking okane-0.11.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate okane 0.11.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate okane 0.11.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate okane 0.11.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate okane 0.11.0 [INFO] tweaked toml for crates.io crate okane 0.11.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate okane 0.11.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 04f877bdebc9d49716082d066e38ae02032ba12efb044c3d29cf256a992322bf [INFO] running `Command { std: "docker" "start" "-a" "04f877bdebc9d49716082d066e38ae02032ba12efb044c3d29cf256a992322bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "04f877bdebc9d49716082d066e38ae02032ba12efb044c3d29cf256a992322bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "04f877bdebc9d49716082d066e38ae02032ba12efb044c3d29cf256a992322bf", kill_on_drop: false }` [INFO] [stdout] 04f877bdebc9d49716082d066e38ae02032ba12efb044c3d29cf256a992322bf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2565ece52da9e3930831adbdb5de5e435ca6f01798fcbd4eb2b7989ec2450e25 [INFO] running `Command { std: "docker" "start" "-a" "2565ece52da9e3930831adbdb5de5e435ca6f01798fcbd4eb2b7989ec2450e25", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling strsim v0.11.1 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking indexmap v2.3.0 [INFO] [stderr] Checking annotate-snippets v0.11.4 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking clap_builder v4.5.13 [INFO] [stderr] Compiling rust_decimal v1.35.0 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking bumpalo v3.16.0 [INFO] [stderr] Checking predicates-core v1.0.8 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking encoding_rs_io v0.1.7 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Compiling assert_cmd v2.0.15 [INFO] [stderr] Checking path-slash v0.2.1 [INFO] [stderr] Checking predicates v3.1.2 [INFO] [stderr] Checking predicates-tree v1.0.11 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Compiling indoc v2.0.5 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Compiling rust_decimal_macros v1.35.0 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling bounded-static-derive v0.8.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Compiling ctor v0.2.8 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling serde_with_macros v3.9.0 [INFO] [stderr] Checking clap v4.5.13 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking quick-xml v0.36.1 [INFO] [stderr] Checking bounded-static v0.8.0 [INFO] [stderr] Checking serde_with v3.9.0 [INFO] [stderr] Checking okane-core v0.11.0 [INFO] [stderr] Checking okane v0.11.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: associated function `from_inner` is never used [INFO] [stdout] --> src/import/iso_camt053/xmlnode.rs:324:12 [INFO] [stdout] | [INFO] [stdout] 323 | impl RelatedParty { [INFO] [stdout] | ----------------- associated function in this implementation [INFO] [stdout] 324 | pub fn from_inner(party: PartyDetails) -> Self { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/import/config.rs:175:9 [INFO] [stdout] | [INFO] [stdout] 170 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | / encoding_rs::Encoding::for_label(s.as_bytes()) [INFO] [stdout] 176 | | .ok_or_else(|| D::Error::custom(format!("unknown encoding {}", s))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/import/csv.rs:411:12 [INFO] [stdout] | [INFO] [stdout] 410 | let pattern = extract::regex_matcher(pattern)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 411 | Ok(CsvMatcher { field, pattern }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/import/extract.rs:130:12 [INFO] [stdout] | [INFO] [stdout] 129 | let match_expr = (&from.matcher).try_into()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | Ok(ExtractRule { [INFO] [stdout] | ____________^ [INFO] [stdout] 131 | | match_expr, [INFO] [stdout] 132 | | pending: from.pending, [INFO] [stdout] 133 | | payee: from.payee.as_deref(), [INFO] [stdout] 134 | | account: from.account.as_deref(), [INFO] [stdout] 135 | | conversion: from.conversion.as_ref(), [INFO] [stdout] 136 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/import/viseca.rs:114:12 [INFO] [stdout] | [INFO] [stdout] 113 | let pattern = extract::regex_matcher(v)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | Ok(VisecaMatcher { field, pattern }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/import/viseca/parser.rs:27:21 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(reader: T, currency: String) -> Parser { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Parser { [INFO] [stdout] 27 | reader: LineReader::new(reader), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `okane` (lib) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/import/config.rs:175:9 [INFO] [stdout] | [INFO] [stdout] 170 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | / encoding_rs::Encoding::for_label(s.as_bytes()) [INFO] [stdout] 176 | | .ok_or_else(|| D::Error::custom(format!("unknown encoding {}", s))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/import/config.rs:594:23 [INFO] [stdout] | [INFO] [stdout] 594 | let err = |x| tryinto(x).unwrap_err().to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/import/csv.rs:411:12 [INFO] [stdout] | [INFO] [stdout] 410 | let pattern = extract::regex_matcher(pattern)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 411 | Ok(CsvMatcher { field, pattern }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/import/extract.rs:130:12 [INFO] [stdout] | [INFO] [stdout] 129 | let match_expr = (&from.matcher).try_into()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | Ok(ExtractRule { [INFO] [stdout] | ____________^ [INFO] [stdout] 131 | | match_expr, [INFO] [stdout] 132 | | pending: from.pending, [INFO] [stdout] 133 | | payee: from.payee.as_deref(), [INFO] [stdout] 134 | | account: from.account.as_deref(), [INFO] [stdout] 135 | | conversion: from.conversion.as_ref(), [INFO] [stdout] 136 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/import/extract.rs:327:16 [INFO] [stdout] | [INFO] [stdout] 326 | let pattern = regex_matcher(from.1)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 327 | Ok(TestMatcher { field, pattern }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/import/viseca.rs:114:12 [INFO] [stdout] | [INFO] [stdout] 113 | let pattern = extract::regex_matcher(v)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | Ok(VisecaMatcher { field, pattern }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/import/viseca/parser.rs:27:21 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(reader: T, currency: String) -> Parser { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Parser { [INFO] [stdout] 27 | reader: LineReader::new(reader), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `okane` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "2565ece52da9e3930831adbdb5de5e435ca6f01798fcbd4eb2b7989ec2450e25", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2565ece52da9e3930831adbdb5de5e435ca6f01798fcbd4eb2b7989ec2450e25", kill_on_drop: false }` [INFO] [stdout] 2565ece52da9e3930831adbdb5de5e435ca6f01798fcbd4eb2b7989ec2450e25