[INFO] fetching crate oi-pkg-checker-core 2.0.2... [INFO] checking oi-pkg-checker-core-2.0.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate oi-pkg-checker-core 2.0.2 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate oi-pkg-checker-core 2.0.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate oi-pkg-checker-core 2.0.2 [INFO] finished tweaking crates.io crate oi-pkg-checker-core 2.0.2 [INFO] tweaked toml for crates.io crate oi-pkg-checker-core 2.0.2 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 14 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cf127a098d22c9c1b713bf9d592bae7e3d36682293d0cb227cee7d8f78b81533 [INFO] running `Command { std: "docker" "start" "-a" "cf127a098d22c9c1b713bf9d592bae7e3d36682293d0cb227cee7d8f78b81533", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cf127a098d22c9c1b713bf9d592bae7e3d36682293d0cb227cee7d8f78b81533", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cf127a098d22c9c1b713bf9d592bae7e3d36682293d0cb227cee7d8f78b81533", kill_on_drop: false }` [INFO] [stdout] cf127a098d22c9c1b713bf9d592bae7e3d36682293d0cb227cee7d8f78b81533 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bd727ae223aa27fd9146d5c0778f496a922ac05530ba6718f971c2d9fd34915e [INFO] running `Command { std: "docker" "start" "-a" "bd727ae223aa27fd9146d5c0778f496a922ac05530ba6718f971c2d9fd34915e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking fmri v1.0.3 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking oi-pkg-checker-core v2.0.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packages.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | $shared.borrow() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/packages/components.rs:449:30 [INFO] [stdout] | [INFO] [stdout] 449 | .map(|p| get!(p.upgrade().unwrap()).fmri.clone()) [INFO] [stdout] | -------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `get` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packages/components.rs:456:50 [INFO] [stdout] | [INFO] [stdout] 456 | for p in packages.iter().map(|a| a.upgrade().unwrap()) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packages.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | $shared.borrow() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/packages/components.rs:476:54 [INFO] [stdout] | [INFO] [stdout] 476 | !deps.iter().all(|c| name == get!(c).name) [INFO] [stdout] | ------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `get` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packages.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | $shared.borrow() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/packages/de_serialization.rs:137:19 [INFO] [stdout] | [INFO] [stdout] 137 | let cn = |c: shared_type!(OrgComponent)| -> String { get!(c).get_name().clone() }; [INFO] [stdout] | ----------------------------- ------- in this macro invocation [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `get` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `oi-pkg-checker-core` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packages.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | $shared.borrow() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/packages/components.rs:449:30 [INFO] [stdout] | [INFO] [stdout] 449 | .map(|p| get!(p.upgrade().unwrap()).fmri.clone()) [INFO] [stdout] | -------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `get` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packages/components.rs:456:50 [INFO] [stdout] | [INFO] [stdout] 456 | for p in packages.iter().map(|a| a.upgrade().unwrap()) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packages.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | $shared.borrow() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/packages/components.rs:476:54 [INFO] [stdout] | [INFO] [stdout] 476 | !deps.iter().all(|c| name == get!(c).name) [INFO] [stdout] | ------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `get` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packages.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | $shared.borrow() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/packages/de_serialization.rs:137:19 [INFO] [stdout] | [INFO] [stdout] 137 | let cn = |c: shared_type!(OrgComponent)| -> String { get!(c).get_name().clone() }; [INFO] [stdout] | ----------------------------- ------- in this macro invocation [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `get` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packages.rs:29:26 [INFO] [stdout] | [INFO] [stdout] 29 | std::rc::Rc::new(std::cell::RefCell::new($t)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/tests/de_serialization_test.rs:109:14 [INFO] [stdout] | [INFO] [stdout] 109 | packages: Vec, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | deps: Vec| [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | / new!(Component { [INFO] [stdout] 118 | | name, [INFO] [stdout] 119 | | packages: packages.iter().map(f).collect(), [INFO] [stdout] 120 | | build: deps.clone().iter().map(f).collect(), [INFO] [stdout] ... | [INFO] [stdout] 123 | | sys_test: deps.clone().iter().map(f).collect(), [INFO] [stdout] 124 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `new` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `oi-pkg-checker-core` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "bd727ae223aa27fd9146d5c0778f496a922ac05530ba6718f971c2d9fd34915e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bd727ae223aa27fd9146d5c0778f496a922ac05530ba6718f971c2d9fd34915e", kill_on_drop: false }` [INFO] [stdout] bd727ae223aa27fd9146d5c0778f496a922ac05530ba6718f971c2d9fd34915e