[INFO] fetching crate ohmysmtp 0.1.1... [INFO] checking ohmysmtp-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ohmysmtp 0.1.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate ohmysmtp 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ohmysmtp 0.1.1 [INFO] finished tweaking crates.io crate ohmysmtp 0.1.1 [INFO] tweaked toml for crates.io crate ohmysmtp 0.1.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 74 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding email-address-parser v1.0.3 (latest: v2.0.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding quick-xml v0.18.1 (latest: v0.36.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 440fa7178465a1c797c6a95f9e237cb26a86f0160152a9add7d6cd38abfca93d [INFO] running `Command { std: "docker" "start" "-a" "440fa7178465a1c797c6a95f9e237cb26a86f0160152a9add7d6cd38abfca93d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "440fa7178465a1c797c6a95f9e237cb26a86f0160152a9add7d6cd38abfca93d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "440fa7178465a1c797c6a95f9e237cb26a86f0160152a9add7d6cd38abfca93d", kill_on_drop: false }` [INFO] [stdout] 440fa7178465a1c797c6a95f9e237cb26a86f0160152a9add7d6cd38abfca93d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e4db8522047666050bfc569fc0b480eb388d1192fa41fbd5fcc077f18fd06a36 [INFO] running `Command { std: "docker" "start" "-a" "e4db8522047666050bfc569fc0b480eb388d1192fa41fbd5fcc077f18fd06a36", kill_on_drop: false }` [INFO] [stderr] Checking rustls-pki-types v1.8.0 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling rustls v0.23.12 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Compiling nanoserde-derive v0.1.22 [INFO] [stderr] Checking webpki-roots v0.26.5 [INFO] [stderr] Checking nanoserde v0.1.37 [INFO] [stderr] Checking rustls-webpki v0.102.7 [INFO] [stderr] Checking ureq v2.10.1 [INFO] [stderr] Checking ohmysmtp v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: lint `const_err` has been removed: converted into hard error, see issue #71800 for more information [INFO] [stdout] --> src/lib.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | const_err, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `illegal_floating_point_literal_pattern` has been removed: no longer a warning, float patterns behave the same as `==` [INFO] [stdout] --> src/lib.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | illegal_floating_point_literal_pattern, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/lib.rs:83:33 [INFO] [stdout] | [INFO] [stdout] 83 | let email_json_string = nanoserde::SerJson::serialize_json(email); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:48:1 [INFO] [stdout] | [INFO] [stdout] 48 | unused_qualifications, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 83 - let email_json_string = nanoserde::SerJson::serialize_json(email); [INFO] [stdout] 83 + let email_json_string = SerJson::serialize_json(email); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `const_err` has been removed: converted into hard error, see issue #71800 for more information [INFO] [stdout] --> src/lib.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | const_err, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `illegal_floating_point_literal_pattern` has been removed: no longer a warning, float patterns behave the same as `==` [INFO] [stdout] --> src/lib.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | illegal_floating_point_literal_pattern, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/lib.rs:83:33 [INFO] [stdout] | [INFO] [stdout] 83 | let email_json_string = nanoserde::SerJson::serialize_json(email); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:48:1 [INFO] [stdout] | [INFO] [stdout] 48 | unused_qualifications, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 83 - let email_json_string = nanoserde::SerJson::serialize_json(email); [INFO] [stdout] 83 + let email_json_string = SerJson::serialize_json(email); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:69:20 [INFO] [stdout] | [INFO] [stdout] 66 | pub fn new(api_key: impl ToString) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | agent: ureq::AgentBuilder::new().user_agent("ohmysmtp/0.1.1").build() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:69:20 [INFO] [stdout] | [INFO] [stdout] 66 | pub fn new(api_key: impl ToString) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | agent: ureq::AgentBuilder::new().user_agent("ohmysmtp/0.1.1").build() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:136:15 [INFO] [stdout] | [INFO] [stdout] 82 | let request = self.agent.post("https://app.ohmysmtp.com/api/v1/send"); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | match request [INFO] [stdout] | _______________^ [INFO] [stdout] 137 | | .set("Accept", "application/json") [INFO] [stdout] 138 | | .set("Content-Type", "application/json") [INFO] [stdout] 139 | | .set("OhMySMTP-Server-Token", &self.api_key) [INFO] [stdout] 140 | | .send_string(&email_json_string) [INFO] [stdout] | |____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:136:15 [INFO] [stdout] | [INFO] [stdout] 82 | let request = self.agent.post("https://app.ohmysmtp.com/api/v1/send"); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | match request [INFO] [stdout] | _______________^ [INFO] [stdout] 137 | | .set("Accept", "application/json") [INFO] [stdout] 138 | | .set("Content-Type", "application/json") [INFO] [stdout] 139 | | .set("OhMySMTP-Server-Token", &self.api_key) [INFO] [stdout] 140 | | .send_string(&email_json_string) [INFO] [stdout] | |____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ohmysmtp` (lib) due to 3 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `ohmysmtp` (lib test) due to 3 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e4db8522047666050bfc569fc0b480eb388d1192fa41fbd5fcc077f18fd06a36", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e4db8522047666050bfc569fc0b480eb388d1192fa41fbd5fcc077f18fd06a36", kill_on_drop: false }` [INFO] [stdout] e4db8522047666050bfc569fc0b480eb388d1192fa41fbd5fcc077f18fd06a36