[INFO] fetching crate odra-vm 1.2.0... [INFO] checking odra-vm-1.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate odra-vm 1.2.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate odra-vm 1.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate odra-vm 1.2.0 [INFO] finished tweaking crates.io crate odra-vm 1.2.0 [INFO] tweaked toml for crates.io crate odra-vm 1.2.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 88 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding blake2 v0.9.2 (latest: v0.10.6) [INFO] [stderr] Adding crypto-mac v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding digest v0.9.0 (latest: v0.10.7) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding num-derive v0.3.3 (latest: v0.4.2) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bf27ff4334c538c640931bffb61ad4c038aea2c9ec4a06a34bd84ec970b4350b [INFO] running `Command { std: "docker" "start" "-a" "bf27ff4334c538c640931bffb61ad4c038aea2c9ec4a06a34bd84ec970b4350b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bf27ff4334c538c640931bffb61ad4c038aea2c9ec4a06a34bd84ec970b4350b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bf27ff4334c538c640931bffb61ad4c038aea2c9ec4a06a34bd84ec970b4350b", kill_on_drop: false }` [INFO] [stdout] bf27ff4334c538c640931bffb61ad4c038aea2c9ec4a06a34bd84ec970b4350b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4cb091532a8f66fbb9cad016b417c0b59508bb62adedd3969a88722cdc6a9af4 [INFO] running `Command { std: "docker" "start" "-a" "4cb091532a8f66fbb9cad016b417c0b59508bb62adedd3969a88722cdc6a9af4", kill_on_drop: false }` [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking hex_fmt v0.3.0 [INFO] [stderr] Checking base16 v0.2.1 [INFO] [stderr] Checking der v0.7.9 [INFO] [stderr] Checking ff v0.13.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking uint v0.9.5 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking crypto-mac v0.8.0 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking blake2 v0.9.2 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking ed25519-dalek v2.1.1 [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Compiling casper-event-standard-macro v0.5.0 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking k256 v0.13.3 [INFO] [stderr] Checking casper-types v4.0.2 [INFO] [stderr] Checking casper-event-standard v0.5.0 [INFO] [stderr] Checking odra-core v1.2.0 [INFO] [stderr] Checking odra-vm v1.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/odra_vm_contract_env.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 32 | fn set_named_value(&self, name: &str, value: CLValue) { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | self.vm.borrow().set_named_key(name, value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/odra_vm_contract_env.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 40 | fn set_dictionary_value(&self, dictionary_name: &str, key: &[u8], value: CLValue) { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | self.vm.borrow().set_dict_value(dictionary_name, key, value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/odra_vm_contract_env.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 56 | fn call_contract(&self, address: Address, call_def: CallDef) -> Bytes { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | self.vm.borrow().call_contract(address, call_def) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/odra_vm_contract_env.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 80 | fn revert(&self, error: OdraError) -> ! { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | self.vm.borrow().revert(error) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/odra_vm_contract_env.rs:113:17 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn new(vm: Rc>) -> Rc> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | Rc::new(RefCell::new(Self { vm })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/odra_vm_host.rs:145:17 [INFO] [stdout] | [INFO] [stdout] 143 | pub fn new(vm: Rc>) -> Rc> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | let contract_env = Rc::new(ContractEnv::new(0, OdraVmContractEnv::new(vm.clone()))); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | Rc::new(RefCell::new(Self { vm, contract_env })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `odra-vm` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/odra_vm_contract_env.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 32 | fn set_named_value(&self, name: &str, value: CLValue) { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | self.vm.borrow().set_named_key(name, value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/odra_vm_contract_env.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 40 | fn set_dictionary_value(&self, dictionary_name: &str, key: &[u8], value: CLValue) { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | self.vm.borrow().set_dict_value(dictionary_name, key, value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/odra_vm_contract_env.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 56 | fn call_contract(&self, address: Address, call_def: CallDef) -> Bytes { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | self.vm.borrow().call_contract(address, call_def) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/odra_vm_contract_env.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 80 | fn revert(&self, error: OdraError) -> ! { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | self.vm.borrow().revert(error) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/odra_vm_contract_env.rs:113:17 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn new(vm: Rc>) -> Rc> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | Rc::new(RefCell::new(Self { vm })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/odra_vm_host.rs:145:17 [INFO] [stdout] | [INFO] [stdout] 143 | pub fn new(vm: Rc>) -> Rc> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | let contract_env = Rc::new(ContractEnv::new(0, OdraVmContractEnv::new(vm.clone()))); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | Rc::new(RefCell::new(Self { vm, contract_env })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `odra-vm` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "4cb091532a8f66fbb9cad016b417c0b59508bb62adedd3969a88722cdc6a9af4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4cb091532a8f66fbb9cad016b417c0b59508bb62adedd3969a88722cdc6a9af4", kill_on_drop: false }` [INFO] [stdout] 4cb091532a8f66fbb9cad016b417c0b59508bb62adedd3969a88722cdc6a9af4