[INFO] fetching crate oddio 0.7.4... [INFO] checking oddio-0.7.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate oddio 0.7.4 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate oddio 0.7.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate oddio 0.7.4 [INFO] finished tweaking crates.io crate oddio 0.7.4 [INFO] tweaked toml for crates.io crate oddio 0.7.4 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate oddio 0.7.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 99d0d98f8fbce48b92a440d86013e8447e50b85c7dcbfddd5e61e8310ec12191 [INFO] running `Command { std: "docker" "start" "-a" "99d0d98f8fbce48b92a440d86013e8447e50b85c7dcbfddd5e61e8310ec12191", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "99d0d98f8fbce48b92a440d86013e8447e50b85c7dcbfddd5e61e8310ec12191", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "99d0d98f8fbce48b92a440d86013e8447e50b85c7dcbfddd5e61e8310ec12191", kill_on_drop: false }` [INFO] [stdout] 99d0d98f8fbce48b92a440d86013e8447e50b85c7dcbfddd5e61e8310ec12191 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 59477518d6ac4e2f8f5e634f62c851a0bbe7938935ea46a66491aef1620d2e77 [INFO] running `Command { std: "docker" "start" "-a" "59477518d6ac4e2f8f5e634f62c851a0bbe7938935ea46a66491aef1620d2e77", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.103 [INFO] [stderr] Compiling proc-macro2 v1.0.29 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling pkg-config v0.3.20 [INFO] [stderr] Compiling syn v1.0.80 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking smallvec v1.7.0 [INFO] [stderr] Compiling cpal v0.13.4 [INFO] [stderr] Checking mint v0.5.7 [INFO] [stderr] Checking hound v3.4.0 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking instant v0.1.11 [INFO] [stderr] Checking lock_api v0.4.5 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Checking oddio v0.7.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait `Float` is never used [INFO] [stdout] --> src/math/mod.rs:7:18 [INFO] [stdout] | [INFO] [stdout] 7 | pub(crate) trait Float { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frames.rs:218:9 [INFO] [stdout] | [INFO] [stdout] 217 | fn from(samples: Arc>) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | Self::new(samples, 0.0).1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mixer.rs:54:19 [INFO] [stdout] | [INFO] [stdout] 52 | fn new(signal: T) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | Self { [INFO] [stdout] 54 | stop: Arc::new(AtomicBool::new(false)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mixer.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 71 | let (handle, set) = set(); [INFO] [stdout] | ------ --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | ( [INFO] [stdout] 73 | MixerControl(handle), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mixer.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 71 | let (handle, set) = set(); [INFO] [stdout] | ------ --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | / Self { [INFO] [stdout] 75 | | recv: Inner { [INFO] [stdout] 76 | | set, [INFO] [stdout] 77 | | buffer: vec![T::ZERO; 1024].into(), [INFO] [stdout] 78 | | }, [INFO] [stdout] 79 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/smooth.rs:39:19 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn new(x: T) -> Self [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | prev: x.clone(), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spatial.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 33 | inner: T, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let mut queue = Ring::new((max_delay * rate as f32).ceil() as usize + 1); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | let (send, finished, recv) = Common::new(radius, position, velocity); [INFO] [stdout] | ---- -------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | / Self { [INFO] [stdout] 49 | | rate, [INFO] [stdout] 50 | | max_delay, [INFO] [stdout] 51 | | common: recv, [INFO] [stdout] 52 | | queue, [INFO] [stdout] 53 | | inner, [INFO] [stdout] 54 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spatial.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 67 | inner: T, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | let (send, finished, recv) = Common::new(radius, position, velocity); [INFO] [stdout] | ---- -------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | / Self { [INFO] [stdout] 77 | | common: recv, [INFO] [stdout] 78 | | inner, [INFO] [stdout] 79 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spatial.rs:107:13 [INFO] [stdout] | [INFO] [stdout] 99 | let finished = Arc::new(AtomicBool::new(false)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | let (send, recv) = swap::swap(|| Motion { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | finished.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spatial.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 99 | let finished = Arc::new(AtomicBool::new(false)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | let (send, recv) = swap::swap(|| Motion { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | / Self { [INFO] [stdout] 109 | | radius, [INFO] [stdout] 110 | | motion: recv, [INFO] [stdout] 111 | | state: State::new(position), [INFO] [stdout] 112 | | finished_for: None, [INFO] [stdout] 113 | | stopped: finished, [INFO] [stdout] 114 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spsc.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 12 | let shared = Shared::new(capacity + 1); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | ( [INFO] [stdout] 14 | / Sender { [INFO] [stdout] 15 | | shared: shared.clone(), [INFO] [stdout] 16 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spsc.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 12 | let shared = Shared::new(capacity + 1); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | Receiver { shared, len: 0 }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/swap.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn swap(mut init: impl FnMut() -> T) -> (Sender, Receiver) { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | let shared = Arc::new(Shared { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | / Sender { [INFO] [stdout] 22 | | index: 0, [INFO] [stdout] 23 | | shared: shared.clone(), [INFO] [stdout] 24 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/swap.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn swap(mut init: impl FnMut() -> T) -> (Sender, Receiver) { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | let shared = Arc::new(Shared { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | Receiver { index: 2, shared }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `oddio` (lib) due to 14 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "59477518d6ac4e2f8f5e634f62c851a0bbe7938935ea46a66491aef1620d2e77", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "59477518d6ac4e2f8f5e634f62c851a0bbe7938935ea46a66491aef1620d2e77", kill_on_drop: false }` [INFO] [stdout] 59477518d6ac4e2f8f5e634f62c851a0bbe7938935ea46a66491aef1620d2e77