[INFO] fetching crate ockam_executor 0.85.0... [INFO] checking ockam_executor-0.85.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ockam_executor 0.85.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate ockam_executor 0.85.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ockam_executor 0.85.0 [INFO] finished tweaking crates.io crate ockam_executor 0.85.0 [INFO] tweaked toml for crates.io crate ockam_executor 0.85.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 119 packages to latest compatible versions [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding matchers v0.1.0 (latest: v0.2.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (latest: v0.50.1) [INFO] [stderr] Adding opentelemetry v0.23.0 (latest: v0.24.0) [INFO] [stderr] Adding opentelemetry_sdk v0.23.0 (latest: v0.24.1) [INFO] [stderr] Adding regex-automata v0.1.10 (latest: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding tracing-opentelemetry v0.24.0 (latest: v0.25.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1ea2ebb7c6eda6c1191ebb9b88bc9bffed4a4890f327dc27056de9afb1c789e9 [INFO] running `Command { std: "docker" "start" "-a" "1ea2ebb7c6eda6c1191ebb9b88bc9bffed4a4890f327dc27056de9afb1c789e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1ea2ebb7c6eda6c1191ebb9b88bc9bffed4a4890f327dc27056de9afb1c789e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1ea2ebb7c6eda6c1191ebb9b88bc9bffed4a4890f327dc27056de9afb1c789e9", kill_on_drop: false }` [INFO] [stdout] 1ea2ebb7c6eda6c1191ebb9b88bc9bffed4a4890f327dc27056de9afb1c789e9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] eae5eecad4b41ef3603fbd276b7744efd7b61dde781cf1843f46e2262a70f594 [INFO] running `Command { std: "docker" "start" "-a" "eae5eecad4b41ef3603fbd276b7744efd7b61dde781cf1843f46e2262a70f594", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling minicbor v0.24.2 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Compiling heapless v0.8.0 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking core2 v0.4.0 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking ordered-float v4.2.2 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking tracing-error v0.2.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling minicbor-derive v0.15.0 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling miette-derive v7.2.0 [INFO] [stderr] Compiling ockam_macros v0.34.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking opentelemetry v0.23.0 [INFO] [stderr] Checking miette v7.2.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking opentelemetry_sdk v0.23.0 [INFO] [stderr] Checking tracing-opentelemetry v0.24.0 [INFO] [stderr] Checking serde_bare v0.5.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking ockam_core v0.116.0 [INFO] [stderr] Checking ockam_executor v0.85.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel.rs:34:6 [INFO] [stdout] | [INFO] [stdout] 26 | let inner = Arc::new(Inner { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | let inner_clone = Arc::clone(&inner); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | (Sender(inner), Receiver(inner_clone)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel.rs:34:21 [INFO] [stdout] | [INFO] [stdout] 26 | let inner = Arc::new(Inner { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | let inner_clone = Arc::clone(&inner); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | (Sender(inner), Receiver(inner_clone)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel.rs:34:6 [INFO] [stdout] | [INFO] [stdout] 26 | let inner = Arc::new(Inner { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | let inner_clone = Arc::clone(&inner); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | (Sender(inner), Receiver(inner_clone)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel.rs:34:21 [INFO] [stdout] | [INFO] [stdout] 26 | let inner = Arc::new(Inner { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | let inner_clone = Arc::clone(&inner); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | (Sender(inner), Receiver(inner_clone)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor.rs:120:56 [INFO] [stdout] | [INFO] [stdout] 120 | .or_insert_with(|| TaskWaker::new(task_id, self.task_queue.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor.rs:215:18 [INFO] [stdout] | [INFO] [stdout] 214 | fn allocate(future: impl Future + 'static) -> Box { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 215 | Box::new(Node { [INFO] [stdout] | __________________^ [INFO] [stdout] 216 | | id: TaskId::new(), [INFO] [stdout] 217 | | _name: "Task", [INFO] [stdout] 218 | | future: UnsafeCell::new(async { [INFO] [stdout] ... | [INFO] [stdout] 222 | | // TODO future: Box::pin(future), [INFO] [stdout] 223 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor.rs:120:56 [INFO] [stdout] | [INFO] [stdout] 120 | .or_insert_with(|| TaskWaker::new(task_id, self.task_queue.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor.rs:227:18 [INFO] [stdout] | [INFO] [stdout] 226 | fn allocate_with_name(name: &'static str, future: impl Future + 'static) -> Box { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | Box::new(Node { [INFO] [stdout] | __________________^ [INFO] [stdout] 228 | | id: TaskId::new(), [INFO] [stdout] 229 | | _name: name, [INFO] [stdout] 230 | | future: UnsafeCell::new(async { [INFO] [stdout] ... | [INFO] [stdout] 234 | | // TODO future: Box::pin(future), [INFO] [stdout] 235 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor.rs:275:21 [INFO] [stdout] | [INFO] [stdout] 274 | fn new(task_id: TaskId, task_queue: Arc>) -> Waker { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 275 | Waker::from(Arc::new(TaskWaker { [INFO] [stdout] | _____________________^ [INFO] [stdout] 276 | | task_id, [INFO] [stdout] 277 | | task_queue, [INFO] [stdout] 278 | | marker: core::marker::PhantomData, [INFO] [stdout] 279 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor.rs:215:18 [INFO] [stdout] | [INFO] [stdout] 214 | fn allocate(future: impl Future + 'static) -> Box { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 215 | Box::new(Node { [INFO] [stdout] | __________________^ [INFO] [stdout] 216 | | id: TaskId::new(), [INFO] [stdout] 217 | | _name: "Task", [INFO] [stdout] 218 | | future: UnsafeCell::new(async { [INFO] [stdout] ... | [INFO] [stdout] 222 | | // TODO future: Box::pin(future), [INFO] [stdout] 223 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor.rs:227:18 [INFO] [stdout] | [INFO] [stdout] 226 | fn allocate_with_name(name: &'static str, future: impl Future + 'static) -> Box { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | Box::new(Node { [INFO] [stdout] | __________________^ [INFO] [stdout] 228 | | id: TaskId::new(), [INFO] [stdout] 229 | | _name: name, [INFO] [stdout] 230 | | future: UnsafeCell::new(async { [INFO] [stdout] ... | [INFO] [stdout] 234 | | // TODO future: Box::pin(future), [INFO] [stdout] 235 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor.rs:275:21 [INFO] [stdout] | [INFO] [stdout] 274 | fn new(task_id: TaskId, task_queue: Arc>) -> Waker { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 275 | Waker::from(Arc::new(TaskWaker { [INFO] [stdout] | _____________________^ [INFO] [stdout] 276 | | task_id, [INFO] [stdout] 277 | | task_queue, [INFO] [stdout] 278 | | marker: core::marker::PhantomData, [INFO] [stdout] 279 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ockam_executor` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `ockam_executor` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "eae5eecad4b41ef3603fbd276b7744efd7b61dde781cf1843f46e2262a70f594", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eae5eecad4b41ef3603fbd276b7744efd7b61dde781cf1843f46e2262a70f594", kill_on_drop: false }` [INFO] [stdout] eae5eecad4b41ef3603fbd276b7744efd7b61dde781cf1843f46e2262a70f594