[INFO] fetching crate observe 1.2.0... [INFO] checking observe-1.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate observe 1.2.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate observe 1.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate observe 1.2.0 [INFO] finished tweaking crates.io crate observe 1.2.0 [INFO] tweaked toml for crates.io crate observe 1.2.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 44 packages to latest compatible versions [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding mockall v0.11.4 (latest: v0.13.0) [INFO] [stderr] Adding mockall_derive v0.11.4 (latest: v0.13.0) [INFO] [stderr] Adding predicates v2.1.5 (latest: v3.1.2) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding termtree v0.4.1 (latest: v0.5.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 173fe64add9cf6f16c1598e3c06f8a937f7c0b83cd71664fa991d89ad6cb97d8 [INFO] running `Command { std: "docker" "start" "-a" "173fe64add9cf6f16c1598e3c06f8a937f7c0b83cd71664fa991d89ad6cb97d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "173fe64add9cf6f16c1598e3c06f8a937f7c0b83cd71664fa991d89ad6cb97d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "173fe64add9cf6f16c1598e3c06f8a937f7c0b83cd71664fa991d89ad6cb97d8", kill_on_drop: false }` [INFO] [stdout] 173fe64add9cf6f16c1598e3c06f8a937f7c0b83cd71664fa991d89ad6cb97d8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ca7bcd8ee5cf7293cb10fdb8468b34fe6cf165fb73d8826ed90486999530ec97 [INFO] running `Command { std: "docker" "start" "-a" "ca7bcd8ee5cf7293cb10fdb8468b34fe6cf165fb73d8826ed90486999530ec97", kill_on_drop: false }` [INFO] [stderr] Checking predicates-core v1.0.8 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Compiling mockall_derive v0.11.4 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking downcast v0.11.0 [INFO] [stderr] Checking predicates-tree v1.0.11 [INFO] [stderr] Checking fragile v2.0.0 [INFO] [stderr] Checking enclose v1.2.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking predicates v2.1.5 [INFO] [stderr] Checking mockall v0.11.4 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking observe v1.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/addr.rs:24:3 [INFO] [stdout] | [INFO] [stdout] 24 | Rc::as_ptr(&self.ptr).eq(&Rc::as_ptr(&other.ptr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_wide_pointer_comparisons)]` on by default [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 24 | std::ptr::addr_eq(Rc::as_ptr(&self.ptr), Rc::as_ptr(&other.ptr)) [INFO] [stdout] | ++++++++++++++++++ ~ [INFO] [stdout] help: use explicit `std::ptr::eq` method to compare metadata and addresses [INFO] [stdout] | [INFO] [stdout] 24 | std::ptr::eq(Rc::as_ptr(&self.ptr), Rc::as_ptr(&other.ptr)) [INFO] [stdout] | +++++++++++++ ~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/addr.rs:32:3 [INFO] [stdout] | [INFO] [stdout] 32 | Rc::as_ptr(&self.ptr).cmp(&Rc::as_ptr(&other.ptr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 32 | Rc::as_ptr(&self.ptr).cast::<()>().cmp(&Rc::as_ptr(&other.ptr).cast::<()>()) [INFO] [stdout] | +++++++++++++ +++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/addr.rs:38:8 [INFO] [stdout] | [INFO] [stdout] 38 | Some(Rc::as_ptr(&self.ptr).cmp(&Rc::as_ptr(&other.ptr))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 38 | Some(Rc::as_ptr(&self.ptr).cast::<()>().cmp(&Rc::as_ptr(&other.ptr).cast::<()>())) [INFO] [stdout] | +++++++++++++ +++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/addr.rs:61:3 [INFO] [stdout] | [INFO] [stdout] 61 | Weak::as_ptr(&self.ptr).eq(&Weak::as_ptr(&other.ptr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 61 | std::ptr::addr_eq(Weak::as_ptr(&self.ptr), Weak::as_ptr(&other.ptr)) [INFO] [stdout] | ++++++++++++++++++ ~ [INFO] [stdout] help: use explicit `std::ptr::eq` method to compare metadata and addresses [INFO] [stdout] | [INFO] [stdout] 61 | std::ptr::eq(Weak::as_ptr(&self.ptr), Weak::as_ptr(&other.ptr)) [INFO] [stdout] | +++++++++++++ ~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/addr.rs:69:3 [INFO] [stdout] | [INFO] [stdout] 69 | Weak::as_ptr(&self.ptr).cmp(&Weak::as_ptr(&other.ptr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 69 | Weak::as_ptr(&self.ptr).cast::<()>().cmp(&Weak::as_ptr(&other.ptr).cast::<()>()) [INFO] [stdout] | +++++++++++++ +++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/addr.rs:75:8 [INFO] [stdout] | [INFO] [stdout] 75 | Some(Weak::as_ptr(&self.ptr).cmp(&Weak::as_ptr(&other.ptr))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 75 | Some(Weak::as_ptr(&self.ptr).cast::<()>().cmp(&Weak::as_ptr(&other.ptr).cast::<()>())) [INFO] [stdout] | +++++++++++++ +++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/computed.rs:39:3 [INFO] [stdout] | [INFO] [stdout] 38 | fn try_from(value: Rc) -> Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | Rc::downcast::>(value).map(|body| Computed { body }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/computed.rs:78:10 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn new(func: Box T>) -> Self { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | Computed { [INFO] [stdout] 78 | body: Rc::new_cyclic(|this| ComputedBody { [INFO] [stdout] | ___________________^ [INFO] [stdout] 79 | | value: RefCell::new(None), [INFO] [stdout] 80 | | inner: RefCell::new(ComputedInner { [INFO] [stdout] 81 | | func, [INFO] [stdout] ... | [INFO] [stdout] 86 | | }), [INFO] [stdout] 87 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/computed.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn new(func: Box T>) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | value: RefCell::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/computed.rs:80:12 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn new(func: Box T>) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | inner: RefCell::new(ComputedInner { [INFO] [stdout] | ________________________^ [INFO] [stdout] 81 | | func, [INFO] [stdout] 82 | | state: State::Invalid(Invalid::Definitely), [INFO] [stdout] 83 | | used_by: BTreeSet::new(), [INFO] [stdout] 84 | | dependencies: Dependencies::new(), [INFO] [stdout] 85 | | this: this.clone(), [INFO] [stdout] 86 | | }), [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/const.rs:18:10 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | Const { [INFO] [stdout] 18 | body: Rc::new(ConstBody { value }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluation.rs:26:11 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(parent: Weak) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | inner: RefCell::new({ [INFO] [stdout] | ____________________^ [INFO] [stdout] 27 | | EvaluationInner { [INFO] [stdout] 28 | | dependencies: Dependencies::new(), [INFO] [stdout] 29 | | } [INFO] [stdout] 30 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluation.rs:46:3 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn take(self) -> Dependencies { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | self.inner.into_inner().dependencies [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reaction.rs:70:10 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn new_with_name(name: &'static str, func: Box) -> Self { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | Reaction { [INFO] [stdout] 70 | body: Rc::new_cyclic(|this| ReactionBody { [INFO] [stdout] | ___________________^ [INFO] [stdout] 71 | | inner: RefCell::new(ReactionInner { [INFO] [stdout] 72 | | func, [INFO] [stdout] 73 | | name, [INFO] [stdout] ... | [INFO] [stdout] 77 | | }), [INFO] [stdout] 78 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reaction.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn new_with_name(name: &'static str, func: Box) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | inner: RefCell::new(ReactionInner { [INFO] [stdout] | ________________________^ [INFO] [stdout] 72 | | func, [INFO] [stdout] 73 | | name, [INFO] [stdout] 74 | | state: State::Invalid(Invalid::Definitely), [INFO] [stdout] 75 | | dependencies: Dependencies::new(), [INFO] [stdout] 76 | | this: this.clone(), [INFO] [stdout] 77 | | }), [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/var.rs:26:3 [INFO] [stdout] | [INFO] [stdout] 25 | fn try_from(value: Rc) -> Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Rc::downcast::>(value).map(|body| Var { body }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/var.rs:76:10 [INFO] [stdout] | [INFO] [stdout] 71 | pub fn new(value: T) -> Self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | body: Rc::new_cyclic(|this| VarBody { [INFO] [stdout] | ___________________^ [INFO] [stdout] 77 | | value: RefCell::new(Hashed::new(value)), [INFO] [stdout] 78 | | inner: RefCell::new(VarInner { [INFO] [stdout] 79 | | used_by: BTreeSet::new(), [INFO] [stdout] 80 | | this: this.clone(), [INFO] [stdout] 81 | | }), [INFO] [stdout] 82 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/var.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 71 | pub fn new(value: T) -> Self [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | value: RefCell::new(Hashed::new(value)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/var.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 71 | pub fn new(value: T) -> Self [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | inner: RefCell::new(VarInner { [INFO] [stdout] | ________________________^ [INFO] [stdout] 79 | | used_by: BTreeSet::new(), [INFO] [stdout] 80 | | this: this.clone(), [INFO] [stdout] 81 | | }), [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/var.rs:92:17 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn map(&self, func: F) -> Computed [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | let this = self.body.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | Computed::new(Box::new(move |ev| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 93 | | let value = this.get(ev); [INFO] [stdout] 94 | | func(&*value) [INFO] [stdout] 95 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/addr.rs:24:3 [INFO] [stdout] | [INFO] [stdout] 24 | Rc::as_ptr(&self.ptr).eq(&Rc::as_ptr(&other.ptr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_wide_pointer_comparisons)]` on by default [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 24 | std::ptr::addr_eq(Rc::as_ptr(&self.ptr), Rc::as_ptr(&other.ptr)) [INFO] [stdout] | ++++++++++++++++++ ~ [INFO] [stdout] help: use explicit `std::ptr::eq` method to compare metadata and addresses [INFO] [stdout] | [INFO] [stdout] 24 | std::ptr::eq(Rc::as_ptr(&self.ptr), Rc::as_ptr(&other.ptr)) [INFO] [stdout] | +++++++++++++ ~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/addr.rs:32:3 [INFO] [stdout] | [INFO] [stdout] 32 | Rc::as_ptr(&self.ptr).cmp(&Rc::as_ptr(&other.ptr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 32 | Rc::as_ptr(&self.ptr).cast::<()>().cmp(&Rc::as_ptr(&other.ptr).cast::<()>()) [INFO] [stdout] | +++++++++++++ +++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/addr.rs:38:8 [INFO] [stdout] | [INFO] [stdout] 38 | Some(Rc::as_ptr(&self.ptr).cmp(&Rc::as_ptr(&other.ptr))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 38 | Some(Rc::as_ptr(&self.ptr).cast::<()>().cmp(&Rc::as_ptr(&other.ptr).cast::<()>())) [INFO] [stdout] | +++++++++++++ +++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/addr.rs:61:3 [INFO] [stdout] | [INFO] [stdout] 61 | Weak::as_ptr(&self.ptr).eq(&Weak::as_ptr(&other.ptr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 61 | std::ptr::addr_eq(Weak::as_ptr(&self.ptr), Weak::as_ptr(&other.ptr)) [INFO] [stdout] | ++++++++++++++++++ ~ [INFO] [stdout] help: use explicit `std::ptr::eq` method to compare metadata and addresses [INFO] [stdout] | [INFO] [stdout] 61 | std::ptr::eq(Weak::as_ptr(&self.ptr), Weak::as_ptr(&other.ptr)) [INFO] [stdout] | +++++++++++++ ~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/addr.rs:69:3 [INFO] [stdout] | [INFO] [stdout] 69 | Weak::as_ptr(&self.ptr).cmp(&Weak::as_ptr(&other.ptr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 69 | Weak::as_ptr(&self.ptr).cast::<()>().cmp(&Weak::as_ptr(&other.ptr).cast::<()>()) [INFO] [stdout] | +++++++++++++ +++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/addr.rs:75:8 [INFO] [stdout] | [INFO] [stdout] 75 | Some(Weak::as_ptr(&self.ptr).cmp(&Weak::as_ptr(&other.ptr))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 75 | Some(Weak::as_ptr(&self.ptr).cast::<()>().cmp(&Weak::as_ptr(&other.ptr).cast::<()>())) [INFO] [stdout] | +++++++++++++ +++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/computed.rs:39:3 [INFO] [stdout] | [INFO] [stdout] 38 | fn try_from(value: Rc) -> Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | Rc::downcast::>(value).map(|body| Computed { body }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/computed.rs:78:10 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn new(func: Box T>) -> Self { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | Computed { [INFO] [stdout] 78 | body: Rc::new_cyclic(|this| ComputedBody { [INFO] [stdout] | ___________________^ [INFO] [stdout] 79 | | value: RefCell::new(None), [INFO] [stdout] 80 | | inner: RefCell::new(ComputedInner { [INFO] [stdout] 81 | | func, [INFO] [stdout] ... | [INFO] [stdout] 86 | | }), [INFO] [stdout] 87 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/computed.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn new(func: Box T>) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | value: RefCell::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/computed.rs:80:12 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn new(func: Box T>) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | inner: RefCell::new(ComputedInner { [INFO] [stdout] | ________________________^ [INFO] [stdout] 81 | | func, [INFO] [stdout] 82 | | state: State::Invalid(Invalid::Definitely), [INFO] [stdout] 83 | | used_by: BTreeSet::new(), [INFO] [stdout] 84 | | dependencies: Dependencies::new(), [INFO] [stdout] 85 | | this: this.clone(), [INFO] [stdout] 86 | | }), [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/const.rs:18:10 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | Const { [INFO] [stdout] 18 | body: Rc::new(ConstBody { value }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluation.rs:26:11 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(parent: Weak) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | inner: RefCell::new({ [INFO] [stdout] | ____________________^ [INFO] [stdout] 27 | | EvaluationInner { [INFO] [stdout] 28 | | dependencies: Dependencies::new(), [INFO] [stdout] 29 | | } [INFO] [stdout] 30 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluation.rs:46:3 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn take(self) -> Dependencies { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | self.inner.into_inner().dependencies [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reaction.rs:70:10 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn new_with_name(name: &'static str, func: Box) -> Self { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | Reaction { [INFO] [stdout] 70 | body: Rc::new_cyclic(|this| ReactionBody { [INFO] [stdout] | ___________________^ [INFO] [stdout] 71 | | inner: RefCell::new(ReactionInner { [INFO] [stdout] 72 | | func, [INFO] [stdout] 73 | | name, [INFO] [stdout] ... | [INFO] [stdout] 77 | | }), [INFO] [stdout] 78 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reaction.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn new_with_name(name: &'static str, func: Box) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | inner: RefCell::new(ReactionInner { [INFO] [stdout] | ________________________^ [INFO] [stdout] 72 | | func, [INFO] [stdout] 73 | | name, [INFO] [stdout] 74 | | state: State::Invalid(Invalid::Definitely), [INFO] [stdout] 75 | | dependencies: Dependencies::new(), [INFO] [stdout] 76 | | this: this.clone(), [INFO] [stdout] 77 | | }), [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/var.rs:26:3 [INFO] [stdout] | [INFO] [stdout] 25 | fn try_from(value: Rc) -> Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Rc::downcast::>(value).map(|body| Var { body }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/var.rs:76:10 [INFO] [stdout] | [INFO] [stdout] 71 | pub fn new(value: T) -> Self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | body: Rc::new_cyclic(|this| VarBody { [INFO] [stdout] | ___________________^ [INFO] [stdout] 77 | | value: RefCell::new(Hashed::new(value)), [INFO] [stdout] 78 | | inner: RefCell::new(VarInner { [INFO] [stdout] 79 | | used_by: BTreeSet::new(), [INFO] [stdout] 80 | | this: this.clone(), [INFO] [stdout] 81 | | }), [INFO] [stdout] 82 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/var.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 71 | pub fn new(value: T) -> Self [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | value: RefCell::new(Hashed::new(value)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/var.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 71 | pub fn new(value: T) -> Self [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | inner: RefCell::new(VarInner { [INFO] [stdout] | ________________________^ [INFO] [stdout] 79 | | used_by: BTreeSet::new(), [INFO] [stdout] 80 | | this: this.clone(), [INFO] [stdout] 81 | | }), [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/var.rs:92:17 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn map(&self, func: F) -> Computed [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | let this = self.body.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | Computed::new(Box::new(move |ev| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 93 | | let value = this.get(ev); [INFO] [stdout] 94 | | func(&*value) [INFO] [stdout] 95 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `observe` (lib test) due to 15 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `observe` (lib) due to 15 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ca7bcd8ee5cf7293cb10fdb8468b34fe6cf165fb73d8826ed90486999530ec97", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ca7bcd8ee5cf7293cb10fdb8468b34fe6cf165fb73d8826ed90486999530ec97", kill_on_drop: false }` [INFO] [stdout] ca7bcd8ee5cf7293cb10fdb8468b34fe6cf165fb73d8826ed90486999530ec97