[INFO] fetching crate observables 0.1.0... [INFO] checking observables-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate observables 0.1.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate observables 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate observables 0.1.0 [INFO] finished tweaking crates.io crate observables 0.1.0 [INFO] tweaked toml for crates.io crate observables 0.1.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 32 packages to latest compatible versions [INFO] [stderr] Adding async-channel v1.9.0 (latest: v2.3.1) [INFO] [stderr] Adding event-listener v2.5.3 (latest: v5.3.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 98bae7b49c0689d2ec40de1b83b7d60f8b2ad2c3ed29bdc77e5f9430e482005a [INFO] running `Command { std: "docker" "start" "-a" "98bae7b49c0689d2ec40de1b83b7d60f8b2ad2c3ed29bdc77e5f9430e482005a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "98bae7b49c0689d2ec40de1b83b7d60f8b2ad2c3ed29bdc77e5f9430e482005a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "98bae7b49c0689d2ec40de1b83b7d60f8b2ad2c3ed29bdc77e5f9430e482005a", kill_on_drop: false }` [INFO] [stdout] 98bae7b49c0689d2ec40de1b83b7d60f8b2ad2c3ed29bdc77e5f9430e482005a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 69e79cdbeb21174c0ba9388fb590eac1cfd087818178af1cbafc01ba54f42d21 [INFO] running `Command { std: "docker" "start" "-a" "69e79cdbeb21174c0ba9388fb590eac1cfd087818178af1cbafc01ba54f42d21", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Checking discard v1.0.4 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking waker-fn v1.2.0 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Compiling uuid v1.10.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling gensym v0.1.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking futures-signals v0.3.34 [INFO] [stderr] Checking observables v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: using `.deref()` on a double reference, which returns `&T` instead of dereferencing the inner type [INFO] [stdout] --> src/lib.rs:41:45 [INFO] [stdout] | [INFO] [stdout] 41 | ObservableBorrow::Borrow(x) => x.deref(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transformers/map.rs:32:25 [INFO] [stdout] | [INFO] [stdout] 28 | pub(crate) fn new(wrapped: W, mapper: M) -> Self { [INFO] [stdout] | ---------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | last_value: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transformers/map.rs:51:35 [INFO] [stdout] | [INFO] [stdout] 46 | let input = self.wrapped.borrow_observable_as(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let mapped = (self.mapper)(&*input); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | ObservableBorrow::RefCell(Ref::map(self.last_value.borrow(), |v| { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 52 | | v.as_ref().unwrap().borrow() [INFO] [stdout] 53 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_channel.rs:30:15 [INFO] [stdout] | [INFO] [stdout] 29 | let mut recv = self.receiver.recv(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | match Pin::new(&mut recv).poll(&mut cx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_channel.rs:57:29 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn new(receiver: Receiver) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let wakers: Arc>> = Default::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | let wakers_cloned = wakers.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | combined_waker: waker_fn(move || { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 58 | | wakers_cloned [INFO] [stdout] 59 | | .lock() [INFO] [stdout] 60 | | .unwrap() [INFO] [stdout] 61 | | .drain(..) [INFO] [stdout] 62 | | .for_each(Waker::wake) [INFO] [stdout] 63 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_channel.rs:65:25 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn new(receiver: Receiver) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let wakers: Arc>> = Default::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | let wakers_cloned = wakers.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | last_value: RefCell::new(Default::default()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_channel.rs:58:17 [INFO] [stdout] | [INFO] [stdout] 53 | let wakers_cloned = wakers.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | / wakers_cloned [INFO] [stdout] 59 | | .lock() [INFO] [stdout] 60 | | .unwrap() [INFO] [stdout] 61 | | .drain(..) [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/futures_signals.rs:86:21 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn new(signal: S) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | let wakers: Arc>> = Default::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | let wakers_cloned = wakers.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | Self { [INFO] [stdout] 86 | signal: RefCell::new(signal), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/futures_signals.rs:87:20 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn new(signal: S) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | let wakers: Arc>> = Default::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | let wakers_cloned = wakers.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | value: RefCell::new(Default::default()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/futures_signals.rs:89:29 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn new(signal: S) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | let wakers: Arc>> = Default::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | let wakers_cloned = wakers.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | combined_waker: waker_fn(move || { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 90 | | wakers_cloned [INFO] [stdout] 91 | | .lock() [INFO] [stdout] 92 | | .unwrap() [INFO] [stdout] 93 | | .drain(..) [INFO] [stdout] 94 | | .for_each(Waker::wake); [INFO] [stdout] 95 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/futures_signals.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 134 | fn add_waker(&self, waker: Waker) { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | self.wakers.lock().unwrap().push(waker) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/futures_signals.rs:142:15 [INFO] [stdout] | [INFO] [stdout] 140 | let mut sig = this.signal.borrow_mut(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | let sig = Pin::new(&mut *sig); [INFO] [stdout] 142 | match sig.poll_change(&mut cx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `observables` (lib test) due to 12 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: using `.deref()` on a double reference, which returns `&T` instead of dereferencing the inner type [INFO] [stdout] --> src/lib.rs:41:45 [INFO] [stdout] | [INFO] [stdout] 41 | ObservableBorrow::Borrow(x) => x.deref(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transformers/map.rs:32:25 [INFO] [stdout] | [INFO] [stdout] 28 | pub(crate) fn new(wrapped: W, mapper: M) -> Self { [INFO] [stdout] | ---------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | last_value: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transformers/map.rs:51:35 [INFO] [stdout] | [INFO] [stdout] 46 | let input = self.wrapped.borrow_observable_as(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let mapped = (self.mapper)(&*input); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | ObservableBorrow::RefCell(Ref::map(self.last_value.borrow(), |v| { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 52 | | v.as_ref().unwrap().borrow() [INFO] [stdout] 53 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_channel.rs:30:15 [INFO] [stdout] | [INFO] [stdout] 29 | let mut recv = self.receiver.recv(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | match Pin::new(&mut recv).poll(&mut cx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_channel.rs:57:29 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn new(receiver: Receiver) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let wakers: Arc>> = Default::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | let wakers_cloned = wakers.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | combined_waker: waker_fn(move || { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 58 | | wakers_cloned [INFO] [stdout] 59 | | .lock() [INFO] [stdout] 60 | | .unwrap() [INFO] [stdout] 61 | | .drain(..) [INFO] [stdout] 62 | | .for_each(Waker::wake) [INFO] [stdout] 63 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_channel.rs:65:25 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn new(receiver: Receiver) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let wakers: Arc>> = Default::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | let wakers_cloned = wakers.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | last_value: RefCell::new(Default::default()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_channel.rs:58:17 [INFO] [stdout] | [INFO] [stdout] 53 | let wakers_cloned = wakers.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | / wakers_cloned [INFO] [stdout] 59 | | .lock() [INFO] [stdout] 60 | | .unwrap() [INFO] [stdout] 61 | | .drain(..) [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/futures_signals.rs:86:21 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn new(signal: S) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | let wakers: Arc>> = Default::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | let wakers_cloned = wakers.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | Self { [INFO] [stdout] 86 | signal: RefCell::new(signal), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/futures_signals.rs:87:20 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn new(signal: S) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | let wakers: Arc>> = Default::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | let wakers_cloned = wakers.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | value: RefCell::new(Default::default()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/futures_signals.rs:89:29 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn new(signal: S) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | let wakers: Arc>> = Default::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | let wakers_cloned = wakers.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | combined_waker: waker_fn(move || { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 90 | | wakers_cloned [INFO] [stdout] 91 | | .lock() [INFO] [stdout] 92 | | .unwrap() [INFO] [stdout] 93 | | .drain(..) [INFO] [stdout] 94 | | .for_each(Waker::wake); [INFO] [stdout] 95 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/futures_signals.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 134 | fn add_waker(&self, waker: Waker) { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | self.wakers.lock().unwrap().push(waker) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/futures_signals.rs:142:15 [INFO] [stdout] | [INFO] [stdout] 140 | let mut sig = this.signal.borrow_mut(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | let sig = Pin::new(&mut *sig); [INFO] [stdout] 142 | match sig.poll_change(&mut cx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `observables` (lib) due to 12 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "69e79cdbeb21174c0ba9388fb590eac1cfd087818178af1cbafc01ba54f42d21", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "69e79cdbeb21174c0ba9388fb590eac1cfd087818178af1cbafc01ba54f42d21", kill_on_drop: false }` [INFO] [stdout] 69e79cdbeb21174c0ba9388fb590eac1cfd087818178af1cbafc01ba54f42d21