[INFO] fetching crate objtalk 0.3.0... [INFO] checking objtalk-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate objtalk 0.3.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate objtalk 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate objtalk 0.3.0 [INFO] finished tweaking crates.io crate objtalk 0.3.0 [INFO] tweaked toml for crates.io crate objtalk 0.3.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate objtalk 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3a20e5ab43f0aa9dca6d7d9a56c24a46727874676c4546e3e133ab490b2517ae [INFO] running `Command { std: "docker" "start" "-a" "3a20e5ab43f0aa9dca6d7d9a56c24a46727874676c4546e3e133ab490b2517ae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3a20e5ab43f0aa9dca6d7d9a56c24a46727874676c4546e3e133ab490b2517ae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3a20e5ab43f0aa9dca6d7d9a56c24a46727874676c4546e3e133ab490b2517ae", kill_on_drop: false }` [INFO] [stdout] 3a20e5ab43f0aa9dca6d7d9a56c24a46727874676c4546e3e133ab490b2517ae [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 28bc1bb50f6b2f349c1148d8c930a994809b084fdc45d96a3dcb5b9c5c5276c4 [INFO] running `Command { std: "docker" "start" "-a" "28bc1bb50f6b2f349c1148d8c930a994809b084fdc45d96a3dcb5b9c5c5276c4", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.26 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.72 [INFO] [stderr] Compiling libc v0.2.94 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Checking pin-project-lite v0.2.6 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Checking bytes v1.0.1 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Compiling typenum v1.13.0 [INFO] [stderr] Compiling proc-macro-nested v0.1.7 [INFO] [stderr] Checking futures-core v0.3.14 [INFO] [stderr] Checking futures-sink v0.3.14 [INFO] [stderr] Compiling serde_derive v1.0.125 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Compiling serde v1.0.125 [INFO] [stderr] Checking matches v0.1.8 [INFO] [stderr] Checking futures-channel v0.3.14 [INFO] [stderr] Checking tinyvec v1.2.0 [INFO] [stderr] Compiling httparse v1.4.0 [INFO] [stderr] Checking ahash v0.4.7 [INFO] [stderr] Checking futures-io v0.3.14 [INFO] [stderr] Checking futures-task v0.3.14 [INFO] [stderr] Compiling tokio v1.5.0 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Compiling generic-array v0.14.4 [INFO] [stderr] Checking slab v0.4.3 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking http v0.2.4 [INFO] [stderr] Checking unicode-bidi v0.3.5 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling indexmap v1.6.2 [INFO] [stderr] Compiling cc v1.0.67 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking cpufeatures v0.1.1 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Checking unicode-normalization v0.1.17 [INFO] [stderr] Checking input_buffer v0.4.0 [INFO] [stderr] Checking tracing-core v0.1.18 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Compiling adler32 v1.2.0 [INFO] [stderr] Checking mio v0.7.11 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking tracing v0.1.26 [INFO] [stderr] Compiling deflate v0.9.1 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking socket2 v0.4.0 [INFO] [stderr] Checking rand_core v0.6.2 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking httpdate v1.0.0 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Checking tower-service v0.3.1 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking textwrap v0.12.1 [INFO] [stderr] Compiling heck v0.3.2 [INFO] [stderr] Checking hashlink v0.6.0 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Compiling libsqlite3-sys v0.22.1 [INFO] [stderr] Checking rand v0.8.3 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking os_str_bytes v2.4.0 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Compiling objtalk v0.3.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking sha-1 v0.9.5 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking http-body v0.4.2 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Compiling futures-macro v0.3.14 [INFO] [stderr] Compiling tokio-macros v1.1.0 [INFO] [stderr] Compiling thiserror-impl v1.0.24 [INFO] [stderr] Compiling pin-project-internal v1.0.7 [INFO] [stderr] Compiling clap_derive v3.0.0-beta.2 [INFO] [stderr] Checking futures-util v0.3.14 [INFO] [stderr] Checking thiserror v1.0.24 [INFO] [stderr] Checking tungstenite v0.13.0 [INFO] [stderr] Checking pin-project v1.0.7 [INFO] [stderr] Checking clap v3.0.0-beta.2 [INFO] [stderr] Checking futures-executor v0.3.14 [INFO] [stderr] Checking futures v0.3.14 [INFO] [stderr] Checking hyper v0.14.7 [INFO] [stderr] Checking tokio-tungstenite v0.14.0 [INFO] [stderr] Checking tokio-util v0.6.6 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking hyper-tungstenite v0.3.2 [INFO] [stderr] Checking rusqlite v0.25.1 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/mod.rs:374:40 [INFO] [stdout] | [INFO] [stdout] 371 | fn log(&mut self, message: LogMessage) { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 374 | self.internal_emit("$system", "log", serde_json::to_value(message).unwrap()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/mod.rs:425:24 [INFO] [stdout] | [INFO] [stdout] 407 | let mut state = self.shared.state.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 411 | let (tx, rx) = unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 412 | [INFO] [stdout] 413 | let client = ClientState { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 425 | Client { id, server: self.clone(), inbox_rx: rx } [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/storage/sqlite.rs:26:6 [INFO] [stdout] | [INFO] [stdout] 24 | let conn = Connection::open(config.filename.clone()).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | [INFO] [stdout] 26 | Ok(SqliteStorage::new(conn)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/storage/sqlite.rs:44:3 [INFO] [stdout] | [INFO] [stdout] 32 | let mut stmt = self.conn.prepare("SELECT name, value, last_modified FROM objects").unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let iter = stmt.query_map([], |row| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | iter.collect::,rusqlite::Error>>().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/storage/sqlite.rs:37:7 [INFO] [stdout] | [INFO] [stdout] 35 | let value = serde_json::from_str(&value_str).unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | [INFO] [stdout] 37 | Ok(Object { [INFO] [stdout] | ________________^ [INFO] [stdout] 38 | | name: row.get(0).unwrap(), [INFO] [stdout] 39 | | value, [INFO] [stdout] 40 | | last_modified: row.get(2).unwrap(), [INFO] [stdout] 41 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/json_rpc.rs:74:8 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn handle_message(req: RequestMessage, client: &Client, server: Server) -> Option { [INFO] [stdout] | ------------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | match handle_request(req.request, req.id.clone(), client, server) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/http_transport.rs:162:6 [INFO] [stdout] | [INFO] [stdout] 151 | fn handle_get_all(&self, req: Request) -> Result, (StatusCode, String)> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | let client = self.server.client_connect(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | let pattern = Pattern::compile(&pattern_str) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | let objects = self.server.get(&pattern, &client); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | [INFO] [stdout] 162 | Ok(json_response(&objects)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/http_transport.rs:297:6 [INFO] [stdout] | [INFO] [stdout] 249 | fn handle_query(&self, req: Request) -> Result, (StatusCode, String)> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | let mut client = self.server.client_connect(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 254 | let pattern = Pattern::compile(&pattern_str) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 257 | let (query_id, objects) = self.server.query(&pattern, false, &client) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | let (mut sender, body) = Body::channel(); [INFO] [stdout] | ------ ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 290 | let mut res = Response::builder() [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 297 | Ok(res.body(body).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/http_transport.rs:336:21 [INFO] [stdout] | [INFO] [stdout] 330 | pub fn new(addr: SocketAddr, server: Server, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 336 | request_handler: RequestHandler { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 337 | | server, [INFO] [stdout] 338 | | allow_origin, [INFO] [stdout] 339 | | admin_enabled, [INFO] [stdout] 340 | | admin_asset_overrides, [INFO] [stdout] 341 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/http_transport.rs:353:25 [INFO] [stdout] | [INFO] [stdout] 350 | let request_handler = request_handler.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 353 | Ok::<_, Infallible>(service_fn(move |req| { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 354 | | let request_handler = request_handler.clone(); [INFO] [stdout] 355 | | [INFO] [stdout] 356 | | async move { Ok::<_, Infallible>(request_handler.handle_request(req).await) } [INFO] [stdout] 357 | | })) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/http_transport.rs:356:39 [INFO] [stdout] | [INFO] [stdout] 353 | Ok::<_, Infallible>(service_fn(move |req| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 354 | let request_handler = request_handler.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 355 | [INFO] [stdout] 356 | async move { Ok::<_, Infallible>(request_handler.handle_request(req).await) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `objtalk` (lib test) due to 12 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/mod.rs:374:40 [INFO] [stdout] | [INFO] [stdout] 371 | fn log(&mut self, message: LogMessage) { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 374 | self.internal_emit("$system", "log", serde_json::to_value(message).unwrap()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/mod.rs:425:24 [INFO] [stdout] | [INFO] [stdout] 407 | let mut state = self.shared.state.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 411 | let (tx, rx) = unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 412 | [INFO] [stdout] 413 | let client = ClientState { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 425 | Client { id, server: self.clone(), inbox_rx: rx } [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/storage/sqlite.rs:26:6 [INFO] [stdout] | [INFO] [stdout] 24 | let conn = Connection::open(config.filename.clone()).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | [INFO] [stdout] 26 | Ok(SqliteStorage::new(conn)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/storage/sqlite.rs:44:3 [INFO] [stdout] | [INFO] [stdout] 32 | let mut stmt = self.conn.prepare("SELECT name, value, last_modified FROM objects").unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let iter = stmt.query_map([], |row| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | iter.collect::,rusqlite::Error>>().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/storage/sqlite.rs:37:7 [INFO] [stdout] | [INFO] [stdout] 35 | let value = serde_json::from_str(&value_str).unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | [INFO] [stdout] 37 | Ok(Object { [INFO] [stdout] | ________________^ [INFO] [stdout] 38 | | name: row.get(0).unwrap(), [INFO] [stdout] 39 | | value, [INFO] [stdout] 40 | | last_modified: row.get(2).unwrap(), [INFO] [stdout] 41 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/json_rpc.rs:74:8 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn handle_message(req: RequestMessage, client: &Client, server: Server) -> Option { [INFO] [stdout] | ------------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | match handle_request(req.request, req.id.clone(), client, server) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/http_transport.rs:162:6 [INFO] [stdout] | [INFO] [stdout] 151 | fn handle_get_all(&self, req: Request) -> Result, (StatusCode, String)> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | let client = self.server.client_connect(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | let pattern = Pattern::compile(&pattern_str) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | let objects = self.server.get(&pattern, &client); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | [INFO] [stdout] 162 | Ok(json_response(&objects)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/http_transport.rs:297:6 [INFO] [stdout] | [INFO] [stdout] 249 | fn handle_query(&self, req: Request) -> Result, (StatusCode, String)> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | let mut client = self.server.client_connect(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 254 | let pattern = Pattern::compile(&pattern_str) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 257 | let (query_id, objects) = self.server.query(&pattern, false, &client) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | let (mut sender, body) = Body::channel(); [INFO] [stdout] | ------ ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 290 | let mut res = Response::builder() [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 297 | Ok(res.body(body).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/http_transport.rs:336:21 [INFO] [stdout] | [INFO] [stdout] 330 | pub fn new(addr: SocketAddr, server: Server, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 336 | request_handler: RequestHandler { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 337 | | server, [INFO] [stdout] 338 | | allow_origin, [INFO] [stdout] 339 | | admin_enabled, [INFO] [stdout] 340 | | admin_asset_overrides, [INFO] [stdout] 341 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/http_transport.rs:353:25 [INFO] [stdout] | [INFO] [stdout] 350 | let request_handler = request_handler.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 353 | Ok::<_, Infallible>(service_fn(move |req| { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 354 | | let request_handler = request_handler.clone(); [INFO] [stdout] 355 | | [INFO] [stdout] 356 | | async move { Ok::<_, Infallible>(request_handler.handle_request(req).await) } [INFO] [stdout] 357 | | })) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/http_transport.rs:356:39 [INFO] [stdout] | [INFO] [stdout] 353 | Ok::<_, Infallible>(service_fn(move |req| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 354 | let request_handler = request_handler.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 355 | [INFO] [stdout] 356 | async move { Ok::<_, Infallible>(request_handler.handle_request(req).await) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `objtalk` (lib) due to 12 previous errors [INFO] running `Command { std: "docker" "inspect" "28bc1bb50f6b2f349c1148d8c930a994809b084fdc45d96a3dcb5b9c5c5276c4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "28bc1bb50f6b2f349c1148d8c930a994809b084fdc45d96a3dcb5b9c5c5276c4", kill_on_drop: false }` [INFO] [stdout] 28bc1bb50f6b2f349c1148d8c930a994809b084fdc45d96a3dcb5b9c5c5276c4