[INFO] fetching crate oauth21-server 0.1.2... [INFO] checking oauth21-server-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate oauth21-server 0.1.2 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate oauth21-server 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate oauth21-server 0.1.2 [INFO] finished tweaking crates.io crate oauth21-server 0.1.2 [INFO] tweaked toml for crates.io crate oauth21-server 0.1.2 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 34 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7368999a668bc441ec26b06f967750afe9984ba525b166d16fad66d320dff240 [INFO] running `Command { std: "docker" "start" "-a" "7368999a668bc441ec26b06f967750afe9984ba525b166d16fad66d320dff240", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7368999a668bc441ec26b06f967750afe9984ba525b166d16fad66d320dff240", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7368999a668bc441ec26b06f967750afe9984ba525b166d16fad66d320dff240", kill_on_drop: false }` [INFO] [stdout] 7368999a668bc441ec26b06f967750afe9984ba525b166d16fad66d320dff240 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b3b3026d2bf3a03734df930c3969663c1d5cc4121ba3016a4c0964f318880426 [INFO] running `Command { std: "docker" "start" "-a" "b3b3026d2bf3a03734df930c3969663c1d5cc4121ba3016a4c0964f318880426", kill_on_drop: false }` [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking oauth21-server v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `grant_types` and `response_types` are never read [INFO] [stdout] --> src/client.rs:25:16 [INFO] [stdout] | [INFO] [stdout] 20 | pub struct Client { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] ... [INFO] [stdout] 25 | pub(crate) grant_types: Vec, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 26 | pub(crate) response_types: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Client` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `access_token`, `token_type`, `expires_in`, and `scope` are never read [INFO] [stdout] --> src/provider.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 48 | pub struct TokenResponse { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] 49 | access_token: String, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 50 | token_type: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 51 | expires_in: u64, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 52 | scope: String, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TokenResponse` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `state` is never read [INFO] [stdout] --> src/provider.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 73 | pub struct AuthorizationInformation { [INFO] [stdout] | ------------------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 79 | state: Option, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AuthorizationInformation` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple fields are never read [INFO] [stdout] --> src/provider.rs:85:5 [INFO] [stdout] | [INFO] [stdout] 84 | pub struct SigninInformation { [INFO] [stdout] | ----------------- fields in this struct [INFO] [stdout] 85 | client_name: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 86 | client_uri: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 87 | logo_uri: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 88 | scopes: Vec, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 89 | contacts: Vec, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 90 | tos_uri: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 91 | policy_uri: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SigninInformation` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/provider.rs:113:80 [INFO] [stdout] | [INFO] [stdout] 112 | flow: T, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | ) -> Result<(VerifiedAuthorizationRequest, SigninInformation), OAuthError> { [INFO] [stdout] | ________________________________________________________________________________^ [INFO] [stdout] 114 | | let client = self [INFO] [stdout] 115 | | .get_client(&request.client_id) [INFO] [stdout] 116 | | .await [INFO] [stdout] ... | [INFO] [stdout] 133 | | )) [INFO] [stdout] 134 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `grant_types` and `response_types` are never read [INFO] [stdout] --> src/client.rs:25:16 [INFO] [stdout] | [INFO] [stdout] 20 | pub struct Client { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] ... [INFO] [stdout] 25 | pub(crate) grant_types: Vec, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 26 | pub(crate) response_types: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Client` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/provider.rs:140:42 [INFO] [stdout] | [INFO] [stdout] 139 | flow: T, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | ) -> Result { [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 141 | | flow.perform_authorization(self, request).await [INFO] [stdout] 142 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `access_token`, `token_type`, `expires_in`, and `scope` are never read [INFO] [stdout] --> src/provider.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 48 | pub struct TokenResponse { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] 49 | access_token: String, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 50 | token_type: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 51 | expires_in: u64, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 52 | scope: String, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TokenResponse` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `state` is never read [INFO] [stdout] --> src/provider.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 73 | pub struct AuthorizationInformation { [INFO] [stdout] | ------------------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 79 | state: Option, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AuthorizationInformation` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/provider.rs:149:42 [INFO] [stdout] | [INFO] [stdout] 147 | request: T::Request, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | flow: T, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | ) -> Result { [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 150 | | let request = flow [INFO] [stdout] 151 | | .verify_token_request(authenticated_client, request, self) [INFO] [stdout] 152 | | .await?; [INFO] [stdout] 153 | | flow.perform_token_exchange(request).await [INFO] [stdout] 154 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple fields are never read [INFO] [stdout] --> src/provider.rs:85:5 [INFO] [stdout] | [INFO] [stdout] 84 | pub struct SigninInformation { [INFO] [stdout] | ----------------- fields in this struct [INFO] [stdout] 85 | client_name: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 86 | client_uri: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 87 | logo_uri: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 88 | scopes: Vec, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 89 | contacts: Vec, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 90 | tos_uri: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 91 | policy_uri: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SigninInformation` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/provider.rs:113:80 [INFO] [stdout] | [INFO] [stdout] 112 | flow: T, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | ) -> Result<(VerifiedAuthorizationRequest, SigninInformation), OAuthError> { [INFO] [stdout] | ________________________________________________________________________________^ [INFO] [stdout] 114 | | let client = self [INFO] [stdout] 115 | | .get_client(&request.client_id) [INFO] [stdout] 116 | | .await [INFO] [stdout] ... | [INFO] [stdout] 133 | | )) [INFO] [stdout] 134 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/provider.rs:140:42 [INFO] [stdout] | [INFO] [stdout] 139 | flow: T, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | ) -> Result { [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 141 | | flow.perform_authorization(self, request).await [INFO] [stdout] 142 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/provider.rs:149:42 [INFO] [stdout] | [INFO] [stdout] 147 | request: T::Request, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | flow: T, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | ) -> Result { [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 150 | | let request = flow [INFO] [stdout] 151 | | .verify_token_request(authenticated_client, request, self) [INFO] [stdout] 152 | | .await?; [INFO] [stdout] 153 | | flow.perform_token_exchange(request).await [INFO] [stdout] 154 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `oauth21-server` (lib) due to 4 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `oauth21-server` (lib test) due to 4 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b3b3026d2bf3a03734df930c3969663c1d5cc4121ba3016a4c0964f318880426", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b3b3026d2bf3a03734df930c3969663c1d5cc4121ba3016a4c0964f318880426", kill_on_drop: false }` [INFO] [stdout] b3b3026d2bf3a03734df930c3969663c1d5cc4121ba3016a4c0964f318880426