[INFO] fetching crate nwn-lib-rs 0.3.4... [INFO] checking nwn-lib-rs-0.3.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate nwn-lib-rs 0.3.4 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate nwn-lib-rs 0.3.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nwn-lib-rs 0.3.4 [INFO] finished tweaking crates.io crate nwn-lib-rs 0.3.4 [INFO] tweaked toml for crates.io crate nwn-lib-rs 0.3.4 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 50 packages to latest compatible versions [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] edcde2b1b1eee0c108af56756d1a1bb68a43dbaf5eb67e53910295ae9569db78 [INFO] running `Command { std: "docker" "start" "-a" "edcde2b1b1eee0c108af56756d1a1bb68a43dbaf5eb67e53910295ae9569db78", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "edcde2b1b1eee0c108af56756d1a1bb68a43dbaf5eb67e53910295ae9569db78", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "edcde2b1b1eee0c108af56756d1a1bb68a43dbaf5eb67e53910295ae9569db78", kill_on_drop: false }` [INFO] [stdout] edcde2b1b1eee0c108af56756d1a1bb68a43dbaf5eb67e53910295ae9569db78 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2b1bfaa7b39721637ebe8bda4803b1d7b509d5536f9569ad6d8b25a8548f7b24 [INFO] running `Command { std: "docker" "start" "-a" "2b1bfaa7b39721637ebe8bda4803b1d7b509d5536f9569ad6d8b25a8548f7b24", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Compiling cmake v0.1.51 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling git-version-macro v0.3.9 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking git-version v0.3.9 [INFO] [stderr] Compiling libz-ng-sys v1.1.16 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking nwn-lib-rs v0.3.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gff/bin_gff.rs:586:12 [INFO] [stdout] | [INFO] [stdout] 564 | parser: F, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 582 | let mut vec: Vec = vec![]; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 586 | Ok((input, vec)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trn/mod.rs:403:12 [INFO] [stdout] | [INFO] [stdout] 391 | let packets = packet_indices [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 403 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 404 | | input, [INFO] [stdout] 405 | | Trn { [INFO] [stdout] 406 | | file_type, [INFO] [stdout] ... | [INFO] [stdout] 410 | | }, [INFO] [stdout] 411 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trn/mod.rs:448:12 [INFO] [stdout] | [INFO] [stdout] 446 | let (_, mut res) = Self::from_bytes_head(input)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 447 | res.parse_offsets(full_input, 0)?; [INFO] [stdout] 448 | Ok((&[], res)) [INFO] [stdout] | ^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nwn-lib-rs` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gff/bin_gff.rs:586:12 [INFO] [stdout] | [INFO] [stdout] 564 | parser: F, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 582 | let mut vec: Vec = vec![]; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 586 | Ok((input, vec)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trn/mod.rs:403:12 [INFO] [stdout] | [INFO] [stdout] 391 | let packets = packet_indices [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 403 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 404 | | input, [INFO] [stdout] 405 | | Trn { [INFO] [stdout] 406 | | file_type, [INFO] [stdout] ... | [INFO] [stdout] 410 | | }, [INFO] [stdout] 411 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trn/mod.rs:448:12 [INFO] [stdout] | [INFO] [stdout] 446 | let (_, mut res) = Self::from_bytes_head(input)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 447 | res.parse_offsets(full_input, 0)?; [INFO] [stdout] 448 | Ok((&[], res)) [INFO] [stdout] | ^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nwn-lib-rs` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "2b1bfaa7b39721637ebe8bda4803b1d7b509d5536f9569ad6d8b25a8548f7b24", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2b1bfaa7b39721637ebe8bda4803b1d7b509d5536f9569ad6d8b25a8548f7b24", kill_on_drop: false }` [INFO] [stdout] 2b1bfaa7b39721637ebe8bda4803b1d7b509d5536f9569ad6d8b25a8548f7b24