[INFO] fetching crate numbat-cli 1.13.0... [INFO] checking numbat-cli-1.13.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate numbat-cli 1.13.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate numbat-cli 1.13.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate numbat-cli 1.13.0 [INFO] finished tweaking crates.io crate numbat-cli 1.13.0 [INFO] tweaked toml for crates.io crate numbat-cli 1.13.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate numbat-cli 1.13.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 03db03b9e20728ad723c847a1513788d638588082d1e2a27a3af6741279406b1 [INFO] running `Command { std: "docker" "start" "-a" "03db03b9e20728ad723c847a1513788d638588082d1e2a27a3af6741279406b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "03db03b9e20728ad723c847a1513788d638588082d1e2a27a3af6741279406b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "03db03b9e20728ad723c847a1513788d638588082d1e2a27a3af6741279406b1", kill_on_drop: false }` [INFO] [stdout] 03db03b9e20728ad723c847a1513788d638588082d1e2a27a3af6741279406b1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5bff42ae2dc427e6915ec523e068ca36b54b4745139e5820e2f4bbd6d918c29d [INFO] running `Command { std: "docker" "start" "-a" "5bff42ae2dc427e6915ec523e068ca36b54b4745139e5820e2f4bbd6d918c29d", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling cc v1.0.104 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking tinyvec v1.6.1 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Compiling option-ext v0.2.0 [INFO] [stderr] Compiling cpufeatures v0.2.12 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling syn v2.0.68 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Compiling rustls v0.22.4 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling walkdir v2.5.0 [INFO] [stderr] Compiling ryu_floating_decimal v0.1.0 [INFO] [stderr] Checking webpki-roots v0.26.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking quick-xml v0.31.0 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Checking winnow v0.6.13 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking codespan-reporting v0.11.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking num-format v0.4.4 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Compiling dirs v5.0.1 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Compiling shellexpand v3.1.0 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking heck v0.4.1 [INFO] [stderr] Checking pretty_dtoa v0.3.0 [INFO] [stderr] Checking rust-embed-utils v8.4.0 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking strfmt v0.2.4 [INFO] [stderr] Compiling assert_cmd v2.0.14 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking jiff v0.1.3 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking mendeleev v0.8.1 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking fd-lock v4.0.2 [INFO] [stderr] Checking clap_builder v4.5.8 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling rust-embed-impl v8.4.0 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling rustyline-derive v0.10.0 [INFO] [stderr] Compiling clap_derive v4.5.8 [INFO] [stderr] Checking rustyline v13.0.0 [INFO] [stderr] Checking rust-embed v8.4.0 [INFO] [stderr] Checking clap v4.5.8 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Checking predicates v3.1.0 [INFO] [stderr] Checking rustls-webpki v0.102.4 [INFO] [stderr] Checking toml_datetime v0.6.6 [INFO] [stderr] Checking serde_spanned v0.6.6 [INFO] [stderr] Checking attohttpc v0.27.0 [INFO] [stderr] Checking toml_edit v0.22.14 [INFO] [stderr] Checking numbat-exchange-rates v0.5.0 [INFO] [stderr] Checking numbat v1.13.0 [INFO] [stderr] Checking toml v0.8.14 [INFO] [stderr] Checking numbat-cli v1.13.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:169:12 [INFO] [stdout] | [INFO] [stdout] 157 | let importer = ChainedImporter::new( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | let mut context = Context::new(importer); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 170 | | context: Arc::new(Mutex::new(context)), [INFO] [stdout] 171 | | config, [INFO] [stdout] 172 | | file: args.file, [INFO] [stdout] 173 | | expression: args.expression, [INFO] [stdout] 174 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:544:9 [INFO] [stdout] | [INFO] [stdout] 543 | fn print_diagnostic(&mut self, error: impl ErrorDiagnostic) { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 544 | self.context.lock().unwrap().print_diagnostic(error) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/completer.rs:131:13 [INFO] [stdout] | [INFO] [stdout] 123 | let candidates = self [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | / candidates [INFO] [stdout] 132 | | .map(|w| Pair { [INFO] [stdout] 133 | | display: w.to_string(), [INFO] [stdout] 134 | | replacement: w.to_string(), [INFO] [stdout] 135 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `numbat-cli` (bin "numbat") due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:169:12 [INFO] [stdout] | [INFO] [stdout] 157 | let importer = ChainedImporter::new( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | let mut context = Context::new(importer); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 170 | | context: Arc::new(Mutex::new(context)), [INFO] [stdout] 171 | | config, [INFO] [stdout] 172 | | file: args.file, [INFO] [stdout] 173 | | expression: args.expression, [INFO] [stdout] 174 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:544:9 [INFO] [stdout] | [INFO] [stdout] 543 | fn print_diagnostic(&mut self, error: impl ErrorDiagnostic) { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 544 | self.context.lock().unwrap().print_diagnostic(error) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/completer.rs:131:13 [INFO] [stdout] | [INFO] [stdout] 123 | let candidates = self [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | / candidates [INFO] [stdout] 132 | | .map(|w| Pair { [INFO] [stdout] 133 | | display: w.to_string(), [INFO] [stdout] 134 | | replacement: w.to_string(), [INFO] [stdout] 135 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `numbat-cli` (bin "numbat" test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "5bff42ae2dc427e6915ec523e068ca36b54b4745139e5820e2f4bbd6d918c29d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5bff42ae2dc427e6915ec523e068ca36b54b4745139e5820e2f4bbd6d918c29d", kill_on_drop: false }` [INFO] [stdout] 5bff42ae2dc427e6915ec523e068ca36b54b4745139e5820e2f4bbd6d918c29d