[INFO] fetching crate nu_plugin_from_mp4 0.44.0... [INFO] checking nu_plugin_from_mp4-0.44.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate nu_plugin_from_mp4 0.44.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate nu_plugin_from_mp4 0.44.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nu_plugin_from_mp4 0.44.0 [INFO] finished tweaking crates.io crate nu_plugin_from_mp4 0.44.0 [INFO] tweaked toml for crates.io crate nu_plugin_from_mp4 0.44.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate nu_plugin_from_mp4 0.44.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 10a582b6e1b8202ca30e291222fa4aae93eb664e2f0ce474877a84b7a4f5934a [INFO] running `Command { std: "docker" "start" "-a" "10a582b6e1b8202ca30e291222fa4aae93eb664e2f0ce474877a84b7a4f5934a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "10a582b6e1b8202ca30e291222fa4aae93eb664e2f0ce474877a84b7a4f5934a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "10a582b6e1b8202ca30e291222fa4aae93eb664e2f0ce474877a84b7a4f5934a", kill_on_drop: false }` [INFO] [stdout] 10a582b6e1b8202ca30e291222fa4aae93eb664e2f0ce474877a84b7a4f5934a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] df04f2ce0a9b8980cca70aa267b64f791a5d4e176e371245a87548948a70e994 [INFO] running `Command { std: "docker" "start" "-a" "df04f2ce0a9b8980cca70aa267b64f791a5d4e176e371245a87548948a70e994", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling libc v0.2.117 [INFO] [stderr] Compiling num-bigint v0.4.3 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Compiling serde_json v1.0.78 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Compiling num-bigint v0.2.6 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Checking typed-arena v1.7.0 [INFO] [stderr] Checking linked-hash-map v0.5.4 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking pretty v0.5.2 [INFO] [stderr] Compiling num-iter v0.1.42 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Compiling num-rational v0.2.4 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking nu-ansi-term v0.44.0 [INFO] [stderr] Checking utf8-width v0.1.5 [INFO] [stderr] Checking glob v0.3.0 [INFO] [stderr] Checking byte-unit v4.0.13 [INFO] [stderr] Compiling num-rational v0.4.0 [INFO] [stderr] Checking dunce v1.0.2 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking fastrand v1.7.0 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling quote v1.0.15 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking nu-path v0.44.0 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking num v0.2.1 [INFO] [stderr] Checking hamcrest2 v0.3.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling getset v0.1.2 [INFO] [stderr] Compiling derive-new v0.5.9 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking nu-source v0.44.0 [INFO] [stderr] Checking codespan-reporting v0.11.1 [INFO] [stderr] Checking serde_bytes v0.11.5 [INFO] [stderr] Checking serde_yaml v0.8.23 [INFO] [stderr] Checking chrono-humanize v0.2.1 [INFO] [stderr] Checking bigdecimal v0.3.0 [INFO] [stderr] Checking nu-errors v0.44.0 [INFO] [stderr] Checking mp4 v0.9.2 [INFO] [stderr] Checking nu-protocol v0.44.0 [INFO] [stderr] Checking nu-value-ext v0.44.0 [INFO] [stderr] Checking nu-test-support v0.44.0 [INFO] [stderr] Checking nu-plugin v0.44.0 [INFO] [stderr] Checking nu_plugin_from_mp4 v0.44.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_mp4.rs:147:8 [INFO] [stdout] | [INFO] [stdout] 24 | let mp4 = mp4::read_mp4(File::open(path).expect("Could not open mp4 file to read metadata"))?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | [INFO] [stdout] 26 | let mut dict = TaggedDictBuilder::new(tag.clone()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | let mut tracks = Vec::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | Ok(dict.into_value()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_mp4.rs:153:11 [INFO] [stdout] | [INFO] [stdout] 151 | let mut tempfile = tempfile::NamedTempFile::new()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | tempfile.write_all(bytes.as_mut_slice())?; [INFO] [stdout] 153 | match convert_mp4_file_to_nu_value(tempfile.path(), tag) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_mp4.rs:147:8 [INFO] [stdout] | [INFO] [stdout] 24 | let mp4 = mp4::read_mp4(File::open(path).expect("Could not open mp4 file to read metadata"))?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | [INFO] [stdout] 26 | let mut dict = TaggedDictBuilder::new(tag.clone()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | let mut tracks = Vec::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | Ok(dict.into_value()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_mp4.rs:153:11 [INFO] [stdout] | [INFO] [stdout] 151 | let mut tempfile = tempfile::NamedTempFile::new()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | tempfile.write_all(bytes.as_mut_slice())?; [INFO] [stdout] 153 | match convert_mp4_file_to_nu_value(tempfile.path(), tag) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nu_plugin_from_mp4` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nu_plugin_from_mp4` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "df04f2ce0a9b8980cca70aa267b64f791a5d4e176e371245a87548948a70e994", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "df04f2ce0a9b8980cca70aa267b64f791a5d4e176e371245a87548948a70e994", kill_on_drop: false }` [INFO] [stdout] df04f2ce0a9b8980cca70aa267b64f791a5d4e176e371245a87548948a70e994