[INFO] fetching crate nu-plugin-test-support 0.97.1... [INFO] checking nu-plugin-test-support-0.97.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate nu-plugin-test-support 0.97.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate nu-plugin-test-support 0.97.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nu-plugin-test-support 0.97.1 [INFO] finished tweaking crates.io crate nu-plugin-test-support 0.97.1 [INFO] tweaked toml for crates.io crate nu-plugin-test-support 0.97.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 233 packages to latest compatible versions [INFO] [stderr] Adding ahash v0.7.8 (latest: v0.8.11) [INFO] [stderr] Adding bindgen v0.69.4 (latest: v0.70.1) [INFO] [stderr] Adding bit-set v0.5.3 (latest: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding brotli v5.0.0 (latest: v6.0.0) [INFO] [stderr] Adding bytecheck v0.6.12 (latest: v0.7.0) [INFO] [stderr] Adding bytecheck_derive v0.6.12 (latest: v0.7.0) [INFO] [stderr] Adding cfg_aliases v0.1.1 (latest: v0.2.1) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding lscolors v0.17.0 (latest: v0.19.0) [INFO] [stderr] Adding nix v0.28.0 (latest: v0.29.0) [INFO] [stderr] Adding ptr_meta v0.1.4 (latest: v0.2.0) [INFO] [stderr] Adding ptr_meta_derive v0.1.4 (latest: v0.2.0) [INFO] [stderr] Adding radium v0.7.0 (latest: v1.1.0) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding shadow-rs v0.31.1 (latest: v0.33.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding sysinfo v0.30.13 (latest: v0.31.4) [INFO] [stderr] Adding vte v0.11.1 (latest: v0.13.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows v0.54.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-core v0.54.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-result v0.1.2 (latest: v0.2.0) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding wyz v0.5.1 (latest: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 187b5744dd39eccfe92117eef774422a46b3c568ff9c0277cee52cc26afbae32 [INFO] running `Command { std: "docker" "start" "-a" "187b5744dd39eccfe92117eef774422a46b3c568ff9c0277cee52cc26afbae32", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "187b5744dd39eccfe92117eef774422a46b3c568ff9c0277cee52cc26afbae32", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "187b5744dd39eccfe92117eef774422a46b3c568ff9c0277cee52cc26afbae32", kill_on_drop: false }` [INFO] [stdout] 187b5744dd39eccfe92117eef774422a46b3c568ff9c0277cee52cc26afbae32 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7173ff54ab15218847ddfbfa086301517dfc7353a2199e805777f3929e0d9594 [INFO] running `Command { std: "docker" "start" "-a" "7173ff54ab15218847ddfbfa086301517dfc7353a2199e805777f3929e0d9594", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking pure-rust-locales v0.8.1 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling typeid v1.0.2 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Compiling vte_generate_state_changes v0.1.2 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Compiling procfs v0.16.0 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking alloc-no-stdlib v2.0.4 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Compiling rust_decimal v1.36.0 [INFO] [stderr] Checking alloc-stdlib v0.2.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking vte v0.11.1 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Compiling unicode-segmentation v1.11.0 [INFO] [stderr] Checking nu-ansi-term v0.50.1 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking is_ci v1.2.0 [INFO] [stderr] Checking smawk v0.3.2 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling convert_case v0.6.0 [INFO] [stderr] Checking supports-color v3.0.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking lscolors v0.17.0 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking brotli-decompressor v4.0.1 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking strip-ansi-escapes v0.2.0 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Compiling miette-derive v7.2.0 [INFO] [stderr] Compiling typetag-impl v0.2.18 [INFO] [stderr] Checking num-format v0.4.4 [INFO] [stderr] Checking sys-locale v0.3.1 [INFO] [stderr] Checking supports-unicode v3.0.0 [INFO] [stderr] Checking inventory v0.3.15 [INFO] [stderr] Checking supports-hyperlinks v3.0.0 [INFO] [stderr] Checking utf8-width v0.1.7 [INFO] [stderr] Checking owo-colors v4.0.0 [INFO] [stderr] Compiling nu-derive-value v0.97.1 [INFO] [stderr] Checking lru v0.12.4 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking pwd v1.4.0 [INFO] [stderr] Checking os_pipe v1.2.1 [INFO] [stderr] Compiling unicode-xid v0.2.5 [INFO] [stderr] Checking nu-path v0.97.1 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling const_format_proc_macros v0.2.32 [INFO] [stderr] Compiling doctest-file v1.0.0 [INFO] [stderr] Checking brotli v5.0.0 [INFO] [stderr] Compiling powerfmt v0.2.0 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Checking interprocess v2.2.1 [INFO] [stderr] Compiling deranged v0.3.11 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Compiling itoa v1.0.11 [INFO] [stderr] Compiling num_threads v0.1.7 [INFO] [stderr] Checking nu-glob v0.97.1 [INFO] [stderr] Compiling is_debug v1.0.1 [INFO] [stderr] Checking bytesize v1.3.0 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Compiling const_format v0.2.32 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling time v0.3.36 [INFO] [stderr] Checking sysinfo v0.30.13 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking miette v7.2.0 [INFO] [stderr] Compiling shadow-rs v0.31.1 [INFO] [stderr] Compiling nu-cmd-lang v0.97.1 [INFO] [stderr] Checking fancy-regex v0.13.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking erased-serde v0.4.5 [INFO] [stderr] Checking nu-utils v0.97.1 [INFO] [stderr] Checking byte-unit v5.1.4 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking typetag v0.2.18 [INFO] [stderr] Checking procfs-core v0.16.0 [INFO] [stderr] Checking chrono-humanize v0.2.3 [INFO] [stderr] Checking nu-system v0.97.1 [INFO] [stderr] Checking nu-protocol v0.97.1 [INFO] [stderr] Checking nu-plugin-protocol v0.97.1 [INFO] [stderr] Checking nu-engine v0.97.1 [INFO] [stderr] Checking nu-plugin-core v0.97.1 [INFO] [stderr] Checking nu-plugin-engine v0.97.1 [INFO] [stderr] Checking nu-plugin v0.97.1 [INFO] [stderr] Checking nu-parser v0.97.1 [INFO] [stderr] Checking nu-plugin-test-support v0.97.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fake_persistent_plugin.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn initialize(&self, interface: PluginInterface) { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | self.plugin.set(interface).unwrap_or_else(|_| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fake_persistent_plugin.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 72 | self: Arc, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | / self.plugin [INFO] [stdout] 76 | | .get() [INFO] [stdout] 77 | | .cloned() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugin_test.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 41 | plugin: Arc, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | ) -> Result { [INFO] [stdout] 43 | let mut engine_state = create_default_context(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let mut working_set = StateWorkingSet::new(&engine_state); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | [INFO] [stdout] 46 | let reg_plugin = fake_register(&mut working_set, name, plugin)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let source = Arc::new(PluginSource::new(reg_plugin)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | Ok(PluginTest { [INFO] [stdout] | ____________^ [INFO] [stdout] 52 | | engine_state, [INFO] [stdout] 53 | | source, [INFO] [stdout] 54 | | entry_num: 1, [INFO] [stdout] 55 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugin_test.rs:373:47 [INFO] [stdout] | [INFO] [stdout] 370 | let serialized = PluginCustomValue::serialize_from_custom_value(val, span)? [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 371 | .with_source(self.source.clone()); [INFO] [stdout] 372 | let persistent = self.source.persistent(None)?.get_plugin(None)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 373 | persistent.custom_value_to_base_value(serialized.into_spanned(span)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spawn_fake_plugin.rs:36:6 [INFO] [stdout] | [INFO] [stdout] 35 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | (FakePluginRead(rx), FakePluginWrite(tx)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spawn_fake_plugin.rs:36:26 [INFO] [stdout] | [INFO] [stdout] 35 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | (FakePluginRead(rx), FakePluginWrite(tx)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spawn_fake_plugin.rs:62:24 [INFO] [stdout] | [INFO] [stdout] 45 | let (output_read, output_write) = fake_plugin_channel::(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let mut manager = PluginInterfaceManager::new(source, None, input_write); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | .spawn(move || manager.consume_all(output_read).expect("Plugin read error"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spawn_fake_plugin.rs:69:13 [INFO] [stdout] | [INFO] [stdout] 42 | plugin: Arc, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | ) -> Result, ShellError> { [INFO] [stdout] 44 | let (input_read, input_write) = fake_plugin_channel::(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | let (output_read, output_write) = fake_plugin_channel::(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | / nu_plugin::serve_plugin_io( [INFO] [stdout] 70 | | &*plugin, [INFO] [stdout] 71 | | &name_string, [INFO] [stdout] 72 | | move || input_read, [INFO] [stdout] 73 | | move || output_write, [INFO] [stdout] 74 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nu-plugin-test-support` (lib test) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fake_persistent_plugin.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn initialize(&self, interface: PluginInterface) { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | self.plugin.set(interface).unwrap_or_else(|_| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fake_persistent_plugin.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 72 | self: Arc, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | / self.plugin [INFO] [stdout] 76 | | .get() [INFO] [stdout] 77 | | .cloned() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugin_test.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 41 | plugin: Arc, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | ) -> Result { [INFO] [stdout] 43 | let mut engine_state = create_default_context(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let mut working_set = StateWorkingSet::new(&engine_state); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | [INFO] [stdout] 46 | let reg_plugin = fake_register(&mut working_set, name, plugin)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let source = Arc::new(PluginSource::new(reg_plugin)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | Ok(PluginTest { [INFO] [stdout] | ____________^ [INFO] [stdout] 52 | | engine_state, [INFO] [stdout] 53 | | source, [INFO] [stdout] 54 | | entry_num: 1, [INFO] [stdout] 55 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugin_test.rs:373:47 [INFO] [stdout] | [INFO] [stdout] 370 | let serialized = PluginCustomValue::serialize_from_custom_value(val, span)? [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 371 | .with_source(self.source.clone()); [INFO] [stdout] 372 | let persistent = self.source.persistent(None)?.get_plugin(None)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 373 | persistent.custom_value_to_base_value(serialized.into_spanned(span)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spawn_fake_plugin.rs:36:6 [INFO] [stdout] | [INFO] [stdout] 35 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | (FakePluginRead(rx), FakePluginWrite(tx)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spawn_fake_plugin.rs:36:26 [INFO] [stdout] | [INFO] [stdout] 35 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | (FakePluginRead(rx), FakePluginWrite(tx)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spawn_fake_plugin.rs:62:24 [INFO] [stdout] | [INFO] [stdout] 45 | let (output_read, output_write) = fake_plugin_channel::(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let mut manager = PluginInterfaceManager::new(source, None, input_write); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | .spawn(move || manager.consume_all(output_read).expect("Plugin read error"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spawn_fake_plugin.rs:69:13 [INFO] [stdout] | [INFO] [stdout] 42 | plugin: Arc, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | ) -> Result, ShellError> { [INFO] [stdout] 44 | let (input_read, input_write) = fake_plugin_channel::(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | let (output_read, output_write) = fake_plugin_channel::(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | / nu_plugin::serve_plugin_io( [INFO] [stdout] 70 | | &*plugin, [INFO] [stdout] 71 | | &name_string, [INFO] [stdout] 72 | | move || input_read, [INFO] [stdout] 73 | | move || output_write, [INFO] [stdout] 74 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nu-plugin-test-support` (lib) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "7173ff54ab15218847ddfbfa086301517dfc7353a2199e805777f3929e0d9594", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7173ff54ab15218847ddfbfa086301517dfc7353a2199e805777f3929e0d9594", kill_on_drop: false }` [INFO] [stdout] 7173ff54ab15218847ddfbfa086301517dfc7353a2199e805777f3929e0d9594