[INFO] fetching crate nu-plugin-protocol 0.97.1... [INFO] checking nu-plugin-protocol-0.97.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate nu-plugin-protocol 0.97.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate nu-plugin-protocol 0.97.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nu-plugin-protocol 0.97.1 [INFO] finished tweaking crates.io crate nu-plugin-protocol 0.97.1 [INFO] tweaked toml for crates.io crate nu-plugin-protocol 0.97.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 207 packages to latest compatible versions [INFO] [stderr] Adding ahash v0.7.8 (latest: v0.8.11) [INFO] [stderr] Adding bindgen v0.69.4 (latest: v0.70.1) [INFO] [stderr] Adding bit-set v0.5.3 (latest: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding brotli v5.0.0 (latest: v6.0.0) [INFO] [stderr] Adding bytecheck v0.6.12 (latest: v0.7.0) [INFO] [stderr] Adding bytecheck_derive v0.6.12 (latest: v0.7.0) [INFO] [stderr] Adding cfg_aliases v0.1.1 (latest: v0.2.1) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding lscolors v0.17.0 (latest: v0.19.0) [INFO] [stderr] Adding nix v0.28.0 (latest: v0.29.0) [INFO] [stderr] Adding ptr_meta v0.1.4 (latest: v0.2.0) [INFO] [stderr] Adding ptr_meta_derive v0.1.4 (latest: v0.2.0) [INFO] [stderr] Adding radium v0.7.0 (latest: v1.1.0) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding sysinfo v0.30.13 (latest: v0.31.4) [INFO] [stderr] Adding vte v0.11.1 (latest: v0.13.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows v0.54.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-core v0.54.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-result v0.1.2 (latest: v0.2.0) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding wyz v0.5.1 (latest: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2028358a3e38fc36d390fe1b95027e2fdc9e9da150be5b89029d69573d2783ba [INFO] running `Command { std: "docker" "start" "-a" "2028358a3e38fc36d390fe1b95027e2fdc9e9da150be5b89029d69573d2783ba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2028358a3e38fc36d390fe1b95027e2fdc9e9da150be5b89029d69573d2783ba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2028358a3e38fc36d390fe1b95027e2fdc9e9da150be5b89029d69573d2783ba", kill_on_drop: false }` [INFO] [stdout] 2028358a3e38fc36d390fe1b95027e2fdc9e9da150be5b89029d69573d2783ba [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4eae5a63c8f3d506dea1d5ebedee7af76b0e5117b9ef9e458ae9089bc3cdd77c [INFO] running `Command { std: "docker" "start" "-a" "4eae5a63c8f3d506dea1d5ebedee7af76b0e5117b9ef9e458ae9089bc3cdd77c", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking pure-rust-locales v0.8.1 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Compiling typeid v1.0.2 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Compiling vte_generate_state_changes v0.1.2 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Checking alloc-no-stdlib v2.0.4 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Compiling rust_decimal v1.36.0 [INFO] [stderr] Compiling procfs v0.16.0 [INFO] [stderr] Checking alloc-stdlib v0.2.2 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Checking vte v0.11.1 [INFO] [stderr] Checking smawk v0.3.2 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking is_ci v1.2.0 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling unicode-segmentation v1.11.0 [INFO] [stderr] Checking nu-ansi-term v0.50.1 [INFO] [stderr] Checking num-format v0.4.4 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking supports-color v3.0.0 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking lscolors v0.17.0 [INFO] [stderr] Checking brotli-decompressor v4.0.1 [INFO] [stderr] Checking pwd v1.4.0 [INFO] [stderr] Compiling typetag-impl v0.2.18 [INFO] [stderr] Compiling miette-derive v7.2.0 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Compiling convert_case v0.6.0 [INFO] [stderr] Checking supports-hyperlinks v3.0.0 [INFO] [stderr] Checking strip-ansi-escapes v0.2.0 [INFO] [stderr] Checking utf8-width v0.1.7 [INFO] [stderr] Checking inventory v0.3.15 [INFO] [stderr] Checking sys-locale v0.3.1 [INFO] [stderr] Checking owo-colors v4.0.0 [INFO] [stderr] Checking supports-unicode v3.0.0 [INFO] [stderr] Checking brotli v5.0.0 [INFO] [stderr] Checking lru v0.12.4 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking nu-path v0.97.1 [INFO] [stderr] Checking os_pipe v1.2.1 [INFO] [stderr] Compiling nu-derive-value v0.97.1 [INFO] [stderr] Checking sysinfo v0.30.13 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking miette v7.2.0 [INFO] [stderr] Checking fancy-regex v0.13.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking erased-serde v0.4.5 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Checking byte-unit v5.1.4 [INFO] [stderr] Checking nu-utils v0.97.1 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking typetag v0.2.18 [INFO] [stderr] Checking procfs-core v0.16.0 [INFO] [stderr] Checking chrono-humanize v0.2.3 [INFO] [stderr] Checking nu-system v0.97.1 [INFO] [stderr] Checking nu-protocol v0.97.1 [INFO] [stderr] Checking nu-plugin-protocol v0.97.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 63 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | f: impl FnOnce(D) -> Result, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | ) -> Result, ShellError> { [INFO] [stdout] 66 | Ok(CallInfo { [INFO] [stdout] | ____________^ [INFO] [stdout] 67 | | name: self.name, [INFO] [stdout] 68 | | call: self.call, [INFO] [stdout] 69 | | input: f(self.input)?, [INFO] [stdout] 70 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:174:12 [INFO] [stdout] | [INFO] [stdout] 171 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | f: impl FnOnce(D) -> Result, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | ) -> Result, ShellError> { [INFO] [stdout] 174 | Ok(match self { [INFO] [stdout] | ____________^ [INFO] [stdout] 175 | | PluginCall::Metadata => PluginCall::Metadata, [INFO] [stdout] 176 | | PluginCall::Signature => PluginCall::Signature, [INFO] [stdout] 177 | | PluginCall::Run(call) => PluginCall::Run(call.map_data(f)?), [INFO] [stdout] ... | [INFO] [stdout] 180 | | } [INFO] [stdout] 181 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:333:9 [INFO] [stdout] | [INFO] [stdout] 332 | fn try_from(value: StreamData) -> Result, ShellError>, ShellError> { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 333 | Result::, LabeledError>::try_from(value).map(|res| res.map_err(ShellError::from)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:369:12 [INFO] [stdout] | [INFO] [stdout] 366 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 367 | f: impl FnOnce(D) -> Result, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 368 | ) -> Result, ShellError> { [INFO] [stdout] 369 | Ok(match self { [INFO] [stdout] | ____________^ [INFO] [stdout] 370 | | PluginCallResponse::Error(err) => PluginCallResponse::Error(err), [INFO] [stdout] 371 | | PluginCallResponse::Metadata(meta) => PluginCallResponse::Metadata(meta), [INFO] [stdout] 372 | | PluginCallResponse::Signature(sigs) => PluginCallResponse::Signature(sigs), [INFO] [stdout] 373 | | PluginCallResponse::Ordering(ordering) => PluginCallResponse::Ordering(ordering), [INFO] [stdout] 374 | | PluginCallResponse::PipelineData(input) => PluginCallResponse::PipelineData(f(input)?), [INFO] [stdout] 375 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:580:12 [INFO] [stdout] | [INFO] [stdout] 577 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 578 | f: impl FnOnce(D) -> Result, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 579 | ) -> Result, ShellError> { [INFO] [stdout] 580 | Ok(match self { [INFO] [stdout] | ____________^ [INFO] [stdout] 581 | | EngineCall::GetConfig => EngineCall::GetConfig, [INFO] [stdout] 582 | | EngineCall::GetPluginConfig => EngineCall::GetPluginConfig, [INFO] [stdout] 583 | | EngineCall::GetEnvVar(name) => EngineCall::GetEnvVar(name), [INFO] [stdout] ... | [INFO] [stdout] 617 | | }, [INFO] [stdout] 618 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:640:12 [INFO] [stdout] | [INFO] [stdout] 637 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 638 | f: impl FnOnce(D) -> Result, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 639 | ) -> Result, ShellError> { [INFO] [stdout] 640 | Ok(match self { [INFO] [stdout] | ____________^ [INFO] [stdout] 641 | | EngineCallResponse::Error(err) => EngineCallResponse::Error(err), [INFO] [stdout] 642 | | EngineCallResponse::PipelineData(data) => EngineCallResponse::PipelineData(f(data)?), [INFO] [stdout] 643 | | EngineCallResponse::Config(config) => EngineCallResponse::Config(config), [INFO] [stdout] 644 | | EngineCallResponse::ValueMap(map) => EngineCallResponse::ValueMap(map), [INFO] [stdout] 645 | | EngineCallResponse::Identifier(id) => EngineCallResponse::Identifier(id), [INFO] [stdout] 646 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:653:42 [INFO] [stdout] | [INFO] [stdout] 652 | pub fn value(value: Value) -> EngineCallResponse { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 653 | EngineCallResponse::PipelineData(PipelineData::Value(value, None)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluated_call.rs:144:12 [INFO] [stdout] | [INFO] [stdout] 131 | let positional = [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | let mut named = Vec::with_capacity(call.named_len()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 145 | | head: call.head, [INFO] [stdout] 146 | | positional, [INFO] [stdout] 147 | | named, [INFO] [stdout] 148 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluated_call.rs:160:12 [INFO] [stdout] | [INFO] [stdout] 152 | let positional = call.rest_iter_flattened(stack, 0)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | [INFO] [stdout] 154 | let mut named = Vec::with_capacity(call.named_len(stack)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 161 | | head: call.head, [INFO] [stdout] 162 | | positional, [INFO] [stdout] 163 | | named, [INFO] [stdout] 164 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluated_call.rs:157:67 [INFO] [stdout] | [INFO] [stdout] 157 | .map(|(name, value)| (name.map(|s| s.to_owned()), value.cloned())), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluated_call.rs:451:48 [INFO] [stdout] | [INFO] [stdout] 451 | .map(|value| FromValue::from_value(value.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugin_custom_value/mod.rs:114:23 [INFO] [stdout] | [INFO] [stdout] 113 | pub fn into_value(self, span: Span) -> Value { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | Value::custom(Box::new(self), span) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol_info.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 38 | let mut versions = [ [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | Ok(semver::Comparator { [INFO] [stdout] | ____________^ [INFO] [stdout] 48 | | op: semver::Op::Caret, [INFO] [stdout] 49 | | major: versions[0].major, [INFO] [stdout] 50 | | minor: Some(versions[0].minor), [INFO] [stdout] 51 | | patch: Some(versions[0].patch), [INFO] [stdout] 52 | | pre: versions[0].pre.clone(), [INFO] [stdout] 53 | | } [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 63 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | f: impl FnOnce(D) -> Result, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | ) -> Result, ShellError> { [INFO] [stdout] 66 | Ok(CallInfo { [INFO] [stdout] | ____________^ [INFO] [stdout] 67 | | name: self.name, [INFO] [stdout] 68 | | call: self.call, [INFO] [stdout] 69 | | input: f(self.input)?, [INFO] [stdout] 70 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:174:12 [INFO] [stdout] | [INFO] [stdout] 171 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | f: impl FnOnce(D) -> Result, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | ) -> Result, ShellError> { [INFO] [stdout] 174 | Ok(match self { [INFO] [stdout] | ____________^ [INFO] [stdout] 175 | | PluginCall::Metadata => PluginCall::Metadata, [INFO] [stdout] 176 | | PluginCall::Signature => PluginCall::Signature, [INFO] [stdout] 177 | | PluginCall::Run(call) => PluginCall::Run(call.map_data(f)?), [INFO] [stdout] ... | [INFO] [stdout] 180 | | } [INFO] [stdout] 181 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nu-plugin-protocol` (lib test) due to 14 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:333:9 [INFO] [stdout] | [INFO] [stdout] 332 | fn try_from(value: StreamData) -> Result, ShellError>, ShellError> { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 333 | Result::, LabeledError>::try_from(value).map(|res| res.map_err(ShellError::from)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:369:12 [INFO] [stdout] | [INFO] [stdout] 366 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 367 | f: impl FnOnce(D) -> Result, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 368 | ) -> Result, ShellError> { [INFO] [stdout] 369 | Ok(match self { [INFO] [stdout] | ____________^ [INFO] [stdout] 370 | | PluginCallResponse::Error(err) => PluginCallResponse::Error(err), [INFO] [stdout] 371 | | PluginCallResponse::Metadata(meta) => PluginCallResponse::Metadata(meta), [INFO] [stdout] 372 | | PluginCallResponse::Signature(sigs) => PluginCallResponse::Signature(sigs), [INFO] [stdout] 373 | | PluginCallResponse::Ordering(ordering) => PluginCallResponse::Ordering(ordering), [INFO] [stdout] 374 | | PluginCallResponse::PipelineData(input) => PluginCallResponse::PipelineData(f(input)?), [INFO] [stdout] 375 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:580:12 [INFO] [stdout] | [INFO] [stdout] 577 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 578 | f: impl FnOnce(D) -> Result, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 579 | ) -> Result, ShellError> { [INFO] [stdout] 580 | Ok(match self { [INFO] [stdout] | ____________^ [INFO] [stdout] 581 | | EngineCall::GetConfig => EngineCall::GetConfig, [INFO] [stdout] 582 | | EngineCall::GetPluginConfig => EngineCall::GetPluginConfig, [INFO] [stdout] 583 | | EngineCall::GetEnvVar(name) => EngineCall::GetEnvVar(name), [INFO] [stdout] ... | [INFO] [stdout] 617 | | }, [INFO] [stdout] 618 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:640:12 [INFO] [stdout] | [INFO] [stdout] 637 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 638 | f: impl FnOnce(D) -> Result, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 639 | ) -> Result, ShellError> { [INFO] [stdout] 640 | Ok(match self { [INFO] [stdout] | ____________^ [INFO] [stdout] 641 | | EngineCallResponse::Error(err) => EngineCallResponse::Error(err), [INFO] [stdout] 642 | | EngineCallResponse::PipelineData(data) => EngineCallResponse::PipelineData(f(data)?), [INFO] [stdout] 643 | | EngineCallResponse::Config(config) => EngineCallResponse::Config(config), [INFO] [stdout] 644 | | EngineCallResponse::ValueMap(map) => EngineCallResponse::ValueMap(map), [INFO] [stdout] 645 | | EngineCallResponse::Identifier(id) => EngineCallResponse::Identifier(id), [INFO] [stdout] 646 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:653:42 [INFO] [stdout] | [INFO] [stdout] 652 | pub fn value(value: Value) -> EngineCallResponse { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 653 | EngineCallResponse::PipelineData(PipelineData::Value(value, None)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluated_call.rs:144:12 [INFO] [stdout] | [INFO] [stdout] 131 | let positional = [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | let mut named = Vec::with_capacity(call.named_len()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 145 | | head: call.head, [INFO] [stdout] 146 | | positional, [INFO] [stdout] 147 | | named, [INFO] [stdout] 148 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluated_call.rs:160:12 [INFO] [stdout] | [INFO] [stdout] 152 | let positional = call.rest_iter_flattened(stack, 0)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | [INFO] [stdout] 154 | let mut named = Vec::with_capacity(call.named_len(stack)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 161 | | head: call.head, [INFO] [stdout] 162 | | positional, [INFO] [stdout] 163 | | named, [INFO] [stdout] 164 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluated_call.rs:157:67 [INFO] [stdout] | [INFO] [stdout] 157 | .map(|(name, value)| (name.map(|s| s.to_owned()), value.cloned())), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluated_call.rs:451:48 [INFO] [stdout] | [INFO] [stdout] 451 | .map(|value| FromValue::from_value(value.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugin_custom_value/mod.rs:114:23 [INFO] [stdout] | [INFO] [stdout] 113 | pub fn into_value(self, span: Span) -> Value { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | Value::custom(Box::new(self), span) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol_info.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 38 | let mut versions = [ [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | Ok(semver::Comparator { [INFO] [stdout] | ____________^ [INFO] [stdout] 48 | | op: semver::Op::Caret, [INFO] [stdout] 49 | | major: versions[0].major, [INFO] [stdout] 50 | | minor: Some(versions[0].minor), [INFO] [stdout] 51 | | patch: Some(versions[0].patch), [INFO] [stdout] 52 | | pre: versions[0].pre.clone(), [INFO] [stdout] 53 | | } [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nu-plugin-protocol` (lib) due to 14 previous errors [INFO] running `Command { std: "docker" "inspect" "4eae5a63c8f3d506dea1d5ebedee7af76b0e5117b9ef9e458ae9089bc3cdd77c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4eae5a63c8f3d506dea1d5ebedee7af76b0e5117b9ef9e458ae9089bc3cdd77c", kill_on_drop: false }` [INFO] [stdout] 4eae5a63c8f3d506dea1d5ebedee7af76b0e5117b9ef9e458ae9089bc3cdd77c