[INFO] fetching crate nu-plugin-core 0.97.1... [INFO] checking nu-plugin-core-0.97.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate nu-plugin-core 0.97.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate nu-plugin-core 0.97.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nu-plugin-core 0.97.1 [INFO] finished tweaking crates.io crate nu-plugin-core 0.97.1 [INFO] tweaked toml for crates.io crate nu-plugin-core 0.97.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 212 packages to latest compatible versions [INFO] [stderr] Adding ahash v0.7.8 (latest: v0.8.11) [INFO] [stderr] Adding bindgen v0.69.4 (latest: v0.70.1) [INFO] [stderr] Adding bit-set v0.5.3 (latest: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding brotli v5.0.0 (latest: v6.0.0) [INFO] [stderr] Adding bytecheck v0.6.12 (latest: v0.7.0) [INFO] [stderr] Adding bytecheck_derive v0.6.12 (latest: v0.7.0) [INFO] [stderr] Adding cfg_aliases v0.1.1 (latest: v0.2.1) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding lscolors v0.17.0 (latest: v0.19.0) [INFO] [stderr] Adding nix v0.28.0 (latest: v0.29.0) [INFO] [stderr] Adding ptr_meta v0.1.4 (latest: v0.2.0) [INFO] [stderr] Adding ptr_meta_derive v0.1.4 (latest: v0.2.0) [INFO] [stderr] Adding radium v0.7.0 (latest: v1.1.0) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding sysinfo v0.30.13 (latest: v0.31.4) [INFO] [stderr] Adding vte v0.11.1 (latest: v0.13.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows v0.54.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-core v0.54.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-result v0.1.2 (latest: v0.2.0) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding wyz v0.5.1 (latest: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e3b3a9ef1da592ec2ba52c1a8c89ef545f8fe13e0ad8301b2d15cf373cee417d [INFO] running `Command { std: "docker" "start" "-a" "e3b3a9ef1da592ec2ba52c1a8c89ef545f8fe13e0ad8301b2d15cf373cee417d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e3b3a9ef1da592ec2ba52c1a8c89ef545f8fe13e0ad8301b2d15cf373cee417d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e3b3a9ef1da592ec2ba52c1a8c89ef545f8fe13e0ad8301b2d15cf373cee417d", kill_on_drop: false }` [INFO] [stdout] e3b3a9ef1da592ec2ba52c1a8c89ef545f8fe13e0ad8301b2d15cf373cee417d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5f4c74d793bc382a58b84536eda7967b9a9dd02df6838a213aae0e1c6e534a9f [INFO] running `Command { std: "docker" "start" "-a" "5f4c74d793bc382a58b84536eda7967b9a9dd02df6838a213aae0e1c6e534a9f", kill_on_drop: false }` [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking pure-rust-locales v0.8.1 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Compiling typeid v1.0.2 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Compiling vte_generate_state_changes v0.1.2 [INFO] [stderr] Checking alloc-no-stdlib v2.0.4 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling rust_decimal v1.36.0 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Compiling procfs v0.16.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking vte v0.11.1 [INFO] [stderr] Checking alloc-stdlib v0.2.2 [INFO] [stderr] Compiling unicode-segmentation v1.11.0 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Checking nu-ansi-term v0.50.1 [INFO] [stderr] Checking smawk v0.3.2 [INFO] [stderr] Checking is_ci v1.2.0 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking lscolors v0.17.0 [INFO] [stderr] Compiling convert_case v0.6.0 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking supports-color v3.0.0 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking brotli-decompressor v4.0.1 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking num-format v0.4.4 [INFO] [stderr] Checking supports-unicode v3.0.0 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Checking strip-ansi-escapes v0.2.0 [INFO] [stderr] Checking sys-locale v0.3.1 [INFO] [stderr] Checking inventory v0.3.15 [INFO] [stderr] Checking utf8-width v0.1.7 [INFO] [stderr] Checking supports-hyperlinks v3.0.0 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking owo-colors v4.0.0 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling doctest-file v1.0.0 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking lru v0.12.4 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking os_pipe v1.2.1 [INFO] [stderr] Checking interprocess v2.2.1 [INFO] [stderr] Checking brotli v5.0.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling typetag-impl v0.2.18 [INFO] [stderr] Compiling miette-derive v7.2.0 [INFO] [stderr] Compiling nu-derive-value v0.97.1 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking sysinfo v0.30.13 [INFO] [stderr] Checking fancy-regex v0.13.0 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking pwd v1.4.0 [INFO] [stderr] Checking miette v7.2.0 [INFO] [stderr] Checking nu-path v0.97.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking erased-serde v0.4.5 [INFO] [stderr] Checking nu-utils v0.97.1 [INFO] [stderr] Checking byte-unit v5.1.4 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking typetag v0.2.18 [INFO] [stderr] Checking procfs-core v0.16.0 [INFO] [stderr] Checking chrono-humanize v0.2.3 [INFO] [stderr] Checking nu-system v0.97.1 [INFO] [stderr] Checking nu-protocol v0.97.1 [INFO] [stderr] Checking nu-plugin-protocol v0.97.1 [INFO] [stderr] Checking nu-plugin-core v0.97.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/waitable.rs:137:12 [INFO] [stdout] | [INFO] [stdout] 136 | let sync_state = fail_if_poisoned(self.shared.mutex.lock())?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | Ok(sync_state.value.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/mod.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 106 | let mut lock = self.0.lock().map_err(|_| ShellError::NushellFailed { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | lock.flush().map_err(|err| ShellError::IOError { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/mod.rs:178:36 [INFO] [stdout] | [INFO] [stdout] 175 | header: PipelineDataHeader, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | self.prepare_pipeline_data(match header { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 179 | | PipelineDataHeader::Empty => PipelineData::Empty, [INFO] [stdout] 180 | | PipelineDataHeader::Value(value, metadata) => PipelineData::Value(value, metadata), [INFO] [stdout] 181 | | PipelineDataHeader::ListStream(info) => { [INFO] [stdout] ... | [INFO] [stdout] 193 | | } [INFO] [stdout] 194 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/mod.rs:253:15 [INFO] [stdout] | [INFO] [stdout] 240 | data: PipelineData, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | match self.prepare_pipeline_data(data, context)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/mod.rs:251:33 [INFO] [stdout] | [INFO] [stdout] 248 | let writer = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 251 | Ok::<_, ShellError>((id, writer)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/mod.rs:295:20 [INFO] [stdout] | [INFO] [stdout] 294 | fn write_stream_message(&mut self, msg: StreamMessage) -> Result<(), ShellError> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 295 | self.write(msg.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/mod.rs:332:67 [INFO] [stdout] | [INFO] [stdout] 329 | PipelineDataWriter::ByteStream(mut writer, mut reader) => { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 332 | writer.write_all(std::iter::from_fn(move || match reader.read(buf) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/stream/mod.rs:53:23 [INFO] [stdout] | [INFO] [stdout] 48 | receiver: mpsc::Receiver, ShellError>>, [INFO] [stdout] | ---------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | writer: W, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | receiver: Some(receiver), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/stream/mod.rs:591:12 [INFO] [stdout] | [INFO] [stdout] 569 | writer: W, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 575 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 591 | Ok(StreamReader::new(id, rx, writer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/stream/mod.rs:629:12 [INFO] [stdout] | [INFO] [stdout] 603 | writer: W, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 609 | let signal = Arc::new(StreamWriterSignal::new(high_pressure_mark)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 629 | Ok(StreamWriter::new(id, signal, writer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nu-plugin-core` (lib) due to 11 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/waitable.rs:137:12 [INFO] [stdout] | [INFO] [stdout] 136 | let sync_state = fail_if_poisoned(self.shared.mutex.lock())?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | Ok(sync_state.value.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/mod.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 106 | let mut lock = self.0.lock().map_err(|_| ShellError::NushellFailed { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | lock.flush().map_err(|err| ShellError::IOError { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/mod.rs:178:36 [INFO] [stdout] | [INFO] [stdout] 175 | header: PipelineDataHeader, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | self.prepare_pipeline_data(match header { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 179 | | PipelineDataHeader::Empty => PipelineData::Empty, [INFO] [stdout] 180 | | PipelineDataHeader::Value(value, metadata) => PipelineData::Value(value, metadata), [INFO] [stdout] 181 | | PipelineDataHeader::ListStream(info) => { [INFO] [stdout] ... | [INFO] [stdout] 193 | | } [INFO] [stdout] 194 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/mod.rs:253:15 [INFO] [stdout] | [INFO] [stdout] 240 | data: PipelineData, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | match self.prepare_pipeline_data(data, context)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/mod.rs:251:33 [INFO] [stdout] | [INFO] [stdout] 248 | let writer = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 251 | Ok::<_, ShellError>((id, writer)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/mod.rs:295:20 [INFO] [stdout] | [INFO] [stdout] 294 | fn write_stream_message(&mut self, msg: StreamMessage) -> Result<(), ShellError> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 295 | self.write(msg.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/mod.rs:332:67 [INFO] [stdout] | [INFO] [stdout] 329 | PipelineDataWriter::ByteStream(mut writer, mut reader) => { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 332 | writer.write_all(std::iter::from_fn(move || match reader.read(buf) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/stream/mod.rs:53:23 [INFO] [stdout] | [INFO] [stdout] 48 | receiver: mpsc::Receiver, ShellError>>, [INFO] [stdout] | ---------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | writer: W, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | receiver: Some(receiver), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/stream/mod.rs:591:12 [INFO] [stdout] | [INFO] [stdout] 569 | writer: W, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 575 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 591 | Ok(StreamReader::new(id, rx, writer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/stream/mod.rs:629:12 [INFO] [stdout] | [INFO] [stdout] 603 | writer: W, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 609 | let signal = Arc::new(StreamWriterSignal::new(high_pressure_mark)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 629 | Ok(StreamWriter::new(id, signal, writer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/stream/tests.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 62 | fn write_stream_message(&mut self, msg: StreamMessage) -> Result<(), ShellError> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | self.send(msg).map_err(|err| ShellError::NushellFailed { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/stream/tests.rs:334:9 [INFO] [stdout] | [INFO] [stdout] 320 | let spawned = scope.spawn(|| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 334 | spawned.join().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/stream/tests.rs:354:9 [INFO] [stdout] | [INFO] [stdout] 342 | let spawned = scope.spawn(|| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 354 | spawned.join().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/tests.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 84 | fn prepare_pipeline_data(&self, data: PipelineData) -> Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | Ok(data.set_metadata(Some(test_metadata()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/tests.rs:283:11 [INFO] [stdout] | [INFO] [stdout] 272 | let manager = TestInterfaceManager::new(&TestCase::new()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 278 | let header = PipelineDataHeader::ListStream(ListStreamInfo { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | match manager.read_pipeline_data(header, &Signals::empty())? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/tests.rs:351:11 [INFO] [stdout] | [INFO] [stdout] 345 | let manager = TestInterfaceManager::new(&TestCase::new()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 346 | let interface = manager.get_interface(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 349 | let value = Value::test_binary(vec![7, 8]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 350 | [INFO] [stdout] 351 | match interface.init_write_pipeline_data(PipelineData::Value(value, None), &()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serializers/tests.rs:45:19 [INFO] [stdout] | [INFO] [stdout] 36 | let mut buffered = std::io::BufReader::new(ErrorProducer); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | match Encoder::::decode(&encoder, &mut buffered) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/serializers/json.rs:99:5 [INFO] [stdout] | [INFO] [stdout] 99 | crate::serializers::tests::generate_tests!(JsonSerializer {}); [INFO] [stdout] | ------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `crate::serializers::tests::generate_tests` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serializers/tests.rs:75:19 [INFO] [stdout] | [INFO] [stdout] 64 | let mut buffered = std::io::BufReader::new(&gibberish[..]); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let mut buffered = std::io::BufReader::new(&gibberish[..]); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | match Encoder::::decode(&encoder, &mut buffered) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/serializers/json.rs:99:5 [INFO] [stdout] | [INFO] [stdout] 99 | crate::serializers::tests::generate_tests!(JsonSerializer {}); [INFO] [stdout] | ------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `crate::serializers::tests::generate_tests` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serializers/tests.rs:45:19 [INFO] [stdout] | [INFO] [stdout] 36 | let mut buffered = std::io::BufReader::new(ErrorProducer); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | match Encoder::::decode(&encoder, &mut buffered) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/serializers/msgpack.rs:107:5 [INFO] [stdout] | [INFO] [stdout] 107 | crate::serializers::tests::generate_tests!(MsgPackSerializer {}); [INFO] [stdout] | ---------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `crate::serializers::tests::generate_tests` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serializers/tests.rs:75:19 [INFO] [stdout] | [INFO] [stdout] 64 | let mut buffered = std::io::BufReader::new(&gibberish[..]); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let mut buffered = std::io::BufReader::new(&gibberish[..]); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | match Encoder::::decode(&encoder, &mut buffered) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/serializers/msgpack.rs:107:5 [INFO] [stdout] | [INFO] [stdout] 107 | crate::serializers::tests::generate_tests!(MsgPackSerializer {}); [INFO] [stdout] | ---------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `crate::serializers::tests::generate_tests` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 20 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nu-plugin-core` (lib test) due to 21 previous errors [INFO] running `Command { std: "docker" "inspect" "5f4c74d793bc382a58b84536eda7967b9a9dd02df6838a213aae0e1c6e534a9f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5f4c74d793bc382a58b84536eda7967b9a9dd02df6838a213aae0e1c6e534a9f", kill_on_drop: false }` [INFO] [stdout] 5f4c74d793bc382a58b84536eda7967b9a9dd02df6838a213aae0e1c6e534a9f