[INFO] fetching crate nu-glob 0.97.1... [INFO] checking nu-glob-0.97.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate nu-glob 0.97.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate nu-glob 0.97.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nu-glob 0.97.1 [INFO] finished tweaking crates.io crate nu-glob 0.97.1 [INFO] tweaked toml for crates.io crate nu-glob 0.97.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 60d5488e26150fe54421f546d3763b0abddb88121dae0e9bf6370c090e9355e8 [INFO] running `Command { std: "docker" "start" "-a" "60d5488e26150fe54421f546d3763b0abddb88121dae0e9bf6370c090e9355e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "60d5488e26150fe54421f546d3763b0abddb88121dae0e9bf6370c090e9355e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "60d5488e26150fe54421f546d3763b0abddb88121dae0e9bf6370c090e9355e8", kill_on_drop: false }` [INFO] [stdout] 60d5488e26150fe54421f546d3763b0abddb88121dae0e9bf6370c090e9355e8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 887e91b3f3612e14b5dc284426287a6b3d6ca4b30b5fcd621cb3dbce88a13b7f [INFO] running `Command { std: "docker" "start" "-a" "887e91b3f3612e14b5dc284426287a6b3d6ca4b30b5fcd621cb3dbce88a13b7f", kill_on_drop: false }` [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking nu-glob v0.97.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:281:8 [INFO] [stdout] | [INFO] [stdout] 279 | let todo = Vec::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 280 | [INFO] [stdout] 281 | Ok(Paths { [INFO] [stdout] | ________^ [INFO] [stdout] 282 | | dir_patterns, [INFO] [stdout] 283 | | require_dir, [INFO] [stdout] 284 | | options, [INFO] [stdout] 285 | | todo, [INFO] [stdout] 286 | | scope: Some(scope), [INFO] [stdout] 287 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:940:17 [INFO] [stdout] | [INFO] [stdout] 939 | let dirs = fs::read_dir(path).and_then(|d| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 940 | / d.map(|e| { [INFO] [stdout] 941 | | e.map(|e| { [INFO] [stdout] 942 | | if curdir { [INFO] [stdout] 943 | | PathBuf::from( [INFO] [stdout] ... | [INFO] [stdout] 951 | | }) [INFO] [stdout] 952 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nu-glob` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "887e91b3f3612e14b5dc284426287a6b3d6ca4b30b5fcd621cb3dbce88a13b7f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "887e91b3f3612e14b5dc284426287a6b3d6ca4b30b5fcd621cb3dbce88a13b7f", kill_on_drop: false }` [INFO] [stdout] 887e91b3f3612e14b5dc284426287a6b3d6ca4b30b5fcd621cb3dbce88a13b7f