[INFO] fetching crate ntpd 1.2.3... [INFO] checking ntpd-1.2.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ntpd 1.2.3 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate ntpd 1.2.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ntpd 1.2.3 [INFO] finished tweaking crates.io crate ntpd 1.2.3 [INFO] tweaked toml for crates.io crate ntpd 1.2.3 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate ntpd 1.2.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e6e0e06da935b4fccb43bf404c64360c2212f3a5dcd6ad074842c073f66234a3 [INFO] running `Command { std: "docker" "start" "-a" "e6e0e06da935b4fccb43bf404c64360c2212f3a5dcd6ad074842c073f66234a3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e6e0e06da935b4fccb43bf404c64360c2212f3a5dcd6ad074842c073f66234a3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e6e0e06da935b4fccb43bf404c64360c2212f3a5dcd6ad074842c073f66234a3", kill_on_drop: false }` [INFO] [stdout] e6e0e06da935b4fccb43bf404c64360c2212f3a5dcd6ad074842c073f66234a3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f5e4721d4487688c7caa62eff7144af01f0cf714d7c4b2fa8de5f8589d29da97 [INFO] running `Command { std: "docker" "start" "-a" "f5e4721d4487688c7caa62eff7144af01f0cf714d7c4b2fa8de5f8589d29da97", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling cc v1.1.0 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Compiling rustls v0.23.11 [INFO] [stderr] Checking dbl v0.3.2 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Checking winnow v0.6.13 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Compiling ntpd v1.2.3 (/opt/rustwide/workdir) [INFO] [stderr] Compiling syn v2.0.70 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking rustls-native-certs v0.7.1 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking cmac v0.7.2 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking clock-steering v0.2.1 [INFO] [stderr] Checking aes-siv v0.7.0 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking tokio v1.38.1 [INFO] [stderr] Checking rustls-webpki v0.102.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking toml_datetime v0.6.6 [INFO] [stderr] Checking serde_spanned v0.6.6 [INFO] [stderr] Checking timestamped-socket v0.2.2 [INFO] [stderr] Checking ntp-proto v1.2.3 [INFO] [stderr] Checking toml_edit v0.22.16 [INFO] [stderr] Checking toml v0.8.15 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/config/ntp_source.rs:39:11 [INFO] [stdout] | [INFO] [stdout] 33 | deserializer: D, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | match certificates_from_file(&certificate_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/keyexchange.rs:83:18 [INFO] [stdout] | [INFO] [stdout] 81 | keyset: tokio::sync::watch::Receiver>, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | ) -> JoinHandle> { [INFO] [stdout] 83 | tokio::spawn(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 84 | | let result = run_nts_ke(nts_ke_config, keyset).await; [INFO] [stdout] 85 | | [INFO] [stdout] 86 | | match result { [INFO] [stdout] ... | [INFO] [stdout] 92 | | } [INFO] [stdout] 93 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/keyexchange.rs:174:8 [INFO] [stdout] | [INFO] [stdout] 157 | let mut config = rustls::ServerConfig::builder_with_protocol_versions(&[&TLS13]) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | Ok(Arc::new(config)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/keyexchange.rs:243:17 [INFO] [stdout] | [INFO] [stdout] 214 | let (stream, source_addr) = match listener.accept().await { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 236 | let config = config.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | let keyset = keyset.borrow().clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | let pool_certs = pool_certs.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | / BoundKeyExchangeServer::run( [INFO] [stdout] 244 | | stream, [INFO] [stdout] 245 | | config, [INFO] [stdout] 246 | | keyset, [INFO] [stdout] ... | [INFO] [stdout] 250 | | ) [INFO] [stdout] 251 | | .await [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/keyexchange.rs:284:12 [INFO] [stdout] | [INFO] [stdout] 279 | io: IO, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 280 | server_name: String, [INFO] [stdout] 281 | config: rustls::ClientConfig, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 282 | denied_servers: impl IntoIterator, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 283 | ) -> Result { [INFO] [stdout] 284 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 285 | | inner: Some(BoundKeyExchangeClientData { [INFO] [stdout] 286 | | io, [INFO] [stdout] 287 | | client: KeyExchangeClient::new(server_name, config, denied_servers)?, [INFO] [stdout] 288 | | need_flush: false, [INFO] [stdout] 289 | | }), [INFO] [stdout] 290 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/keyexchange.rs:422:12 [INFO] [stdout] | [INFO] [stdout] 409 | io: IO, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 410 | config: Arc, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 411 | keyset: Arc, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 414 | pool_certs: Arc<[rustls::pki_types::CertificateDer<'static>]>, [INFO] [stdout] | ------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 415 | ) -> Result { [INFO] [stdout] 416 | let data = BoundKeyExchangeServerData { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 422 | Ok(Self { inner: Some(data) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/keyexchange.rs:607:5 [INFO] [stdout] | [INFO] [stdout] 605 | mut reader: impl BufRead, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 606 | ) -> std::io::Result>> { [INFO] [stdout] 607 | rustls_pemfile::certs(&mut reader).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/nts_key_provider.rs:35:37 [INFO] [stdout] | [INFO] [stdout] 35 | .unwrap_or_else(|e| Err(std::io::Error::new(std::io::ErrorKind::Other, e))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/nts_key_provider.rs:39:21 [INFO] [stdout] | [INFO] [stdout] 36 | .unwrap_or_else(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | KeySetProvider::new(config.stale_key_count), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/observer.rs:148:14 [INFO] [stdout] | [INFO] [stdout] 113 | let (mut stream, _addr) = match observe_listener.accept().await { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | let sources_reader = sources_reader.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | let server_reader = server_reader.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | let system_reader = system_reader.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/server.rs:99:12 [INFO] [stdout] | [INFO] [stdout] 94 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | let value = Arc::new(Deserialize::deserialize(deserializer)?); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | Ok(Counter { value }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/server.rs:121:22 [INFO] [stdout] | [INFO] [stdout] 115 | stats: ServerStats, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | mut system_receiver: tokio::sync::watch::Receiver, [INFO] [stdout] | ----------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | mut keyset: tokio::sync::watch::Receiver>, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | clock: C, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 122 | | let server = Server::new( [INFO] [stdout] 123 | | config.clone().into(), [INFO] [stdout] 124 | | clock, [INFO] [stdout] ... | [INFO] [stdout] 138 | | process.serve().await; [INFO] [stdout] 139 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/spawn/mod.rs:122:29 [INFO] [stdout] | [INFO] [stdout] 120 | nts: Option>, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | ) -> SpawnAction { [INFO] [stdout] 122 | SpawnAction::Create(SourceCreateParameters { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 123 | | id, [INFO] [stdout] 124 | | addr, [INFO] [stdout] 125 | | normalized_addr, [INFO] [stdout] 126 | | protocol_version, [INFO] [stdout] 127 | | nts, [INFO] [stdout] 128 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/spawn/mod.rs:178:34 [INFO] [stdout] | [INFO] [stdout] 177 | _event: SourceCreateParameters, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | ) -> Result<(), Self::Error> { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 179 | | Ok(()) [INFO] [stdout] 180 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/system.rs:45:20 [INFO] [stdout] | [INFO] [stdout] 42 | fn new_disabled(t: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | sleep: Box::pin(t), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/system.rs:153:27 [INFO] [stdout] | [INFO] [stdout] 97 | let (mut system, channels) = SystemTask::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | let sleep = [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | SingleshotSleep::new_disabled(tokio::time::sleep_until(tokio::time::Instant::now())); [INFO] [stdout] 152 | tokio::pin!(sleep); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | system.run(sleep).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/system.rs:224:13 [INFO] [stdout] | [INFO] [stdout] 197 | clock: C, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | keyset: tokio::sync::watch::Receiver>, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | ip_list: tokio::sync::watch::Receiver>, [INFO] [stdout] | ---------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | ) -> (Self, DaemonChannels) { [INFO] [stdout] 205 | let system = System::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | let (system_snapshot_sender, system_snapshot_receiver) = [INFO] [stdout] | ---------------------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | tokio::sync::watch::channel(system.system_snapshot()); [INFO] [stdout] 215 | let source_snapshots = Arc::new(RwLock::new(HashMap::new())); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 216 | let (server_data_sender, server_data_receiver) = tokio::sync::watch::channel(vec![]); [INFO] [stdout] | ------------------ -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | let (msg_for_system_sender, msg_for_system_receiver) = [INFO] [stdout] | --------------------- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | tokio::sync::mpsc::channel(MESSAGE_BUFFER_SIZE); [INFO] [stdout] 219 | let (system_update_sender, _) = tokio::sync::broadcast::channel(MESSAGE_BUFFER_SIZE); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | let (spawn_tx, spawn_rx) = mpsc::channel(MESSAGE_BUFFER_SIZE); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 224 | / SystemTask { [INFO] [stdout] 225 | | _wait: PhantomData, [INFO] [stdout] 226 | | system, [INFO] [stdout] ... | [INFO] [stdout] 245 | | interface, [INFO] [stdout] 246 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/system.rs:247:13 [INFO] [stdout] | [INFO] [stdout] 197 | clock: C, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | keyset: tokio::sync::watch::Receiver>, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | ip_list: tokio::sync::watch::Receiver>, [INFO] [stdout] | ---------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | ) -> (Self, DaemonChannels) { [INFO] [stdout] 205 | let system = System::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | let (system_snapshot_sender, system_snapshot_receiver) = [INFO] [stdout] | ---------------------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | tokio::sync::watch::channel(system.system_snapshot()); [INFO] [stdout] 215 | let source_snapshots = Arc::new(RwLock::new(HashMap::new())); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 216 | let (server_data_sender, server_data_receiver) = tokio::sync::watch::channel(vec![]); [INFO] [stdout] | ------------------ -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | let (msg_for_system_sender, msg_for_system_receiver) = [INFO] [stdout] | --------------------- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | tokio::sync::mpsc::channel(MESSAGE_BUFFER_SIZE); [INFO] [stdout] 219 | let (system_update_sender, _) = tokio::sync::broadcast::channel(MESSAGE_BUFFER_SIZE); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | let (spawn_tx, spawn_rx) = mpsc::channel(MESSAGE_BUFFER_SIZE); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | / DaemonChannels { [INFO] [stdout] 248 | | source_snapshots, [INFO] [stdout] 249 | | server_data_receiver, [INFO] [stdout] 250 | | system_snapshot_receiver, [INFO] [stdout] 251 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics/exporter.rs:200:74 [INFO] [stdout] | [INFO] [stdout] 176 | let (mut tcp_stream, _) = match listener.accept().await { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | let path = observation_socket_path.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | let fut = async move { handle_connection(&mut tcp_stream, &path).await }; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 19 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ntpd` (lib) due to 20 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: struct `TestClock` is never constructed [INFO] [stdout] --> src/daemon/observer.rs:203:12 [INFO] [stdout] | [INFO] [stdout] 203 | struct TestClock {} [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TestClock` has a derived impl for the trait `Default`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/config/ntp_source.rs:39:11 [INFO] [stdout] | [INFO] [stdout] 33 | deserializer: D, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | match certificates_from_file(&certificate_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/config/ntp_source.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 141 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | Ok(NormalizedAddress::from_string_ntp(s) [INFO] [stdout] | ____________^ [INFO] [stdout] 147 | | .map_err(serde::de::Error::custom)? [INFO] [stdout] 148 | | .into()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/config/ntp_source.rs:158:12 [INFO] [stdout] | [INFO] [stdout] 153 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | Ok(NtsKeAddress( [INFO] [stdout] | ____________^ [INFO] [stdout] 159 | | NormalizedAddress::from_string_nts_ke(s).map_err(serde::de::Error::custom)?, [INFO] [stdout] 160 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/config/ntp_source.rs:200:12 [INFO] [stdout] | [INFO] [stdout] 200 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 201 | | server_name, [INFO] [stdout] 202 | | port, [INFO] [stdout] ... | [INFO] [stdout] 205 | | hardcoded_dns_resolve: HardcodedDnsResolve::default(), [INFO] [stdout] 206 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/config/ntp_source.rs:213:12 [INFO] [stdout] | [INFO] [stdout] 213 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 214 | | server_name, [INFO] [stdout] 215 | | port, [INFO] [stdout] ... | [INFO] [stdout] 218 | | hardcoded_dns_resolve: HardcodedDnsResolve::default(), [INFO] [stdout] 219 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/keyexchange.rs:83:18 [INFO] [stdout] | [INFO] [stdout] 81 | keyset: tokio::sync::watch::Receiver>, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | ) -> JoinHandle> { [INFO] [stdout] 83 | tokio::spawn(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 84 | | let result = run_nts_ke(nts_ke_config, keyset).await; [INFO] [stdout] 85 | | [INFO] [stdout] 86 | | match result { [INFO] [stdout] ... | [INFO] [stdout] 92 | | } [INFO] [stdout] 93 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/keyexchange.rs:174:8 [INFO] [stdout] | [INFO] [stdout] 157 | let mut config = rustls::ServerConfig::builder_with_protocol_versions(&[&TLS13]) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | Ok(Arc::new(config)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/keyexchange.rs:243:17 [INFO] [stdout] | [INFO] [stdout] 214 | let (stream, source_addr) = match listener.accept().await { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 236 | let config = config.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | let keyset = keyset.borrow().clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | let pool_certs = pool_certs.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | / BoundKeyExchangeServer::run( [INFO] [stdout] 244 | | stream, [INFO] [stdout] 245 | | config, [INFO] [stdout] 246 | | keyset, [INFO] [stdout] ... | [INFO] [stdout] 250 | | ) [INFO] [stdout] 251 | | .await [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/keyexchange.rs:284:12 [INFO] [stdout] | [INFO] [stdout] 279 | io: IO, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 280 | server_name: String, [INFO] [stdout] 281 | config: rustls::ClientConfig, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 282 | denied_servers: impl IntoIterator, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 283 | ) -> Result { [INFO] [stdout] 284 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 285 | | inner: Some(BoundKeyExchangeClientData { [INFO] [stdout] 286 | | io, [INFO] [stdout] 287 | | client: KeyExchangeClient::new(server_name, config, denied_servers)?, [INFO] [stdout] 288 | | need_flush: false, [INFO] [stdout] 289 | | }), [INFO] [stdout] 290 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/keyexchange.rs:422:12 [INFO] [stdout] | [INFO] [stdout] 409 | io: IO, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 410 | config: Arc, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 411 | keyset: Arc, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 414 | pool_certs: Arc<[rustls::pki_types::CertificateDer<'static>]>, [INFO] [stdout] | ------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 415 | ) -> Result { [INFO] [stdout] 416 | let data = BoundKeyExchangeServerData { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 422 | Ok(Self { inner: Some(data) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/keyexchange.rs:607:5 [INFO] [stdout] | [INFO] [stdout] 605 | mut reader: impl BufRead, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 606 | ) -> std::io::Result>> { [INFO] [stdout] 607 | rustls_pemfile::certs(&mut reader).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/ntp_source.rs:523:17 [INFO] [stdout] | [INFO] [stdout] 517 | let state = Arc::new(std::sync::Mutex::new(TestWaitState { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 523 | / TestWait { [INFO] [stdout] 524 | | state: state.clone(), [INFO] [stdout] 525 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/ntp_source.rs:526:17 [INFO] [stdout] | [INFO] [stdout] 517 | let state = Arc::new(std::sync::Mutex::new(TestWaitState { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 526 | TestWaitSender { state }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/nts_key_provider.rs:35:37 [INFO] [stdout] | [INFO] [stdout] 35 | .unwrap_or_else(|e| Err(std::io::Error::new(std::io::ErrorKind::Other, e))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/nts_key_provider.rs:39:21 [INFO] [stdout] | [INFO] [stdout] 36 | .unwrap_or_else(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | KeySetProvider::new(config.stale_key_count), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/observer.rs:148:14 [INFO] [stdout] | [INFO] [stdout] 113 | let (mut stream, _addr) = match observe_listener.accept().await { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | let sources_reader = sources_reader.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | let server_reader = server_reader.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | let system_reader = system_reader.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/server.rs:99:12 [INFO] [stdout] | [INFO] [stdout] 94 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | let value = Arc::new(Deserialize::deserialize(deserializer)?); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | Ok(Counter { value }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/server.rs:121:22 [INFO] [stdout] | [INFO] [stdout] 115 | stats: ServerStats, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | mut system_receiver: tokio::sync::watch::Receiver, [INFO] [stdout] | ----------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | mut keyset: tokio::sync::watch::Receiver>, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | clock: C, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 122 | | let server = Server::new( [INFO] [stdout] 123 | | config.clone().into(), [INFO] [stdout] 124 | | clock, [INFO] [stdout] ... | [INFO] [stdout] 138 | | process.serve().await; [INFO] [stdout] 139 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/spawn/mod.rs:122:29 [INFO] [stdout] | [INFO] [stdout] 118 | normalized_addr: NormalizedAddress, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | protocol_version: ProtocolVersion, [INFO] [stdout] 120 | nts: Option>, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | ) -> SpawnAction { [INFO] [stdout] 122 | SpawnAction::Create(SourceCreateParameters { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 123 | | id, [INFO] [stdout] 124 | | addr, [INFO] [stdout] 125 | | normalized_addr, [INFO] [stdout] 126 | | protocol_version, [INFO] [stdout] 127 | | nts, [INFO] [stdout] 128 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/spawn/mod.rs:178:34 [INFO] [stdout] | [INFO] [stdout] 177 | _event: SourceCreateParameters, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | ) -> Result<(), Self::Error> { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 179 | | Ok(()) [INFO] [stdout] 180 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/system.rs:45:20 [INFO] [stdout] | [INFO] [stdout] 42 | fn new_disabled(t: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | sleep: Box::pin(t), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/system.rs:153:27 [INFO] [stdout] | [INFO] [stdout] 97 | let (mut system, channels) = SystemTask::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | let sleep = [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | SingleshotSleep::new_disabled(tokio::time::sleep_until(tokio::time::Instant::now())); [INFO] [stdout] 152 | tokio::pin!(sleep); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | system.run(sleep).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/system.rs:224:13 [INFO] [stdout] | [INFO] [stdout] 197 | clock: C, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | keyset: tokio::sync::watch::Receiver>, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | ip_list: tokio::sync::watch::Receiver>, [INFO] [stdout] | ---------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | ) -> (Self, DaemonChannels) { [INFO] [stdout] 205 | let system = System::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | let (system_snapshot_sender, system_snapshot_receiver) = [INFO] [stdout] | ---------------------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | tokio::sync::watch::channel(system.system_snapshot()); [INFO] [stdout] 215 | let source_snapshots = Arc::new(RwLock::new(HashMap::new())); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 216 | let (server_data_sender, server_data_receiver) = tokio::sync::watch::channel(vec![]); [INFO] [stdout] | ------------------ -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | let (msg_for_system_sender, msg_for_system_receiver) = [INFO] [stdout] | --------------------- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | tokio::sync::mpsc::channel(MESSAGE_BUFFER_SIZE); [INFO] [stdout] 219 | let (system_update_sender, _) = tokio::sync::broadcast::channel(MESSAGE_BUFFER_SIZE); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | let (spawn_tx, spawn_rx) = mpsc::channel(MESSAGE_BUFFER_SIZE); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 224 | / SystemTask { [INFO] [stdout] 225 | | _wait: PhantomData, [INFO] [stdout] 226 | | system, [INFO] [stdout] ... | [INFO] [stdout] 245 | | interface, [INFO] [stdout] 246 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/system.rs:247:13 [INFO] [stdout] | [INFO] [stdout] 197 | clock: C, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | keyset: tokio::sync::watch::Receiver>, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | ip_list: tokio::sync::watch::Receiver>, [INFO] [stdout] | ---------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | ) -> (Self, DaemonChannels) { [INFO] [stdout] 205 | let system = System::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | let (system_snapshot_sender, system_snapshot_receiver) = [INFO] [stdout] | ---------------------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | tokio::sync::watch::channel(system.system_snapshot()); [INFO] [stdout] 215 | let source_snapshots = Arc::new(RwLock::new(HashMap::new())); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 216 | let (server_data_sender, server_data_receiver) = tokio::sync::watch::channel(vec![]); [INFO] [stdout] | ------------------ -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | let (msg_for_system_sender, msg_for_system_receiver) = [INFO] [stdout] | --------------------- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | tokio::sync::mpsc::channel(MESSAGE_BUFFER_SIZE); [INFO] [stdout] 219 | let (system_update_sender, _) = tokio::sync::broadcast::channel(MESSAGE_BUFFER_SIZE); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | let (spawn_tx, spawn_rx) = mpsc::channel(MESSAGE_BUFFER_SIZE); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | / DaemonChannels { [INFO] [stdout] 248 | | source_snapshots, [INFO] [stdout] 249 | | server_data_receiver, [INFO] [stdout] 250 | | system_snapshot_receiver, [INFO] [stdout] 251 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics/exporter.rs:200:74 [INFO] [stdout] | [INFO] [stdout] 176 | let (mut tcp_stream, _) = match listener.accept().await { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | let path = observation_socket_path.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | let fut = async move { handle_connection(&mut tcp_stream, &path).await }; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 25 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ntpd` (lib test) due to 26 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "f5e4721d4487688c7caa62eff7144af01f0cf714d7c4b2fa8de5f8589d29da97", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f5e4721d4487688c7caa62eff7144af01f0cf714d7c4b2fa8de5f8589d29da97", kill_on_drop: false }` [INFO] [stdout] f5e4721d4487688c7caa62eff7144af01f0cf714d7c4b2fa8de5f8589d29da97