[INFO] fetching crate nt_hive2 4.2.3... [INFO] checking nt_hive2-4.2.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate nt_hive2 4.2.3 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate nt_hive2 4.2.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nt_hive2 4.2.3 [INFO] finished tweaking crates.io crate nt_hive2 4.2.3 [INFO] tweaked toml for crates.io crate nt_hive2 4.2.3 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate nt_hive2 4.2.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f55a42af176c6bb05ab1e4d850867b5f4202bf42168f161eea849c7dbfe5311c [INFO] running `Command { std: "docker" "start" "-a" "f55a42af176c6bb05ab1e4d850867b5f4202bf42168f161eea849c7dbfe5311c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f55a42af176c6bb05ab1e4d850867b5f4202bf42168f161eea849c7dbfe5311c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f55a42af176c6bb05ab1e4d850867b5f4202bf42168f161eea849c7dbfe5311c", kill_on_drop: false }` [INFO] [stdout] f55a42af176c6bb05ab1e4d850867b5f4202bf42168f161eea849c7dbfe5311c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 85c81fae97c898db8f401a7e074bc78854af59bc72cc3fcba8d2f4015303d67b [INFO] running `Command { std: "docker" "start" "-a" "85c81fae97c898db8f401a7e074bc78854af59bc72cc3fcba8d2f4015303d67b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Compiling rustversion v1.0.15 [INFO] [stderr] Compiling serde_json v1.0.115 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling paste-impl v0.1.18 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling either v1.10.0 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Compiling anyhow v1.0.82 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking paste v0.1.18 [INFO] [stderr] Checking marvin32 v0.1.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling syn v2.0.58 [INFO] [stderr] Checking time v0.3.35 [INFO] [stderr] Checking simplelog v0.12.2 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Checking memoverlay v0.1.3 [INFO] [stderr] Compiling binread_derive v2.1.0 [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Compiling binwrite_derive v0.2.1 [INFO] [stderr] Compiling getset v0.1.2 [INFO] [stderr] Compiling derive-getters v0.3.0 [INFO] [stderr] Checking binwrite v0.2.1 [INFO] [stderr] Checking binread v2.2.0 [INFO] [stderr] Checking chrono v0.4.37 [INFO] [stderr] Checking winstructs v0.3.2 [INFO] [stderr] Checking nt_hive2 v4.2.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hive/mod.rs:287:12 [INFO] [stdout] | [INFO] [stdout] 285 | let cell: Cell = self.read_le().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 286 | assert!(cell.is_allocated()); [INFO] [stdout] 287 | Ok(cell.into()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hive/hive_with_logs.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 18 | fn with_transaction_log(self, log: TransactionLog) -> anyhow::Result> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | Ok(HiveWithLogs { [INFO] [stdout] | ____________^ [INFO] [stdout] 44 | | hive: self, [INFO] [stdout] 45 | | transaction_logs, [INFO] [stdout] 46 | | phantom: PhantomData, [INFO] [stdout] 47 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hivebin/mod.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn new(hive: Rc>>) -> BinResult { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let hivebin = hive.borrow_mut().read_le()?; [INFO] [stdout] 55 | Ok(Self { hive, hivebin }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nk.rs:274:23 [INFO] [stdout] | [INFO] [stdout] 274 | .find(|s| s.borrow().name().to_lowercase() == lowercase_name) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nt_hive2` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hive/mod.rs:287:12 [INFO] [stdout] | [INFO] [stdout] 285 | let cell: Cell = self.read_le().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 286 | assert!(cell.is_allocated()); [INFO] [stdout] 287 | Ok(cell.into()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hive/hive_with_logs.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 18 | fn with_transaction_log(self, log: TransactionLog) -> anyhow::Result> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | Ok(HiveWithLogs { [INFO] [stdout] | ____________^ [INFO] [stdout] 44 | | hive: self, [INFO] [stdout] 45 | | transaction_logs, [INFO] [stdout] 46 | | phantom: PhantomData, [INFO] [stdout] 47 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hivebin/mod.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn new(hive: Rc>>) -> BinResult { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let hivebin = hive.borrow_mut().read_le()?; [INFO] [stdout] 55 | Ok(Self { hive, hivebin }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nk.rs:274:23 [INFO] [stdout] | [INFO] [stdout] 274 | .find(|s| s.borrow().name().to_lowercase() == lowercase_name) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nt_hive2` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "85c81fae97c898db8f401a7e074bc78854af59bc72cc3fcba8d2f4015303d67b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "85c81fae97c898db8f401a7e074bc78854af59bc72cc3fcba8d2f4015303d67b", kill_on_drop: false }` [INFO] [stdout] 85c81fae97c898db8f401a7e074bc78854af59bc72cc3fcba8d2f4015303d67b