[INFO] fetching crate nt-rs 0.0.1... [INFO] checking nt-rs-0.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate nt-rs 0.0.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate nt-rs 0.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nt-rs 0.0.1 [INFO] finished tweaking crates.io crate nt-rs 0.0.1 [INFO] tweaked toml for crates.io crate nt-rs 0.0.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate nt-rs 0.0.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 470b43d5180f7d577f0572d23c84875ae9a2260a6e9a6514e335612dd19cbee9 [INFO] running `Command { std: "docker" "start" "-a" "470b43d5180f7d577f0572d23c84875ae9a2260a6e9a6514e335612dd19cbee9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "470b43d5180f7d577f0572d23c84875ae9a2260a6e9a6514e335612dd19cbee9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "470b43d5180f7d577f0572d23c84875ae9a2260a6e9a6514e335612dd19cbee9", kill_on_drop: false }` [INFO] [stdout] 470b43d5180f7d577f0572d23c84875ae9a2260a6e9a6514e335612dd19cbee9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b48fbf0ae7f7e30cfc8521345c17cddb7de9d9d70816561eff8fb6b21cc7064e [INFO] running `Command { std: "docker" "start" "-a" "b48fbf0ae7f7e30cfc8521345c17cddb7de9d9d70816561eff8fb6b21cc7064e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.73 [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking unicode-bidi v0.3.14 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling thiserror v1.0.53 [INFO] [stderr] Compiling quote v1.0.34 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Compiling serde v1.0.193 [INFO] [stderr] Checking cpufeatures v0.2.11 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking http v1.0.0 [INFO] [stderr] Compiling syn v2.0.45 [INFO] [stderr] Checking data-encoding v2.5.0 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling serde_json v1.0.109 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking flume v0.11.0 [INFO] [stderr] Checking rmp v0.8.12 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.53 [INFO] [stderr] Compiling serde_derive v1.0.193 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Checking tokio v1.35.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tungstenite v0.21.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-tungstenite v0.21.0 [INFO] [stderr] Checking nt-rs v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:364:45 [INFO] [stdout] | [INFO] [stdout] 362 | let inner = self.inner.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 363 | [INFO] [stdout] 364 | async move { inner.main_loop::().await } [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:382:12 [INFO] [stdout] | [INFO] [stdout] 369 | let (sender, receiver) = unbounded(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 382 | Ok(Subscriber { [INFO] [stdout] | ____________^ [INFO] [stdout] 383 | | name, [INFO] [stdout] 384 | | properties: None, [INFO] [stdout] 385 | | input: receiver, [INFO] [stdout] ... | [INFO] [stdout] 388 | | phantom: PhantomData, [INFO] [stdout] 389 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:398:12 [INFO] [stdout] | [INFO] [stdout] 398 | Ok(Publisher { [INFO] [stdout] | ____________^ [INFO] [stdout] 399 | | name, [INFO] [stdout] 400 | | id, [INFO] [stdout] 401 | | client: self.inner.clone(), [INFO] [stdout] 402 | | phantom: PhantomData, [INFO] [stdout] 403 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backend.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 25 | send: flume::Sender>, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | receive: flume::Receiver, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | ) -> Result { [INFO] [stdout] 28 | let uri = Uri::from_str(&format!("ws://{host}:5810/nt/{name}"))?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | [INFO] [stdout] 30 | let send2 = send.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | [INFO] [stdout] 32 | Ok(tokio::spawn(async move { [INFO] [stdout] | ____________^ [INFO] [stdout] 33 | | let req = Request::builder() [INFO] [stdout] 34 | | .method("GET") [INFO] [stdout] 35 | | .header("Host", uri.host().unwrap()) [INFO] [stdout] ... | [INFO] [stdout] 97 | | } [INFO] [stdout] 98 | | }))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/payload.rs:127:25 [INFO] [stdout] | [INFO] [stdout] 126 | fn to_val(self) -> BinaryData { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | BinaryData::Str(serde_json::to_string(&self.0).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 86 | deserializer: D, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | ) -> Result, D::Error> { [INFO] [stdout] 88 | >::deserialize(deserializer).map(|option| option.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nt-rs` (lib test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:364:45 [INFO] [stdout] | [INFO] [stdout] 362 | let inner = self.inner.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 363 | [INFO] [stdout] 364 | async move { inner.main_loop::().await } [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:382:12 [INFO] [stdout] | [INFO] [stdout] 369 | let (sender, receiver) = unbounded(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 382 | Ok(Subscriber { [INFO] [stdout] | ____________^ [INFO] [stdout] 383 | | name, [INFO] [stdout] 384 | | properties: None, [INFO] [stdout] 385 | | input: receiver, [INFO] [stdout] ... | [INFO] [stdout] 388 | | phantom: PhantomData, [INFO] [stdout] 389 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:398:12 [INFO] [stdout] | [INFO] [stdout] 398 | Ok(Publisher { [INFO] [stdout] | ____________^ [INFO] [stdout] 399 | | name, [INFO] [stdout] 400 | | id, [INFO] [stdout] 401 | | client: self.inner.clone(), [INFO] [stdout] 402 | | phantom: PhantomData, [INFO] [stdout] 403 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backend.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 25 | send: flume::Sender>, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | receive: flume::Receiver, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | ) -> Result { [INFO] [stdout] 28 | let uri = Uri::from_str(&format!("ws://{host}:5810/nt/{name}"))?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | [INFO] [stdout] 30 | let send2 = send.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | [INFO] [stdout] 32 | Ok(tokio::spawn(async move { [INFO] [stdout] | ____________^ [INFO] [stdout] 33 | | let req = Request::builder() [INFO] [stdout] 34 | | .method("GET") [INFO] [stdout] 35 | | .header("Host", uri.host().unwrap()) [INFO] [stdout] ... | [INFO] [stdout] 97 | | } [INFO] [stdout] 98 | | }))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/payload.rs:127:25 [INFO] [stdout] | [INFO] [stdout] 126 | fn to_val(self) -> BinaryData { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | BinaryData::Str(serde_json::to_string(&self.0).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 86 | deserializer: D, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | ) -> Result, D::Error> { [INFO] [stdout] 88 | >::deserialize(deserializer).map(|option| option.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nt-rs` (lib) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "b48fbf0ae7f7e30cfc8521345c17cddb7de9d9d70816561eff8fb6b21cc7064e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b48fbf0ae7f7e30cfc8521345c17cddb7de9d9d70816561eff8fb6b21cc7064e", kill_on_drop: false }` [INFO] [stdout] b48fbf0ae7f7e30cfc8521345c17cddb7de9d9d70816561eff8fb6b21cc7064e