[INFO] fetching crate nswrap 0.1.0... [INFO] checking nswrap-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate nswrap 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate nswrap 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nswrap 0.1.0 [INFO] finished tweaking crates.io crate nswrap 0.1.0 [INFO] tweaked toml for crates.io crate nswrap 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 43 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding darling v0.14.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_core v0.14.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_macro v0.14.4 (latest: v0.20.10) [INFO] [stderr] Adding derive_builder v0.12.0 (latest: v0.20.1) [INFO] [stderr] Adding derive_builder_core v0.12.0 (latest: v0.20.1) [INFO] [stderr] Adding derive_builder_macro v0.12.0 (latest: v0.20.1) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding memoffset v0.7.1 (latest: v0.9.1) [INFO] [stderr] Adding nix v0.26.4 (latest: v0.29.0) [INFO] [stderr] Adding strsim v0.10.0 (latest: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7485df60709cca4ae59eca3b3ac036c3836585e8c2f60a94b7c6176c9d21e407 [INFO] running `Command { std: "docker" "start" "-a" "7485df60709cca4ae59eca3b3ac036c3836585e8c2f60a94b7c6176c9d21e407", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7485df60709cca4ae59eca3b3ac036c3836585e8c2f60a94b7c6176c9d21e407", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7485df60709cca4ae59eca3b3ac036c3836585e8c2f60a94b7c6176c9d21e407", kill_on_drop: false }` [INFO] [stdout] 7485df60709cca4ae59eca3b3ac036c3836585e8c2f60a94b7c6176c9d21e407 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3ed39dd75ea1d3be4d72c7bcf8ec4b9e46cac55555598d00d0361eed9e460f85 [INFO] running `Command { std: "docker" "start" "-a" "3ed39dd75ea1d3be4d72c7bcf8ec4b9e46cac55555598d00d0361eed9e460f85", kill_on_drop: false }` [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking xdg v2.5.2 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Compiling darling_core v0.14.4 [INFO] [stderr] Compiling getset v0.1.2 [INFO] [stderr] Compiling darling_macro v0.14.4 [INFO] [stderr] Compiling darling v0.14.4 [INFO] [stderr] Compiling derive_builder_core v0.12.0 [INFO] [stderr] Compiling derive_builder_macro v0.12.0 [INFO] [stderr] Checking derive_builder v0.12.0 [INFO] [stderr] Checking nswrap v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:321:13 [INFO] [stdout] | [INFO] [stdout] 321 | let mut set; [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `set_root` and `add_mount` are never used [INFO] [stdout] --> src/lib.rs:349:8 [INFO] [stdout] | [INFO] [stdout] 315 | impl<'a> Wrap<'_> { [INFO] [stdout] | ----------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 349 | fn set_root(&mut self, root: config::Root) -> &mut Self { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 355 | fn add_mount(&mut self, mnt: config::Mount) -> &mut Self { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `root` and `mounts` are never read [INFO] [stdout] --> src/core.rs:47:16 [INFO] [stdout] | [INFO] [stdout] 45 | pub(crate) struct WrapInner<'a> { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 46 | pub(crate) process: config::Process, [INFO] [stdout] 47 | pub(crate) root: Option, [INFO] [stdout] | ^^^^ [INFO] [stdout] 48 | [INFO] [stdout] 49 | pub(crate) mounts: Vec, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:321:13 [INFO] [stdout] | [INFO] [stdout] 321 | let mut set; [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `set_root` and `add_mount` are never used [INFO] [stdout] --> src/lib.rs:349:8 [INFO] [stdout] | [INFO] [stdout] 315 | impl<'a> Wrap<'_> { [INFO] [stdout] | ----------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 349 | fn set_root(&mut self, root: config::Root) -> &mut Self { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 355 | fn add_mount(&mut self, mnt: config::Mount) -> &mut Self { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `root` and `mounts` are never read [INFO] [stdout] --> src/core.rs:47:16 [INFO] [stdout] | [INFO] [stdout] 45 | pub(crate) struct WrapInner<'a> { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 46 | pub(crate) process: config::Process, [INFO] [stdout] 47 | pub(crate) root: Option, [INFO] [stdout] | ^^^^ [INFO] [stdout] 48 | [INFO] [stdout] 49 | pub(crate) mounts: Vec, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:128:15 [INFO] [stdout] | [INFO] [stdout] 127 | let thread_join_handle = thread::spawn(move || unshare(CloneFlags::NEWUSER).unwrap_err()); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | match thread_join_handle.join().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> tests/basic.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | fs::remove_dir_all(_TMP_DIR); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 33 | let _ = fs::remove_dir_all(_TMP_DIR); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/basic.rs:106:16 [INFO] [stdout] | [INFO] [stdout] 98 | let thread_join_handle = thread::spawn(move || { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | assert_eq!(thread_join_handle.join().unwrap().success(), true) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nswrap` (test "basic") due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nswrap` (lib test) due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3ed39dd75ea1d3be4d72c7bcf8ec4b9e46cac55555598d00d0361eed9e460f85", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3ed39dd75ea1d3be4d72c7bcf8ec4b9e46cac55555598d00d0361eed9e460f85", kill_on_drop: false }` [INFO] [stdout] 3ed39dd75ea1d3be4d72c7bcf8ec4b9e46cac55555598d00d0361eed9e460f85