[INFO] fetching crate nsh 0.4.2... [INFO] checking nsh-0.4.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate nsh 0.4.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate nsh 0.4.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nsh 0.4.2 [INFO] finished tweaking crates.io crate nsh 0.4.2 [INFO] tweaked toml for crates.io crate nsh 0.4.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate nsh 0.4.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d3f70df080cb48755016688a2edbf403c60b3e42e3e7a575cf65deff62965a5d [INFO] running `Command { std: "docker" "start" "-a" "d3f70df080cb48755016688a2edbf403c60b3e42e3e7a575cf65deff62965a5d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d3f70df080cb48755016688a2edbf403c60b3e42e3e7a575cf65deff62965a5d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d3f70df080cb48755016688a2edbf403c60b3e42e3e7a575cf65deff62965a5d", kill_on_drop: false }` [INFO] [stdout] d3f70df080cb48755016688a2edbf403c60b3e42e3e7a575cf65deff62965a5d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 36077f61c4ad8d6d5dd9d95c2a238691ba66dda694e3a1519f2c9fe1bcfaa3ce [INFO] running `Command { std: "docker" "start" "-a" "36077f61c4ad8d6d5dd9d95c2a238691ba66dda694e3a1519f2c9fe1bcfaa3ce", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.98 [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.73 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Compiling ppv-lite86 v0.2.10 [INFO] [stderr] Compiling cc v1.0.69 [INFO] [stderr] Compiling ucd-trie v0.1.3 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling siphasher v0.3.5 [INFO] [stderr] Checking instant v0.1.10 [INFO] [stderr] Compiling phf_shared v0.9.0 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling pest v2.1.3 [INFO] [stderr] Compiling maplit v1.0.2 [INFO] [stderr] Checking gimli v0.24.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking rustc-demangle v0.1.20 [INFO] [stderr] Checking lock_api v0.4.4 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking object v0.25.3 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking glob v0.3.0 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking diff v0.1.12 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Compiling backtrace v0.3.60 [INFO] [stderr] Compiling pest_meta v2.1.3 [INFO] [stderr] Checking pretty_assertions v0.7.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking parking_lot_core v0.8.3 [INFO] [stderr] Checking mio v0.7.13 [INFO] [stderr] Checking nix v0.22.0 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Checking colored v1.9.3 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking addr2line v0.15.2 [INFO] [stderr] Checking fern v0.6.0 [INFO] [stderr] Checking signal-hook v0.2.3 [INFO] [stderr] Checking signal-hook v0.1.17 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking crossterm v0.18.2 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking tempfile v3.2.0 [INFO] [stderr] Compiling phf_generator v0.9.0 [INFO] [stderr] Compiling synstructure v0.12.5 [INFO] [stderr] Compiling pest_generator v2.1.3 [INFO] [stderr] Compiling phf_macros v0.9.0 [INFO] [stderr] Compiling structopt-derive v0.4.15 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking phf v0.9.0 [INFO] [stderr] Checking structopt v0.3.22 [INFO] [stderr] Checking nsh v0.4.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/process.rs:472:17 [INFO] [stdout] | [INFO] [stdout] 472 | Ok(_) => { [INFO] [stdout] | ^^^^^ matches no values because `Infallible` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/process.rs:472:17 [INFO] [stdout] | [INFO] [stdout] 472 | Ok(_) => { [INFO] [stdout] | ^^^^^ matches no values because `Infallible` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `login` is never read [INFO] [stdout] --> src/main.rs:153:5 [INFO] [stdout] | [INFO] [stdout] 144 | struct Opt { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 153 | login: bool, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Opt` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:68:5 [INFO] [stdout] | [INFO] [stdout] 55 | fn interactive_mode(shell: shell::Shell) -> ExitStatus { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | mainloop::Mainloop::new(shell).run() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `login` is never read [INFO] [stdout] --> src/main.rs:153:5 [INFO] [stdout] | [INFO] [stdout] 144 | struct Opt { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 153 | login: bool, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Opt` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:68:5 [INFO] [stdout] | [INFO] [stdout] 55 | fn interactive_mode(shell: shell::Shell) -> ExitStatus { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | mainloop::Mainloop::new(shell).run() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:386:34 [INFO] [stdout] | [INFO] [stdout] 386 | .map(|p| self.visit_escaped_word(p, true).0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:386:34 [INFO] [stdout] | [INFO] [stdout] 386 | .map(|p| self.visit_escaped_word(p, true).0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nsh` (bin "nsh") due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `nsh` (bin "nsh" test) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "36077f61c4ad8d6d5dd9d95c2a238691ba66dda694e3a1519f2c9fe1bcfaa3ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "36077f61c4ad8d6d5dd9d95c2a238691ba66dda694e3a1519f2c9fe1bcfaa3ce", kill_on_drop: false }` [INFO] [stdout] 36077f61c4ad8d6d5dd9d95c2a238691ba66dda694e3a1519f2c9fe1bcfaa3ce