[INFO] fetching crate nrc-protobuf-codegen 2.8.0... [INFO] checking nrc-protobuf-codegen-2.8.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate nrc-protobuf-codegen 2.8.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate nrc-protobuf-codegen 2.8.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nrc-protobuf-codegen 2.8.0 [INFO] finished tweaking crates.io crate nrc-protobuf-codegen 2.8.0 [INFO] tweaked toml for crates.io crate nrc-protobuf-codegen 2.8.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate nrc-protobuf-codegen 2.8.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 21b422b8cb00ce73fac553d7a9c9816231dae343413ddc58c24a3f6dde17b229 [INFO] running `Command { std: "docker" "start" "-a" "21b422b8cb00ce73fac553d7a9c9816231dae343413ddc58c24a3f6dde17b229", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "21b422b8cb00ce73fac553d7a9c9816231dae343413ddc58c24a3f6dde17b229", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "21b422b8cb00ce73fac553d7a9c9816231dae343413ddc58c24a3f6dde17b229", kill_on_drop: false }` [INFO] [stdout] 21b422b8cb00ce73fac553d7a9c9816231dae343413ddc58c24a3f6dde17b229 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4e21f56597da8f8dca823d8f2ea3f57146fe1aef86f1b34460bba84e21dcca09 [INFO] running `Command { std: "docker" "start" "-a" "4e21f56597da8f8dca823d8f2ea3f57146fe1aef86f1b34460bba84e21dcca09", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking unicode-segmentation v1.6.0 [INFO] [stderr] Compiling nrc-protobuf v2.8.0 [INFO] [stderr] Checking hex v0.3.2 [INFO] [stderr] Checking heck v0.3.1 [INFO] [stderr] Checking nrc-protobuf-codegen v2.8.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/message.rs:301:77 [INFO] [stdout] | [INFO] [stdout] 301 | ... self.write_descriptor_field("fields", field, w);; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/message.rs:301:77 [INFO] [stdout] | [INFO] [stdout] 301 | ... self.write_descriptor_field("fields", field, w);; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/field.rs:184:5 [INFO] [stdout] | [INFO] [stdout] 183 | pub struct MapField { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 184 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MapField` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `1` is never read [INFO] [stdout] --> src/field.rs:226:21 [INFO] [stdout] | [INFO] [stdout] 226 | Message(String, String, Option>), [INFO] [stdout] | ------- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `FieldElem` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 226 | Message(String, (), Option>), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `1` is never read [INFO] [stdout] --> src/field.rs:228:18 [INFO] [stdout] | [INFO] [stdout] 228 | Enum(String, String, RustIdent), [INFO] [stdout] | ---- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `FieldElem` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 228 | Enum(String, (), RustIdent), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `root_scope` is never read [INFO] [stdout] --> src/field.rs:409:5 [INFO] [stdout] | [INFO] [stdout] 408 | pub struct FieldGen<'a> { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 409 | root_scope: &'a RootScope<'a>, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FieldGen` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `oneof`, `variant`, and `customize` are never read [INFO] [stdout] --> src/oneof.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 76 | pub struct OneofVariantGen<'a> { [INFO] [stdout] | --------------- fields in this struct [INFO] [stdout] 77 | oneof: &'a OneofGen<'a>, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 78 | variant: OneofVariantWithContext<'a>, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 82 | customize: Customize, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `OneofVariantGen` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `lite_runtime` is never read [INFO] [stdout] --> src/oneof.rs:129:5 [INFO] [stdout] | [INFO] [stdout] 124 | pub struct OneofGen<'a> { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 129 | lite_runtime: bool, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `OneofGen` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/field.rs:772:32 [INFO] [stdout] | [INFO] [stdout] 772 | .unwrap_or_else(|| self.get_xxx_return_type().default_value(&self.customize)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/oneof.rs:59:30 [INFO] [stdout] | [INFO] [stdout] 51 | elem: FieldElem, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | oneof_type_name: RustType::Oneof(oneof.rust_name()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/oneof.rs:103:26 [INFO] [stdout] | [INFO] [stdout] 93 | let mut field = field.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | oneof_field: OneofField::parse( [INFO] [stdout] | __________________________^ [INFO] [stdout] 104 | | variant.oneof, [INFO] [stdout] 105 | | &field.proto_field, [INFO] [stdout] 106 | | field.oneof().elem.clone(), [INFO] [stdout] 107 | | oneof.message.root_scope, [INFO] [stdout] 108 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust_types_values.rs:403:24 [INFO] [stdout] | [INFO] [stdout] 402 | pub fn boxed(self, customize: &Customize) -> RustValueTyped { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 403 | self.into_type(RustType::Uniq(Box::new(self.rust_type.clone())), customize) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/field.rs:184:5 [INFO] [stdout] | [INFO] [stdout] 183 | pub struct MapField { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 184 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MapField` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `1` is never read [INFO] [stdout] --> src/field.rs:226:21 [INFO] [stdout] | [INFO] [stdout] 226 | Message(String, String, Option>), [INFO] [stdout] | ------- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `FieldElem` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 226 | Message(String, (), Option>), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `1` is never read [INFO] [stdout] --> src/field.rs:228:18 [INFO] [stdout] | [INFO] [stdout] 228 | Enum(String, String, RustIdent), [INFO] [stdout] | ---- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `FieldElem` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 228 | Enum(String, (), RustIdent), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `root_scope` is never read [INFO] [stdout] --> src/field.rs:409:5 [INFO] [stdout] | [INFO] [stdout] 408 | pub struct FieldGen<'a> { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 409 | root_scope: &'a RootScope<'a>, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FieldGen` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `oneof`, `variant`, and `customize` are never read [INFO] [stdout] --> src/oneof.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 76 | pub struct OneofVariantGen<'a> { [INFO] [stdout] | --------------- fields in this struct [INFO] [stdout] 77 | oneof: &'a OneofGen<'a>, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 78 | variant: OneofVariantWithContext<'a>, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 82 | customize: Customize, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `OneofVariantGen` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `lite_runtime` is never read [INFO] [stdout] --> src/oneof.rs:129:5 [INFO] [stdout] | [INFO] [stdout] 124 | pub struct OneofGen<'a> { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 129 | lite_runtime: bool, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `OneofGen` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/field.rs:772:32 [INFO] [stdout] | [INFO] [stdout] 772 | .unwrap_or_else(|| self.get_xxx_return_type().default_value(&self.customize)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/oneof.rs:59:30 [INFO] [stdout] | [INFO] [stdout] 51 | elem: FieldElem, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | oneof_type_name: RustType::Oneof(oneof.rust_name()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/oneof.rs:103:26 [INFO] [stdout] | [INFO] [stdout] 93 | let mut field = field.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | oneof_field: OneofField::parse( [INFO] [stdout] | __________________________^ [INFO] [stdout] 104 | | variant.oneof, [INFO] [stdout] 105 | | &field.proto_field, [INFO] [stdout] 106 | | field.oneof().elem.clone(), [INFO] [stdout] 107 | | oneof.message.root_scope, [INFO] [stdout] 108 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nrc-protobuf-codegen` (lib) due to 5 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust_types_values.rs:403:24 [INFO] [stdout] | [INFO] [stdout] 402 | pub fn boxed(self, customize: &Customize) -> RustValueTyped { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 403 | self.into_type(RustType::Uniq(Box::new(self.rust_type.clone())), customize) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nrc-protobuf-codegen` (lib test) due to 5 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4e21f56597da8f8dca823d8f2ea3f57146fe1aef86f1b34460bba84e21dcca09", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4e21f56597da8f8dca823d8f2ea3f57146fe1aef86f1b34460bba84e21dcca09", kill_on_drop: false }` [INFO] [stdout] 4e21f56597da8f8dca823d8f2ea3f57146fe1aef86f1b34460bba84e21dcca09