[INFO] fetching crate noxious 1.0.4... [INFO] checking noxious-1.0.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate noxious 1.0.4 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate noxious 1.0.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate noxious 1.0.4 [INFO] finished tweaking crates.io crate noxious 1.0.4 [INFO] tweaked toml for crates.io crate noxious 1.0.4 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 102 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bmrng v0.4.0 (latest: v0.5.2) [INFO] [stderr] Adding downcast v0.10.0 (latest: v0.11.0) [INFO] [stderr] Adding float-cmp v0.8.0 (latest: v0.9.0) [INFO] [stderr] Adding fragile v1.2.2 (latest: v2.0.0) [INFO] [stderr] Adding generator v0.6.25 (latest: v0.8.3) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding loom v0.4.1 (latest: v0.7.2) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding mockall v0.9.1 (latest: v0.13.0) [INFO] [stderr] Adding mockall_derive v0.9.1 (latest: v0.13.0) [INFO] [stderr] Adding mockall_double v0.2.1 (latest: v0.3.1) [INFO] [stderr] Adding predicates v1.0.8 (latest: v3.1.2) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding termtree v0.4.1 (latest: v0.5.1) [INFO] [stderr] Adding tokio-util v0.6.10 (latest: v0.7.11) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dc6579f1aabdb5782134d4e586af2b58f24cca7f148968a057dd6942541101da [INFO] running `Command { std: "docker" "start" "-a" "dc6579f1aabdb5782134d4e586af2b58f24cca7f148968a057dd6942541101da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dc6579f1aabdb5782134d4e586af2b58f24cca7f148968a057dd6942541101da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dc6579f1aabdb5782134d4e586af2b58f24cca7f148968a057dd6942541101da", kill_on_drop: false }` [INFO] [stdout] dc6579f1aabdb5782134d4e586af2b58f24cca7f148968a057dd6942541101da [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b26bb81a12a0c9eb32393182b4770e3faf5229a3f0d2e0b4dce0f2bb87d16bc3 [INFO] running `Command { std: "docker" "start" "-a" "b26bb81a12a0c9eb32393182b4770e3faf5229a3f0d2e0b4dce0f2bb87d16bc3", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking predicates-core v1.0.8 [INFO] [stderr] Checking float-cmp v0.8.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking fragile v2.0.0 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking predicates-tree v1.0.11 [INFO] [stderr] Checking fragile v1.2.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking downcast v0.10.0 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-util v0.6.10 [INFO] [stderr] Checking predicates v1.0.8 [INFO] [stderr] Checking bmrng v0.4.0 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Compiling mockall_double v0.2.1 [INFO] [stderr] Compiling mockall_derive v0.9.1 [INFO] [stderr] Checking tokio-test v0.4.4 [INFO] [stderr] Checking noxious v1.0.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `clippy` [INFO] [stdout] --> src/lib.rs:11:13 [INFO] [stdout] | [INFO] [stdout] 11 | #![cfg_attr(feature = "clippy", warn(cast_possible_truncation))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `clippy` [INFO] [stdout] --> src/lib.rs:12:13 [INFO] [stdout] | [INFO] [stdout] 12 | #![cfg_attr(feature = "clippy", warn(cast_possible_wrap))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `clippy` [INFO] [stdout] --> src/lib.rs:13:13 [INFO] [stdout] | [INFO] [stdout] 13 | #![cfg_attr(feature = "clippy", warn(cast_precision_loss))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `clippy` [INFO] [stdout] --> src/lib.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | #![cfg_attr(feature = "clippy", warn(cast_sign_loss))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `clippy` [INFO] [stdout] --> src/lib.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | #![cfg_attr(feature = "clippy", warn(missing_docs_in_private_items))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `clippy` [INFO] [stdout] --> src/lib.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | #![cfg_attr(feature = "clippy", warn(mut_mut))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `clippy` [INFO] [stdout] --> src/lib.rs:17:13 [INFO] [stdout] | [INFO] [stdout] 17 | #![cfg_attr(feature = "clippy", warn(print_stdout))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `clippy` [INFO] [stdout] --> src/lib.rs:18:28 [INFO] [stdout] | [INFO] [stdout] 18 | #![cfg_attr(all(not(test), feature = "clippy"), warn(result_unwrap_used))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `clippy` [INFO] [stdout] --> src/lib.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | #![cfg_attr(feature = "clippy", warn(unseparated_literal_suffix))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `clippy` [INFO] [stdout] --> src/lib.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | #![cfg_attr(feature = "clippy", warn(wrong_pub_self_convention))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/link.rs:48:31 [INFO] [stdout] | [INFO] [stdout] 39 | stop: Stop, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | ) -> Self { [INFO] [stdout] 41 | let (stop, stopper) = stop.fork(); [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | disband_receiver: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/link.rs:137:83 [INFO] [stdout] | [INFO] [stdout] 98 | let (right_end_tx, right_end_rx) = futures_mpsc::channel::(1); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | let mut prev_pipe_read_rx = left_end_rx; [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | tokio::spawn(async move { prev_pipe_read_rx.map(Ok).forward(right_end_tx).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/link.rs:258:22 [INFO] [stdout] | [INFO] [stdout] 253 | close_read_join: JoinHandle>, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 254 | close_write_join: JoinHandle>, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 255 | disband_sender: oneshot::Sender, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 258 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 259 | | let result: Result<(io::Result, io::Result), tokio::task::JoinError> = [INFO] [stdout] 260 | | tokio::try_join!(close_read_join, close_write_join); [INFO] [stdout] 261 | | match result { [INFO] [stdout] ... | [INFO] [stdout] 275 | | } [INFO] [stdout] 276 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:88:10 [INFO] [stdout] | [INFO] [stdout] 86 | fn into_split(self) -> (ReadStream, WriteStream) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let (read_half, write_half) = self.inner.into_split(); [INFO] [stdout] | --------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | (ReadStream::new(read_half), WriteStream::new(write_half)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:88:38 [INFO] [stdout] | [INFO] [stdout] 86 | fn into_split(self) -> (ReadStream, WriteStream) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let (read_half, write_half) = self.inner.into_split(); [INFO] [stdout] | --------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | (ReadStream::new(read_half), WriteStream::new(write_half)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/toxics/slicer.rs:78:19 [INFO] [stdout] | [INFO] [stdout] 57 | data: Bytes, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | let kind = if size_variation > 0 { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | data: Some(data), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `noxious` (lib) due to 7 previous errors; 10 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "b26bb81a12a0c9eb32393182b4770e3faf5229a3f0d2e0b4dce0f2bb87d16bc3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b26bb81a12a0c9eb32393182b4770e3faf5229a3f0d2e0b4dce0f2bb87d16bc3", kill_on_drop: false }` [INFO] [stdout] b26bb81a12a0c9eb32393182b4770e3faf5229a3f0d2e0b4dce0f2bb87d16bc3